Uh oh!
There was an error while loading. Please reload this page.
GEOPY-2965: Move tree_levels implementation to grid-apps - #89
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts the Octree→TreeMesh “level index” computation into a reusable tree_levels helper and updates octree_2_treemesh to use it, aligning level computation with other Octree-handling code in utils.py.
Changes:
- Replaced inline Octree level calculation inside
octree_2_treemeshwith a call to the newtree_levels(mesh)helper. - Added
tree_levels(mesh: Octree)to compute TreeMesh-level indices frommesh.octree_cells["NCells"]. - Minor cleanup in cell-size array construction (
np.fullinstead ofnp.ones(...) * value).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
sebhmg
requested changes
Aug 24, 2026
Uh oh!
There was an error while loading. Please reload this page.
sebhmg
approved these changes
Aug 24, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2965 - Move tree_levels implementation to grid-apps