Uh oh!
There was an error while loading. Please reload this page.
Feature/uijson - #90
Merged
Merged
Conversation
# Conflicts: # tests/run_tests/grid_model_merger_test.py
# Conflicts: # tests/conftest.py # tests/run_tests/grid_model_merger_test.py
GEOPY-2731: Replace InputFile for BaseUIJson class
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates grid-apps to align with newer geoh5py UI JSON handling and driver execution patterns, while also refreshing the pinned dependency environments.
Changes:
- Migrate tests from
InputFile/BaseUIJsontoUIJsonand adjust parameter setting/building accordingly. - Simplify several drivers’
run()flows (removing monitoring-directory updates and consolidating grid creation intorun()where applicable). - Update UI JSON assets and refresh conda lockfiles (including updated
geoapps-utilsandgeoh5pygit SHAs).
Reviewed changes
Copilot reviewed 21 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/run_tests/octree_creation/run_test.py | Updates octree diagonal-balance test parameterization and workspace object retrieval. |
| tests/run_tests/octree_creation/params_test.py | Switches octree tests to UIJson API and updated value formats. |
| tests/run_tests/block_2_octree_test.py | Switches block→octree tests to UIJson and uses driver.run() consistently. |
| tests/parameters_test.py | Migrates block model parameter test to UIJson + updated Options.build(...) usage. |
| grid_apps/octree_creation/driver.py | Removes redundant init/monitoring update calls; keeps octree build in run(). |
| grid_apps/grid_model_merger/driver.py | Removes monitoring-directory update call from run(). |
| grid_apps/block_models/driver.py | Refactors block model creation so run() performs the grid creation directly. |
| grid_apps/block_model_to_octree/driver.py | Refactors to make run() the single execution entrypoint (replacing make_grid() usage). |
| grid_apps-assets/uijson/block_models.ui.json | Adjusts allowed meshType UUID list for the Block Models UI JSON. |
| environments/py-3.14-win-64.conda.lock.yml | Refreshes pinned Windows py3.14 runtime dependencies and git SHAs. |
| environments/py-3.14-win-64-dev.conda.lock.yml | Refreshes pinned Windows py3.14 dev dependencies and git SHAs. |
| environments/py-3.14-linux-64.conda.lock.yml | Refreshes pinned Linux py3.14 runtime dependencies and git SHAs. |
| environments/py-3.14-linux-64-dev.conda.lock.yml | Refreshes pinned Linux py3.14 dev dependencies and git SHAs. |
| environments/py-3.13-win-64.conda.lock.yml | Refreshes pinned Windows py3.13 runtime dependencies and git SHAs. |
| environments/py-3.13-win-64-dev.conda.lock.yml | Refreshes pinned Windows py3.13 dev dependencies and git SHAs. |
| environments/py-3.13-linux-64.conda.lock.yml | Refreshes pinned Linux py3.13 runtime dependencies and git SHAs. |
| environments/py-3.13-linux-64-dev.conda.lock.yml | Refreshes pinned Linux py3.13 dev dependencies and git SHAs. |
| environments/py-3.12-win-64.conda.lock.yml | Refreshes pinned Windows py3.12 runtime dependencies and git SHAs. |
| environments/py-3.12-win-64-dev.conda.lock.yml | Refreshes pinned Windows py3.12 dev dependencies and git SHAs. |
| environments/py-3.12-linux-64.conda.lock.yml | Refreshes pinned Linux py3.12 runtime dependencies and git SHAs. |
| environments/py-3.12-linux-64-dev.conda.lock.yml | Refreshes pinned Linux py3.12 dev dependencies and git SHAs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.