Uh oh!
There was an error while loading. Please reload this page.
GEOPY-2893: h5 compression level seems ignore (from mira-omf) - #128
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GeoH5 serialization path to better honor HDF5 compression settings (and introduces a configurable HDF5 page size), while updating conversion tests to use GeoH5Writer directly instead of routing through OMFWriter.
Changes:
- Switches geoh5 conversion tests from
omf.OMFWriter(..., *.geoh5)toomf.GeoH5Writer(...). - Updates
GeoH5Writer/conversion code to operate on activeWorkspacehandles and passes compression into entity creation. - Adjusts the shared
random_projecttest fixture (notably scaling up array sizes).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/convert_volume_test.py | Updates volume conversion tests to use GeoH5Writer. |
| tests/convert_surface_test.py | Updates surface conversion tests to use GeoH5Writer. |
| tests/convert_project_test.py | Updates project conversion tests to use GeoH5Writer and adds compression/page size parameters. |
| tests/convert_pointset_test.py | Updates pointset conversion tests to use GeoH5Writer. |
| tests/convert_grid2d_test.py | Updates Grid2D conversion tests to use GeoH5Writer. |
| tests/convert_curve_test.py | Updates curve conversion tests to use GeoH5Writer. |
| tests/conftest.py | Changes the random_project fixture data sizes used across multiple tests. |
| omf/fileio/geoh5.py | Refactors geoh5 writer/conversion plumbing around active workspaces; adds page-size support and compression propagation. |
| omf/fileio/fileio.py | Changes OMFWriter behavior for output file handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sebhmg
left a comment
There was a problem hiding this comment.
code looks code, but need to relock to get proper geoh5py revision
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## release/GA_4.8 #128 +/- ##
==================================================
+ Coverage 92.15% 92.78% +0.62%
==================================================
Files 27 27 Lines 1505 1525 +20 ==================================================
+ Hits 1387 1415 +28 + Misses 118 110 -8
🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
GEOPY-2893 - h5 compression level seems ignore (from mira-omf)