Skip to content

GEOPY-2893: h5 compression level seems ignore (from mira-omf) - #128

Merged
sebhmg merged 9 commits into
release/GA_4.8from
GEOPY-2893
Jun 4, 2026
Merged

GEOPY-2893: h5 compression level seems ignore (from mira-omf)#128
sebhmg merged 9 commits into
release/GA_4.8from
GEOPY-2893

Conversation

@domfournier

@domfournierdomfournier commented Jun 2, 2026

Copy link
Copy Markdown

GEOPY-2893 - h5 compression level seems ignore (from mira-omf)

CopilotAI review requested due to automatic review settings June 2, 2026 16:57
@github-actionsgithub-actionsBot changed the title GEOPY-2893GEOPY-2893: h5 compression level seems ignore (from mira-omf)Jun 2, 2026

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GeoH5 serialization path to better honor HDF5 compression settings (and introduces a configurable HDF5 page size), while updating conversion tests to use GeoH5Writer directly instead of routing through OMFWriter.

Changes:

  • Switches geoh5 conversion tests from omf.OMFWriter(..., *.geoh5) to omf.GeoH5Writer(...).
  • Updates GeoH5Writer/conversion code to operate on active Workspace handles and passes compression into entity creation.
  • Adjusts the shared random_project test fixture (notably scaling up array sizes).

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
tests/convert_volume_test.pyUpdates volume conversion tests to use GeoH5Writer.
tests/convert_surface_test.pyUpdates surface conversion tests to use GeoH5Writer.
tests/convert_project_test.pyUpdates project conversion tests to use GeoH5Writer and adds compression/page size parameters.
tests/convert_pointset_test.pyUpdates pointset conversion tests to use GeoH5Writer.
tests/convert_grid2d_test.pyUpdates Grid2D conversion tests to use GeoH5Writer.
tests/convert_curve_test.pyUpdates curve conversion tests to use GeoH5Writer.
tests/conftest.pyChanges the random_project fixture data sizes used across multiple tests.
omf/fileio/geoh5.pyRefactors geoh5 writer/conversion plumbing around active workspaces; adds page-size support and compression propagation.
omf/fileio/fileio.pyChanges OMFWriter behavior for output file handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadomf/fileio/geoh5.py Outdated
Comment threadomf/fileio/geoh5.py
Comment threadomf/fileio/fileio.py
Comment threadtests/conftest.py Outdated
Comment threadtests/conftest.py Outdated
Comment threadtests/conftest.py Outdated
Comment threadpoetry.lock Outdated
Comment threadomf/fileio/fileio.py

@sebhmgsebhmg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks code, but need to relock to get proper geoh5py revision

@codecov

codecovBot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.78%. Comparing base (32e1255) to head (1da7678).
⚠️ Report is 5 commits behind head on release/GA_4.8.

Files with missing linesPatch %Lines
omf/fileio/geoh5.py87.75%6 Missing ⚠️
omf/fileio/fileio.py84.61%2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## release/GA_4.8 #128 +/- ##
==================================================
+ Coverage 92.15% 92.78% +0.62% 
==================================================
Files 27 27 Lines 1505 1525 +20 ==================================================
+ Hits 1387 1415 +28 + Misses 118 110 -8 
Files with missing linesCoverage Δ
tests/conftest.py100.00% <100.00%> (ø)
tests/convert_curve_test.py100.00% <100.00%> (ø)
tests/convert_grid2d_test.py100.00% <100.00%> (ø)
tests/convert_pointset_test.py100.00% <100.00%> (ø)
tests/convert_project_test.py100.00% <100.00%> (+29.26%)⬆️
tests/convert_surface_test.py100.00% <100.00%> (ø)
tests/convert_volume_test.py100.00% <100.00%> (ø)
tests/script_geoh5_to_omf_test.py100.00% <100.00%> (ø)
omf/fileio/fileio.py90.78% <84.61%> (-1.22%)⬇️
omf/fileio/geoh5.py91.97% <87.75%> (-0.28%)⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebhmg
sebhmg merged commit ebd135f into release/GA_4.8Jun 4, 2026
30 checks passed
@sebhmg
sebhmg deleted the GEOPY-2893 branch June 4, 2026 02:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@domfournier@sebhmg