Skip to content

GEOPY-3019: Change in color array shape crashes conversion - #130

Merged
domfournier merged 3 commits into
developfrom
GEOPY-3019
Jul 31, 2026
Merged

GEOPY-3019: Change in color array shape crashes conversion#130
domfournier merged 3 commits into
developfrom
GEOPY-3019

Conversation

@domfournier

@domfournierdomfournier commented Jul 29, 2026

Copy link
Copy Markdown

GEOPY-3019 - Change in color array shape crashes conversion

CopilotAI review requested due to automatic review settings July 29, 2026 17:02
@github-actionsgithub-actionsBot changed the title GEOPY-3019GEOPY-3019: Change in color array shape crashes conversionJul 29, 2026

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GeoH5 → OMF colormap/legend conversion to accommodate a changed color_map.values array orientation by transposing the source array before slicing RGB channels.

Changes:

  • Transpose entity_type.color_map.values when building ColorArray legends for referenced/mapped data.
  • Transpose entity_type.color_map.values when rebuilding ScalarColormap (limits + 128-step gradient) from GeoH5 entities.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadomf/fileio/geoh5.py Outdated
Comment threadomf/fileio/geoh5.py Outdated
@codecov

codecovBot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.79%. Comparing base (ea31c5f) to head (8390c9a).

Additional details and impacted files
@@ Coverage Diff @@## develop #130 +/- ##
========================================
Coverage 92.78% 92.79% ========================================
Files 27 27 Lines 1525 1526 +1 ========================================
+ Hits 1415 1416 +1 
Misses 110 110 
Files with missing linesCoverage Δ
omf/fileio/geoh5.py91.98% <100.00%> (+0.01%)⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier
domfournier merged commit 77c68c2 into developJul 31, 2026
20 checks passed
@domfournier
domfournier deleted the GEOPY-3019 branch July 31, 2026 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@domfournier@benk-mira