Uh oh!
There was an error while loading. Please reload this page.
Document dGPredictor KEGG carry-over defect in the NAR 2026 Methods drafts - #286
Open
freiburgermsu wants to merge 2 commits into
Open
Document dGPredictor KEGG carry-over defect in the NAR 2026 Methods drafts#286freiburgermsu wants to merge 2 commits into
freiburgermsu wants to merge 2 commits into
Conversation
Expand the multi-source thermodynamics Methods draft (and its inlined copy in MANUSCRIPT.md) with the audit finding that 17,271 of 27,715 stored dGPredictor records (62%) carry an estimate for a KEGG reaction id absent from the reaction's aliases, caused by a stale-variable bug in the 2023 staging notebook: the alias-extraction loop never reset its holding variable, so KEGG-less reactions inherited the previous reaction's id. A database-wide fingerprint test explains 100.0% of contaminated entries by carry-over (zero exceptions); the contaminated subset shows null correlation with eQuilibrator/GC (r ~ 0.00 vs 0.61/0.74 for correct mappings), and 7,466 contaminated values were promoted into canonical deltag/deltagerr/reversibility. The new subsection documents the defect, forensic confirmation, why reruns re-propagated it (no alias validation in Update_Reaction_dGPredictor_Energies.py), and the correction path, with [TBD] markers on the pieces not yet landed (regenerated staging JSONs, alias-validation guard, re-promotion pass). The retrained dGPredictor-ModelSEED source is noted as structurally immune (keyed directly by rxn id). Results stub now flags that the head-to-head comparison must use post-repair records. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XoJyv1ukSyPfME8WaHewJh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the multi-source thermodynamics Methods draft (
Papers/NAR_Update_2026/drafts/methods_multi_source_thermodynamics.md) and its inlined copy inMANUSCRIPT.mdwith the discovery and correction of a systematic identifier carry-over defect in the original (KEGG-mediated) dGPredictor integration.The finding being documented
dGPredictorrecord, 17,271 (62%) hold an estimate computed for a KEGG reaction id that is not among the reaction's aliases (the reaction records andUnique_ModelSEED_Reaction_Aliases.txtagree on all 17,271 cases).Update_Reaction_dGPredictor_Energies.pynever validates staged KEGG ids against aliases, everyRerun_Thermodynamics.shpass re-propagated the contamination, and the promotion policy's lowest-uncertainty rule favored the deceptively tight copied errors: 7,466 contaminated values were promoted into canonicaldeltag/deltagerr/reversibility.What this PR changes
Documentation only — no data or script changes:
dGPredictor-ModelSEEDsource is noted as structurally immune (keyed directly by ModelSEED rxn id, no KEGG detour) and unaffected.[TBD]markers on the correction pieces not yet landed: regenerated staging JSONs (corrected extraction script lives in the dGPredictor repo), an alias-validation guard in the ingest script, and the re-promotion pass repairing the 7,466 canonical triples. The draft's "Open loose ends" list tracks these, plus a suggested regression test pinning known carry-over cases.[NUMBERS PENDING]stub now flags that the head-to-head ΔrG′ comparison must be computed from post-repair records.🤖 Generated with Claude Code
https://claude.ai/code/session_01XoJyv1ukSyPfME8WaHewJh