Uh oh!
There was an error while loading. Please reload this page.
fix(release): grant id-token write for npm provenance - #3
Merged
Conversation
`npm publish --provenance` mints a signed attestation from a GitHub OIDC token and fails the publish outright without `id-token: write` — it does not fall back to an unsigned publish. The workflow only had `contents: write`, so the first tag would have died at the npm step after goreleaser had already cut the release and pushed to Homebrew and Scoop, leaving a half-published version. Caught before tagging rather than by tagging.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm publish --provenancemints a signed attestation from a GitHub OIDC token. Withoutid-token: writeit fails the publish outright — it does not degrade to an unsigned publish.The workflow had only
contents: write, so the first tag would have died at the npm step after goreleaser had already created the GitHub release and pushed to Homebrew and Scoop — leaving a half-published version and a tag that can't cleanly be re-run.Caught by reading the workflow before tagging rather than by tagging.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.