Skip to content

Make events more consistent and add missing register methods - #256

Merged
calmilamsy merged 1 commit into
ModificationStation:developfrom
DanyGames2014:register-method-improvements
Apr 21, 2026
Merged

Make events more consistent and add missing register methods#256
calmilamsy merged 1 commit into
ModificationStation:developfrom
DanyGames2014:register-method-improvements

Conversation

@DanyGames2014

@DanyGames2014 DanyGames2014 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor
  • Renamed EntityRegister to EntityRegisterEvent
  • Added a KeyBindingRegisterEvent.register method
  • Added a BlockEntityRendererRegisterEvent.register method
  • Added a BlockEntityRegisterEvent.register overload using Identifier
  • Added a EntityRegisterEvent.register overload using Identifier
  • Added a PacketRegisterEvent.register method which accepts PacketType
  • Unified some events to use the Identifier, <register object> order in the register methods in accordance to register methods already using Identifiers.

It might be worth considering removing the String id register methods completely from stuff like entities and block entities

The funciton of the packet type registering tested using a an added test mod packet, everything else is pretty much helper methods
obrazek

@calmilamsy
calmilamsy merged commit 4932416 into ModificationStation:develop Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants