Memory Leak

[Faer12312333]

After the player's inventory breaks, a memory leak occurs, I have a hunch that this is happening in PlayerWindowDispatcher with container_open_callback

Command output | ---- Garbage collection result ----
Command output | Chunks: 242
Command output | Entities: 0
Command output | Cycles: 529
Command output | Memory freed: 6.33 MB

[Muqsit]

I'm probably misunderstanding how to reproduce the issue. I tried this and the # of cycles reported by /gc remains 0.

InvMenu::create(InvMenu::TYPE_CHEST)->send($sender);

I tried this by running a /command (successfully opens menu), and also running ./command (fails because chat window is open).

[kostamax27]

I'm probably misunderstanding how to reproduce the issue. I tried this and the # of cycles reported by /gc remains 0.

InvMenu::create(InvMenu::TYPE_CHEST)->send($sender);

I tried this by running a /command (successfully opens menu), and also running ./command (fails because chat window is open).

Not sure if this is related to InvMenu (here's a test plugin)

Steps to reproduce:

1. Join the server

2. Open your inventory by pressing E a few times

3. Leave the server

4. You'll see console spam like:

   string(17) "networkSession..."

5. Run /gc in the console (The spam stops)

Example /gc output:

Command output | ---- Garbage collection result ----
Command output | Chunks: 471
Command output | Entities: 0
Command output | Cycles: 221
Command output | Memory freed: 14.73 MB

---

Test plugin to reproduce:

<?php

declare(strict_types=1);

/**
 * @name Test
 * @main Test
 * @api 5.28.2
 * @version 1.0.0
 */
namespace{
	use pocketmine\event\Listener;
	use pocketmine\event\player\PlayerJoinEvent;
	use pocketmine\event\server\DataPacketSendEvent;
	use pocketmine\network\mcpe\NetworkSession;
	use pocketmine\network\mcpe\protocol\ContainerOpenPacket;
	use pocketmine\network\mcpe\protocol\types\inventory\WindowTypes;
	use pocketmine\plugin\PluginBase;
	use pocketmine\scheduler\ClosureTask;

	class Test extends PluginBase implements Listener{
		/** @phpstan-var WeakReference<NetworkSession>|null */
		private ?\WeakReference $weakNetworkSession = null;

		protected function onEnable() : void{
			$this->getScheduler()->scheduleRepeatingTask(new ClosureTask(function() : void{
				if($this->weakNetworkSession !== null && ($strongNetworkSession = $this->weakNetworkSession->get()) !== null && !$strongNetworkSession->isConnected()){
					var_dump("networkSession...");
				}
			}), 1);

			$this->getServer()->getPluginManager()->registerEvents($this, $this);
		}

		public function handlePlayerJoin(PlayerJoinEvent $event) : void{
			$player = $event->getPlayer();
			$this->weakNetworkSession = WeakReference::create($player->getNetworkSession());
		}

		public function handleDataPacketSend(DataPacketSendEvent $event) : void{
			foreach($event->getPackets() as $packet){
				if($packet instanceof ContainerOpenPacket){
					var_dump("open inventory: " . $packet->windowType);

					//Creating a strange situation to make sure the player's inventory definitely does not open
					$packet->windowType = WindowTypes::CHEST_BOAT;
					return;
				}
			}
		}
	}
}

Full log:

[10:23:52.896] [Server thread/INFO]: kostamax27 joined the game
string(18) "open inventory: -1"
[10:23:56.102] [Server thread/INFO]: [Memory Manager] [Cyclic Garbage Collector] Run #3 took 11.78 ms (30197 -> 0 roots, 0 cycles collected) - cumulative GC time: 37.92 ms
[10:23:57.344] [Server thread/INFO]: kostamax27 left the game
[10:23:57.346] [Server thread/INFO]: [NetworkSession: kostamax27] Session closed: Client disconnected
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
gstring(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."
cstring(17) "networkSession..."
string(17) "networkSession..."
string(17) "networkSession..."

string(17) "networkSession..."
Command output | ---- Garbage collection result ----
Command output | Chunks: 471
Command output | Entities: 0
Command output | Cycles: 221
Command output | Memory freed: 14.73 MB
pl
Command output | Plugins (1): Test v1.0.0
ver
Command output | This server is running PocketMine-MP
Command output | Server version: 5.31.0 (git hash: 50e15db9ac280f4646f33fc05283190092c53e28)
Command output | Compatible Minecraft version: 1.21.93 (protocol version: 819)
Command output | PHP version: 8.3.21
Command output | PHP JIT: not supported
Command output | Operating system: linux