Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

Update ldk 121, bdk alpha5, bitcoin 0.30 - #1002

Merged
benthecarman merged 2 commits into
masterfrom
ldk-121
Feb 13, 2024
Merged

Update ldk 121, bdk alpha5, bitcoin 0.30#1002
benthecarman merged 2 commits into
masterfrom
ldk-121

Conversation

@benthecarman

@benthecarmanbenthecarman commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator

don't think i have everything fully working yet, got it compiling and i'll finish this later

Most of the diff is from the removal of to_hex(), they claim the to_string() should be usable but this seems ripe for bugs to accidentally occur so I am just using the hex crate for everywhere that isn't a log.

@AnthonyRonning

AnthonyRonning commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

Wasm tests failing

@benthecarman

benthecarman commented Feb 5, 2024•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Finally got all tests passing. While debugging ended up fixing a TODO for not needing the password to get the logs so made that a separate commit

still need to actually test manually, but leaving that for a future date

@benthecarmanbenthecarman modified the milestone: 925Feb 5, 2024
@benthecarmanbenthecarman linked an issue Feb 5, 2024 that may be closed by this pull request
Find other places we can use async RwLock #925
Closed
@benthecarman
benthecarmanforce-pushed the ldk-121 branch 2 times, most recently from d9ea370 to 8bfedb8CompareFebruary 5, 2024 22:42
@benthecarmanbenthecarman mentioned this pull request Feb 6, 2024
Merged
@benthecarman
benthecarmanforce-pushed the ldk-121 branch 2 times, most recently from ff82a33 to ad28850CompareFebruary 10, 2024 16:43
@benthecarmanbenthecarman mentioned this pull request Feb 10, 2024
Merged
@benthecarman
benthecarmanforce-pushed the ldk-121 branch 4 times, most recently from 896e495 to df21fb8CompareFebruary 13, 2024 16:42
@benthecarman
benthecarman marked this pull request as ready for review February 13, 2024 16:42
@benthecarman

benthecarman commented Feb 13, 2024

Copy link
Copy Markdown
CollaboratorAuthor

When through our testing guide and everything seems to work, only thing that I couldn't test was payjoin because it seems the server is down right now.

Also tested that I can safely upgrade a wallet and everything seems to be working properly.

AnthonyRonning
AnthonyRonning suggested changes Feb 13, 2024
View reviewed changes
Comment threadCargo.toml
Comment threadmutiny-core/src/fees.rs
Comment threadmutiny-core/src/lib.rs Outdated
Comment threadmutiny-core/src/onchain.rs
Comment threadmutiny-wasm/src/error.rs
AnthonyRonning
AnthonyRonning approved these changes Feb 13, 2024
View reviewed changes

@AnthonyRonningAnthonyRonning left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested, nice work

@benthecarman
benthecarman merged commit 517ebce into masterFeb 13, 2024
@benthecarman
benthecarman deleted the ldk-121 branch February 13, 2024 17:55
@DanGould

DanGould commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

Rocketship Shaka Shake emoji

image

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@AnthonyRonningAnthonyRonningAnthonyRonning approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BDKLDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Find other places we can use async RwLock

3 participants

@benthecarman@AnthonyRonning@DanGould