Uh oh!
There was an error while loading. Please reload this page.
Added more informative errors when trying to read netcdf3 - #267
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #267 +/- ##
==========================================
- Coverage 78.64% 78.59% -0.05%
==========================================
Files 15 15 Lines 3488 3490 +2 Branches 555 555 ==========================================
Hits 2743 2743 - Misses 602 605 +3 + Partials 143 142 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| if contents["format_signature"] != FORMAT_SIGNATURE: | ||
| raise InvalidHDF5File("Incorrect file signature") |
There was a problem hiding this comment.
What happens if someone tries to open some other file (eg txt file)? Will there still be an informative error?
There was a problem hiding this comment.
The superblock is only looked for after the high-level has confirmed it is an HDF5 file.
There was a problem hiding this comment.
Thanks, I got a bit confused here 😬.
davidhassell
left a comment
There was a problem hiding this comment.
All good. Tested on the command line with various files (text, PP, netCDF3, HDF5)
Uh oh!
There was an error while loading. Please reload this page.
bnlawrence
commented
Sep 3, 2026
Argh. The test wasn't uploaded. I blame that ruff check. I'll push that up shortly. |
Description
The title says it all
Closes#263
Checklist