Uh oh!
There was an error while loading. Please reload this page.
Run Chromatic on PRs, update GitHub Actions + Dependabot - #276
Merged
Conversation
colinrotherhamforce-pushed
the
npm-github-actions
branch
2 times, most recently
from
October 8, 2025 10:31
c7cdac4 to
a2902b6Compare Closed
colinrotherhamforce-pushed
the
npm-github-actions
branch
7 times, most recently
from
October 8, 2025 11:34
7819869 to
4c7bf10Comparecolinrotherhamforce-pushed
the
npm-github-actions
branch
from
October 8, 2025 12:33
4c7bf10 to
50c5426CompareUh oh!
There was an error while loading. Please reload this page.
colinrotherhamforce-pushed
the
npm-github-actions
branch
2 times, most recently
from
October 8, 2025 12:55
09148dd to
bb630d6CompareJoshuaBates-NHS
approved these changes
Oct 8, 2025
colinrotherhamforce-pushed
the
npm-github-actions
branch
3 times, most recently
from
October 8, 2025 13:28
e61fd7d to
4da2b36Comparecolinrotherhamforce-pushed
the
npm-github-actions
branch
2 times, most recently
from
October 8, 2025 13:42
143b952 to
e2ef6a5Comparecolinrotherhamforce-pushed
the
npm-github-actions
branch
from
October 8, 2025 13:50
e2ef6a5 to
dc8252dComparecolinrotherhamforce-pushed
the
npm-github-actions
branch
from
October 8, 2025 15:07
dc8252d to
2578e87Compare
colinrotherham
commented
Oct 8, 2025
CollaboratorAuthor
@JoshuaBates-NHS Just for completeness (and it was noisy) I've suppressed the same I'll go ahead and merge and we can double check the baseline images are saved 🙏 |
colinrotherham
added this pull request to the merge queue
Oct 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
esbuild: { jsx: 'automatic' }for storybook buildNODE_ENV=productionfor package buildThese changes resolve the error thrown by the Chromatic deployment:
Error: D.jsxDEV is not a function. (In 'D.jsxDEV(t,{...e},void 0,!1,{fileName:"/home/runner/work/nhsuk-react-components/nhsuk-react-components/stories/Form Elements/Button.stories.tsx",lineNumber:59,columnNumber:19},void 0)', 'D.jsxDEV' is undefined)I've added Dependabot
groupsto prevent Chromatic CLI warnings coming back:Warning
This build was created using Chromatic CLI version 11.27.0, which is significantly outdated. Please upgrade your chromatic dependency.