Skip to content

Dev - #1

Merged
aromanielloNTIA merged 61 commits into
mainfrom
dev
Dec 18, 2024
Merged

Dev#1
aromanielloNTIA merged 61 commits into
mainfrom
dev

Conversation

@cheroy-ntia

Copy link
Copy Markdown
Contributor

No description provided.

@cheroy-ntia
cheroy-ntia marked this pull request as draft November 29, 2024 21:16
@cheroy-ntia
cheroy-ntia marked this pull request as ready for review December 10, 2024 21:15

@blainNTIAblainNTIA left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aromanielloNTIAaromanielloNTIA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am opening another PR to merge into this branch with a few revisions, primarily editorial. I will submit that for you to review, then we can merge this. Otherwise, looks great!

Comment thread.zenodo.json
@@ -0,0 +1,36 @@
{
"upload_type": "software",
"publication_date": "TODO-TEMPLATE",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am populating this file in a separate PR

Comment threadCITATION.cff Outdated
message: Please cite this software using these metadata.
type: software
authors:
- family-names: Kozma

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revising author information in separate PR alongside zenodo revisions

Comment threadREADME.md Outdated
[doi-badge]: https://zenodo.org/badge/LFMF-python.svg
[doi-link]: https://zenodo.org/badge/latestdoi/LFMF-python

This code repository contains the U.S. Reference Software Implementation of

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making some revisions in a separate PR

@aromanielloNTIAaromanielloNTIA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some things still remain before this is done: adding the test data submodule and incorporating recent template revisions. All of this will be handled within #2

@aromanielloNTIA
aromanielloNTIA merged commit d143aca into mainDec 18, 2024
cheroy-ntia added a commit that referenced this pull request Jul 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cheroy-ntia@blainNTIA@aromanielloNTIA