Skip to content

ENH: include additional binaries in the fmu increasing portability - #137

Draft
HenningScheufler wants to merge 2 commits into
NTNU-IHB:masterfrom
HenningScheufler:feature-includeAdditionalBinaries
Draft

ENH: include additional binaries in the fmu increasing portability#137
HenningScheufler wants to merge 2 commits into
NTNU-IHB:masterfrom
HenningScheufler:feature-includeAdditionalBinaries

Conversation

@HenningScheufler

@HenningScheuflerHenningScheufler commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

This feature enables better portability by including additional binaries in the binaries folder

libpythonfmu-export.so now includes the ORIGIN RUNPATH so it will automatically link to binaries on the FMU.

markaren
markaren reviewed Sep 27, 2021
View reviewed changes
Comment threadpythonfmu/pythonfmu-export/src/CMakeLists.txt
pythonfmu/PySlaveInstance.cpp
)

SET (CMAKE_SHARED_LINKER_FLAGS

@markarenmarkarenSep 27, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be UNIX only?

@markaren

markaren commented Sep 27, 2021•
edited
Loading

Copy link
Copy Markdown
Member

I wonder if it isn't just as easy to manually add the binaries into the archive? With that said, adding this does not exclude the former.

@HenningScheufler
HenningScheufler marked this pull request as draft September 27, 2021 10:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markarenmarkarenmarkaren left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HenningScheufler@markaren