Skip to content

change from at::ones to at::randn in test of OuterReductionMagicScheduler - #2280

Merged
liqiangxl merged 1 commit into
mainfrom
llu/use_randn_in_test
May 22, 2024
Merged

change from at::ones to at::randn in test of OuterReductionMagicScheduler#2280
liqiangxl merged 1 commit into
mainfrom
llu/use_randn_in_test

Conversation

@liqiangxl

@liqiangxlliqiangxl commented May 22, 2024

Copy link
Copy Markdown
Collaborator

should use at::randn instead of at::ones to generate inputs for tests

@liqiangxl

liqiangxl commented May 22, 2024

Copy link
Copy Markdown
CollaboratorAuthor

!build

@liqiangxl
liqiangxl marked this pull request as ready for review May 22, 2024 13:34
@liqiangxl

liqiangxl commented May 22, 2024

Copy link
Copy Markdown
CollaboratorAuthor

!build

@liqiangxl
liqiangxl requested a review from jjsjann123May 22, 2024 17:57
@jjsjann123

jjsjann123 commented May 22, 2024

Copy link
Copy Markdown
Collaborator

seems like there's more transformer_engine package issue here. cc'ing @xwang233

jjsjann123
jjsjann123 approved these changes May 22, 2024
View reviewed changes

@jjsjann123jjsjann123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liqiangxl
liqiangxl merged commit 0892405 into mainMay 22, 2024
@liqiangxl
liqiangxl deleted the llu/use_randn_in_test branch May 22, 2024 19:04
@xwang233

xwang233 commented May 22, 2024

Copy link
Copy Markdown
Collaborator

seems like there's more transformer_engine package issue here. cc'ing @xwang233

image

setuptools was just upgraded yesterday and this caused the pkg_resources import error as you saw in TE scripts. This was just fixed by TE yesterday in NVIDIA/TransformerEngine#860. Our CI image will pick that up tomorrow. Sorry about the inconvenience

@jacobhinklejacobhinkle mentioned this pull request May 22, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjsjann123jjsjann123jjsjann123 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liqiangxl@jjsjann123@xwang233