Skip to content

[Fix](nvbug6304444): make_dataset.py always strips all conversations but the first user turn for UltraChat #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
h-guo18 wants to merge 1 commit into from
Closed

[Fix](nvbug6304444): make_dataset.py always strips all conversations but the first user turn for UltraChat #1751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions examples/dataset/make_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,20 @@ async def _load_ultrachat_conversations(
ds = ds.shuffle(seed=42)
yield len(ds)
for i in range(len(ds)):
prompt = ds[i]["prompt"].strip()
prompt_id = ds[i]["prompt_id"].strip()
if prompt:
msgs = [{"role": "user", "content": prompt}]
# UltraChat records carry the full multi-turn conversation in "messages";
# fall back to the single-turn "prompt" only if it is unavailable.
raw_msgs = ds[i].get("messages") or []
msgs = [
{"role": turn["role"], "content": turn["content"].strip()}
for turn in raw_msgs
if turn.get("content", "").strip()
]
if not msgs:
prompt = ds[i]["prompt"].strip()
if prompt:
msgs = [{"role": "user", "content": prompt}]
if msgs:
if not prompt_id:
prompt_id = id_for_conversation(msgs)
prompt_id = f"ultrachat-{split_name}-{prompt_id}"
Expand Down
Loading