Uh oh!
There was an error while loading. Please reload this page.
ci: gate example and GPU tests on changes to their own runner and cache action - #1891
Merged
Merged
Conversation
…he action The example_tests pr-gate does not list _example_tests_runner.yml (the reusable workflow that runs every example-test job) or the cache-extensions composite action it uses, so a PR changing only those files skips the very jobs it rewires and merges green (e.g. PR NVIDIA#1651: pr-gate passed, torch/trtllm-pr/megatron/onnx all skipped). Same for cache-extensions in gpu_tests.yml, which uses the action in its runner step. Reusable workflows run from the PR ref, so gating on them is the intended self-testing behavior already applied to example_tests.yml itself. Signed-off-by: arham766 <arhamislam766@yahoo.com>
Contributor
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR extends the Changespr-gate File Path Updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kevalmorabia97
approved these changes
Jul 5, 2026
kevalmorabia97
commented
Jul 5, 2026
Collaborator
/ok to test 380417d |
kevalmorabia97
enabled auto-merge (squash)
July 5, 2026 11:00
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1891 +/- ##
==========================================
- Coverage 70.21% 66.11% -4.10%
==========================================
Files 515 515 Lines 57244 57244 ==========================================
- Hits 40196 37849 -2347 - Misses 17048 19395 +2347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kevalmorabia97
disabled auto-merge
July 5, 2026 12:03
Uh oh!
There was an error while loading. Please reload this page.
talorabr pushed a commit
that referenced
this pull request
Jul 7, 2026
…he action (#1891) ### What does this PR do? Type of change: Bug fix Adds `.github/workflows/_example_tests_runner.yml` and `.github/actions/cache-extensions/**` to the example_tests pr-gate `files:` list, and `cache-extensions/**` to the gpu_tests gate. Every example-test job executes through the reusable runner (which is taken from the PR's ref), so a PR changing only the runner previously merged with all example-test jobs skipped — observed on PR #1651, whose example-tests run shows pr-gate success with torch/trtllm-pr/megatron/onnx all skipped. Gating on the workflow's own machinery matches the existing intent (the gate already lists `example_tests.yml` itself). ### Usage N/A — CI workflow configuration change. ### Testing YAML validated; the change is additive to the gate lists only. The observed-failure evidence is PR #1651's run history (linked in #1890). ### Before your PR is "*Ready for review*" - Is this change backward compatible?: ✅ - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: N/A - Did you write any new necessary tests?: N/A (workflow config; validated as described above) - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: N/A (CI-only change) - Did you get Claude approval on this PR?: N/A (external contributor; cannot trigger `/claude review`) ### Additional Information Part of #1890 (item 1). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Expanded automated test-triggering rules to cover additional workflow and action changes. * Updated gating for example and GPU test runs so more relevant changes are validated automatically. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: arham766 <arhamislam766@yahoo.com> Signed-off-by: talora <talora@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Adds
.github/workflows/_example_tests_runner.ymland.github/actions/cache-extensions/**to the example_tests pr-gatefiles:list, andcache-extensions/**to the gpu_tests gate. Every example-test job executes through the reusable runner (which is taken from the PR's ref), so a PR changing only the runner previously merged with all example-test jobs skipped — observed on PR #1651, whose example-tests run shows pr-gate success with torch/trtllm-pr/megatron/onnx all skipped. Gating on the workflow's own machinery matches the existing intent (the gate already listsexample_tests.ymlitself).Usage
N/A — CI workflow configuration change.
Testing
YAML validated; the change is additive to the gate lists only. The observed-failure evidence is PR #1651's run history (linked in #1890).
Before your PR is "Ready for review"
CONTRIBUTING.md: N/A/claude review)Additional Information
Part of #1890 (item 1).
Summary by CodeRabbit