Uh oh!
There was an error while loading. Please reload this page.
ci: scope bump_uv_lock change detection to uv.lock - #1892
Merged
Conversation
The torch-override step rewrites pyproject.toml via toml.load/toml.dump, which drops comments and reformats the file, so 'git diff --quiet' is always dirty and changed=false is unreachable. In a week where 'uv lock --upgrade' changes nothing, the create-pull-request step then stages nothing and 'git commit' exits 1, failing the scheduled run instead of no-oping. Scoping the diff to uv.lock restores the intended behavior. Signed-off-by: arham766 <arhamislam766@yahoo.com>
Contributor
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kevalmorabia97
approved these changes
Jul 5, 2026
kevalmorabia97
commented
Jul 5, 2026
Collaborator
/ok to test 47724d4 |
kevalmorabia97
enabled auto-merge (squash)
July 5, 2026 11:06
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1892 +/- ##
=======================================
Coverage 70.21% 70.21% =======================================
Files 515 515 Lines 57244 57244 =======================================
Hits 40196 40196 Misses 17048 17048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
talorabr pushed a commit
that referenced
this pull request
Jul 7, 2026
### What does this PR do? Type of change: Bug fix The torch-override step rewrites `pyproject.toml` via `toml.load`/`toml.dump`, which drops comments and reformats the file, so the unscoped `git diff --quiet` was always dirty and `changed=false` unreachable. In a week where `uv lock --upgrade` produces no changes, the create-pull-request step stages nothing and `git commit` exits 1, failing the scheduled run instead of no-oping. Scoping the diff to `uv.lock` restores the intended detection. ### Usage N/A — CI workflow configuration change. ### Testing Reproduced the failure locally by executing the workflow's steps in a clean checkout: after the toml mutation, unscoped `git diff --quiet` exits 1 with `uv.lock` byte-identical, and `git add uv.lock && git commit -s -m x` exits 1. With `git diff --quiet -- uv.lock`, the no-update path correctly yields `changed=false`. YAML validated. ### Before your PR is "*Ready for review*" - Is this change backward compatible?: ✅ - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: N/A - Did you write any new necessary tests?: N/A (workflow config; validated as described above) - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: N/A (CI-only change) - Did you get Claude approval on this PR?: N/A (external contributor; cannot trigger `/claude review`) ### Additional Information Part of #1890 (item 2). Signed-off-by: arham766 <arhamislam766@yahoo.com> Signed-off-by: talora <talora@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
The torch-override step rewrites
pyproject.tomlviatoml.load/toml.dump, which drops comments and reformats the file, so the unscopedgit diff --quietwas always dirty andchanged=falseunreachable. In a week whereuv lock --upgradeproduces no changes, the create-pull-request step stages nothing andgit commitexits 1, failing the scheduled run instead of no-oping. Scoping the diff touv.lockrestores the intended detection.Usage
N/A — CI workflow configuration change.
Testing
Reproduced the failure locally by executing the workflow's steps in a clean checkout: after the toml mutation, unscoped
git diff --quietexits 1 withuv.lockbyte-identical, andgit add uv.lock && git commit -s -m xexits 1. Withgit diff --quiet -- uv.lock, the no-update path correctly yieldschanged=false. YAML validated.Before your PR is "Ready for review"
CONTRIBUTING.md: N/A/claude review)Additional Information
Part of #1890 (item 2).