Uh oh!
There was an error while loading. Please reload this page.
ci: give non-PR code quality runs distinct concurrency groups - #1894
Merged
Conversation
Without the github.sha fallback (already used by unit_tests.yml), every nightly and manually dispatched run shares the literal group 'Code Quality-' with cancel-in-progress enabled, so a manual dispatch cancels an in-flight nightly run and vice versa. Signed-off-by: arham766 <arhamislam766@yahoo.com>
Contributor
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe concurrency group key in the code_quality GitHub Actions workflow was modified to combine the workflow name with either the pull request number or the commit SHA, replacing the previous PR-number-only grouping. ChangesWorkflow Concurrency Configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kevalmorabia97
approved these changes
Jul 5, 2026
kevalmorabia97
commented
Jul 5, 2026
Collaborator
/ok to test 49aed56 |
kevalmorabia97
enabled auto-merge (squash)
July 5, 2026 11:06
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1894 +/- ##
=======================================
Coverage 70.21% 70.21% =======================================
Files 515 515 Lines 57244 57244 =======================================
Hits 40196 40196 Misses 17048 17048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
talorabr pushed a commit
that referenced
this pull request
Jul 7, 2026
### What does this PR do? Type of change: Bug fix The concurrency group used `github.event.pull_request.number` with no fallback, so every nightly and manually dispatched run shared the literal group `Code Quality-` with `cancel-in-progress: true` — a manual dispatch cancels an in-flight nightly and vice versa. Adds the `|| github.sha` fallback already used by `unit_tests.yml`. ### Usage N/A — CI workflow configuration change. ### Testing Matches the existing pattern in `unit_tests.yml` line-for-line. YAML validated. ### Before your PR is "*Ready for review*" - Is this change backward compatible?: ✅ - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: N/A - Did you write any new necessary tests?: N/A (workflow config; validated as described above) - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: N/A (CI-only change) - Did you get Claude approval on this PR?: N/A (external contributor; cannot trigger `/claude review`) ### Additional Information Part of #1890 (item 4). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Improved workflow concurrency handling so automated runs are grouped and canceled more reliably across pull request, manual, and scheduled triggers. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: arham766 <arhamislam766@yahoo.com> Signed-off-by: talora <talora@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
The concurrency group used
github.event.pull_request.numberwith no fallback, so every nightly and manually dispatched run shared the literal groupCode Quality-withcancel-in-progress: true— a manual dispatch cancels an in-flight nightly and vice versa. Adds the|| github.shafallback already used byunit_tests.yml.Usage
N/A — CI workflow configuration change.
Testing
Matches the existing pattern in
unit_tests.ymlline-for-line. YAML validated.Before your PR is "Ready for review"
CONTRIBUTING.md: N/A/claude review)Additional Information
Part of #1890 (item 4).
Summary by CodeRabbit