Pin nemo_automodel below 0.6 for the fastgen example - #2260

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel
Aug 27, 2026
Merged

Pin nemo_automodel below 0.6 for the fastgen example#2260
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel

Conversation

@kevalmorabia97

@kevalmorabia97kevalmorabia97 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: Bug fix

nemo_automodel 0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a replacement (it was a three-line rank-zero predicate in 0.5.0, and 0.6.0 defines no equivalent anywhere in the package). examples/diffusers/fastgen/dmd2_recipe.py imports it, so the example's import guard fires and every test in tests/examples/diffusers/ errors at collection:

ImportError: cannot import name 'is_main_process' from 'nemo_automodel.recipes.diffusion.train'
tests/examples/diffusers/fastgen/test_resume_dataloader.py
E ImportError: The DMD2 fastgen example requires `nemo_automodel`. ...
collected 42 items / 1 error

The requirement was >=0.4.0,<1.0, so CI picked 0.6.0 as soon as it was published and the onnx (diffusers) job started failing on every PR (e.g. runs 33020467654, 33019418460, 33010815298, 33007613265, 33006944292 — all unrelated branches). Capping at <0.6 restores the tested range.

Every other nemo_automodel symbol the example imports still exists in 0.6.0 (_diffusers.auto_diffusion_pipeline.NeMoAutoDiffusionPipeline, recipes.diffusion.train.TrainDiffusionRecipe, and the four components.datasets.diffusion.* helpers), so is_main_process is the only blocker; the alternative is defining that predicate locally and widening the cap again, which is worth doing separately if the example is meant to track 0.6.

Usage

pip install -r examples/diffusers/fastgen/requirements.txt

Testing

Reproduced the break by diffing the published wheels: is_main_process is defined at nemo_automodel/recipes/diffusion/train.py:692 in 0.5.0 and absent from 0.6.0 (grep -rn "def is_main_process" over the unpacked 0.6.0 wheel returns nothing). Confirmed the remaining imported symbols are all still present in 0.6.0.

CI on this PR exercises the fix directly: the onnx (diffusers) job installs from this requirements file and is the job that has been failing.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A — existing dependency, tightened bound.
  • Did you write any new necessary tests?: N/A — the existing tests/examples/diffusers/ suite is what this unblocks.
  • Did you update Changelog?: N/A — dependency-pin fix for a break introduced and fixed within the same unreleased cycle.
  • Did you get Claude approval on this PR?: ❌

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dependency compatibility for the FastGen diffusion example.
    • Prevented installation of versions that could cause the example to fail at startup.

0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a
replacement, so dmd2_recipe.py fails to import and every diffusers example test
errors at collection.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code ownerAugust 26, 2026 23:09
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c88c6187-1b4b-44f2-9939-04a9376fe97d

📥 Commits

Reviewing files that changed from the base of the PR and between a0513f1 and b2924a0.

📒 Files selected for processing (1)
  • examples/diffusers/fastgen/requirements.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The FastGen requirements file changes the nemo_automodel[diffusion] upper version bound from <1.0 to <0.6 while retaining the >=0.4.0 lower bound.

Changes

FastGen dependency compatibility

Layer / File(s)Summary
Constrain diffusion dependency version
examples/diffusers/fastgen/requirements.txt
The nemo_automodel[diffusion] requirement now allows versions from 0.4.0 up to, but not including, 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to b2924

This localized dependency pin restores compatibility for the fastgen example, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers:jingyu-ml, chenhanyu, shengliangxu

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: pinning nemo_automodel below version 0.6 for the fastgen example.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Security Anti-Patterns✅ PassedPASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound <1.0 wit…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Security Anti-Patterns

Explanation

PASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound &lt;1.0 with &lt;0.6 and adds explanatory comments. It does not add a PIP dependency, and the changed content contains no prohibited deserialization, remote-code, eval/exec, or # nosec pattern.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/pin-nemo-automodel

Comment @coderabbitai help to get the list of available commands.

@codecov

codecovBot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.92%. Comparing base (a0513f1) to head (b2924a0).

Additional details and impacted files
@@ Coverage Diff @@## main #2260 +/- ##
=======================================
Coverage 78.92% 78.92% =======================================
Files 523 523 Lines 60747 60747 =======================================
Hits 47943 47943 Misses 12804 12804 
FlagCoverage Δ
examples-diffusers20.69% <ø> (-0.02%)⬇️
examples-torch_onnx21.77% <ø> (-0.02%)⬇️
examples-torch_trt15.03% <ø> (-0.01%)⬇️
unit55.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit 449a399 into mainAug 27, 2026
34 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/pin-nemo-automodel branch August 27, 2026 00:29
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-27 00:29 UTC

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kevalmorabia97
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Pin nemo_automodel below 0.6 for the fastgen example - #2260

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel
Aug 27, 2026
Merged

Pin nemo_automodel below 0.6 for the fastgen example#2260
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel

Conversation

@kevalmorabia97

@kevalmorabia97kevalmorabia97 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: Bug fix

nemo_automodel 0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a replacement (it was a three-line rank-zero predicate in 0.5.0, and 0.6.0 defines no equivalent anywhere in the package). examples/diffusers/fastgen/dmd2_recipe.py imports it, so the example's import guard fires and every test in tests/examples/diffusers/ errors at collection:

ImportError: cannot import name 'is_main_process' from 'nemo_automodel.recipes.diffusion.train'
tests/examples/diffusers/fastgen/test_resume_dataloader.py
E ImportError: The DMD2 fastgen example requires `nemo_automodel`. ...
collected 42 items / 1 error

The requirement was >=0.4.0,<1.0, so CI picked 0.6.0 as soon as it was published and the onnx (diffusers) job started failing on every PR (e.g. runs 33020467654, 33019418460, 33010815298, 33007613265, 33006944292 — all unrelated branches). Capping at <0.6 restores the tested range.

Every other nemo_automodel symbol the example imports still exists in 0.6.0 (_diffusers.auto_diffusion_pipeline.NeMoAutoDiffusionPipeline, recipes.diffusion.train.TrainDiffusionRecipe, and the four components.datasets.diffusion.* helpers), so is_main_process is the only blocker; the alternative is defining that predicate locally and widening the cap again, which is worth doing separately if the example is meant to track 0.6.

Usage

pip install -r examples/diffusers/fastgen/requirements.txt

Testing

Reproduced the break by diffing the published wheels: is_main_process is defined at nemo_automodel/recipes/diffusion/train.py:692 in 0.5.0 and absent from 0.6.0 (grep -rn "def is_main_process" over the unpacked 0.6.0 wheel returns nothing). Confirmed the remaining imported symbols are all still present in 0.6.0.

CI on this PR exercises the fix directly: the onnx (diffusers) job installs from this requirements file and is the job that has been failing.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A — existing dependency, tightened bound.
  • Did you write any new necessary tests?: N/A — the existing tests/examples/diffusers/ suite is what this unblocks.
  • Did you update Changelog?: N/A — dependency-pin fix for a break introduced and fixed within the same unreleased cycle.
  • Did you get Claude approval on this PR?: ❌

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dependency compatibility for the FastGen diffusion example.
    • Prevented installation of versions that could cause the example to fail at startup.

0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a
replacement, so dmd2_recipe.py fails to import and every diffusers example test
errors at collection.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code ownerAugust 26, 2026 23:09
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c88c6187-1b4b-44f2-9939-04a9376fe97d

📥 Commits

Reviewing files that changed from the base of the PR and between a0513f1 and b2924a0.

📒 Files selected for processing (1)
  • examples/diffusers/fastgen/requirements.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The FastGen requirements file changes the nemo_automodel[diffusion] upper version bound from <1.0 to <0.6 while retaining the >=0.4.0 lower bound.

Changes

FastGen dependency compatibility

Layer / File(s)Summary
Constrain diffusion dependency version
examples/diffusers/fastgen/requirements.txt
The nemo_automodel[diffusion] requirement now allows versions from 0.4.0 up to, but not including, 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to b2924

This localized dependency pin restores compatibility for the fastgen example, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers:jingyu-ml, chenhanyu, shengliangxu

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: pinning nemo_automodel below version 0.6 for the fastgen example.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Security Anti-Patterns✅ PassedPASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound <1.0 wit…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Security Anti-Patterns

Explanation

PASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound &lt;1.0 with &lt;0.6 and adds explanatory comments. It does not add a PIP dependency, and the changed content contains no prohibited deserialization, remote-code, eval/exec, or # nosec pattern.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/pin-nemo-automodel

Comment @coderabbitai help to get the list of available commands.

@codecov

codecovBot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.92%. Comparing base (a0513f1) to head (b2924a0).

Additional details and impacted files
@@ Coverage Diff @@## main #2260 +/- ##
=======================================
Coverage 78.92% 78.92% =======================================
Files 523 523 Lines 60747 60747 =======================================
Hits 47943 47943 Misses 12804 12804 
FlagCoverage Δ
examples-diffusers20.69% <ø> (-0.02%)⬇️
examples-torch_onnx21.77% <ø> (-0.02%)⬇️
examples-torch_trt15.03% <ø> (-0.01%)⬇️
unit55.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit 449a399 into mainAug 27, 2026
34 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/pin-nemo-automodel branch August 27, 2026 00:29
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-27 00:29 UTC

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kevalmorabia97
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Pin nemo_automodel below 0.6 for the fastgen example - #2260

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel
Aug 27, 2026
Merged

Pin nemo_automodel below 0.6 for the fastgen example#2260
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel

Conversation

@kevalmorabia97

@kevalmorabia97kevalmorabia97 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: Bug fix

nemo_automodel 0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a replacement (it was a three-line rank-zero predicate in 0.5.0, and 0.6.0 defines no equivalent anywhere in the package). examples/diffusers/fastgen/dmd2_recipe.py imports it, so the example's import guard fires and every test in tests/examples/diffusers/ errors at collection:

ImportError: cannot import name 'is_main_process' from 'nemo_automodel.recipes.diffusion.train'
tests/examples/diffusers/fastgen/test_resume_dataloader.py
E ImportError: The DMD2 fastgen example requires `nemo_automodel`. ...
collected 42 items / 1 error

The requirement was >=0.4.0,<1.0, so CI picked 0.6.0 as soon as it was published and the onnx (diffusers) job started failing on every PR (e.g. runs 33020467654, 33019418460, 33010815298, 33007613265, 33006944292 — all unrelated branches). Capping at <0.6 restores the tested range.

Every other nemo_automodel symbol the example imports still exists in 0.6.0 (_diffusers.auto_diffusion_pipeline.NeMoAutoDiffusionPipeline, recipes.diffusion.train.TrainDiffusionRecipe, and the four components.datasets.diffusion.* helpers), so is_main_process is the only blocker; the alternative is defining that predicate locally and widening the cap again, which is worth doing separately if the example is meant to track 0.6.

Usage

pip install -r examples/diffusers/fastgen/requirements.txt

Testing

Reproduced the break by diffing the published wheels: is_main_process is defined at nemo_automodel/recipes/diffusion/train.py:692 in 0.5.0 and absent from 0.6.0 (grep -rn "def is_main_process" over the unpacked 0.6.0 wheel returns nothing). Confirmed the remaining imported symbols are all still present in 0.6.0.

CI on this PR exercises the fix directly: the onnx (diffusers) job installs from this requirements file and is the job that has been failing.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A — existing dependency, tightened bound.
  • Did you write any new necessary tests?: N/A — the existing tests/examples/diffusers/ suite is what this unblocks.
  • Did you update Changelog?: N/A — dependency-pin fix for a break introduced and fixed within the same unreleased cycle.
  • Did you get Claude approval on this PR?: ❌

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dependency compatibility for the FastGen diffusion example.
    • Prevented installation of versions that could cause the example to fail at startup.

0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a
replacement, so dmd2_recipe.py fails to import and every diffusers example test
errors at collection.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code ownerAugust 26, 2026 23:09
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c88c6187-1b4b-44f2-9939-04a9376fe97d

📥 Commits

Reviewing files that changed from the base of the PR and between a0513f1 and b2924a0.

📒 Files selected for processing (1)
  • examples/diffusers/fastgen/requirements.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The FastGen requirements file changes the nemo_automodel[diffusion] upper version bound from <1.0 to <0.6 while retaining the >=0.4.0 lower bound.

Changes

FastGen dependency compatibility

Layer / File(s)Summary
Constrain diffusion dependency version
examples/diffusers/fastgen/requirements.txt
The nemo_automodel[diffusion] requirement now allows versions from 0.4.0 up to, but not including, 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to b2924

This localized dependency pin restores compatibility for the fastgen example, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers:jingyu-ml, chenhanyu, shengliangxu

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: pinning nemo_automodel below version 0.6 for the fastgen example.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Security Anti-Patterns✅ PassedPASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound <1.0 wit…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Security Anti-Patterns

Explanation

PASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound &lt;1.0 with &lt;0.6 and adds explanatory comments. It does not add a PIP dependency, and the changed content contains no prohibited deserialization, remote-code, eval/exec, or # nosec pattern.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/pin-nemo-automodel

Comment @coderabbitai help to get the list of available commands.

@codecov

codecovBot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.92%. Comparing base (a0513f1) to head (b2924a0).

Additional details and impacted files
@@ Coverage Diff @@## main #2260 +/- ##
=======================================
Coverage 78.92% 78.92% =======================================
Files 523 523 Lines 60747 60747 =======================================
Hits 47943 47943 Misses 12804 12804 
FlagCoverage Δ
examples-diffusers20.69% <ø> (-0.02%)⬇️
examples-torch_onnx21.77% <ø> (-0.02%)⬇️
examples-torch_trt15.03% <ø> (-0.01%)⬇️
unit55.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit 449a399 into mainAug 27, 2026
34 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/pin-nemo-automodel branch August 27, 2026 00:29
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-27 00:29 UTC

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kevalmorabia97
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Pin nemo_automodel below 0.6 for the fastgen example - #2260

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel
Aug 27, 2026
Merged

Pin nemo_automodel below 0.6 for the fastgen example#2260
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel

Conversation

@kevalmorabia97

@kevalmorabia97kevalmorabia97 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: Bug fix

nemo_automodel 0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a replacement (it was a three-line rank-zero predicate in 0.5.0, and 0.6.0 defines no equivalent anywhere in the package). examples/diffusers/fastgen/dmd2_recipe.py imports it, so the example's import guard fires and every test in tests/examples/diffusers/ errors at collection:

ImportError: cannot import name 'is_main_process' from 'nemo_automodel.recipes.diffusion.train'
tests/examples/diffusers/fastgen/test_resume_dataloader.py
E ImportError: The DMD2 fastgen example requires `nemo_automodel`. ...
collected 42 items / 1 error

The requirement was >=0.4.0,<1.0, so CI picked 0.6.0 as soon as it was published and the onnx (diffusers) job started failing on every PR (e.g. runs 33020467654, 33019418460, 33010815298, 33007613265, 33006944292 — all unrelated branches). Capping at <0.6 restores the tested range.

Every other nemo_automodel symbol the example imports still exists in 0.6.0 (_diffusers.auto_diffusion_pipeline.NeMoAutoDiffusionPipeline, recipes.diffusion.train.TrainDiffusionRecipe, and the four components.datasets.diffusion.* helpers), so is_main_process is the only blocker; the alternative is defining that predicate locally and widening the cap again, which is worth doing separately if the example is meant to track 0.6.

Usage

pip install -r examples/diffusers/fastgen/requirements.txt

Testing

Reproduced the break by diffing the published wheels: is_main_process is defined at nemo_automodel/recipes/diffusion/train.py:692 in 0.5.0 and absent from 0.6.0 (grep -rn "def is_main_process" over the unpacked 0.6.0 wheel returns nothing). Confirmed the remaining imported symbols are all still present in 0.6.0.

CI on this PR exercises the fix directly: the onnx (diffusers) job installs from this requirements file and is the job that has been failing.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A — existing dependency, tightened bound.
  • Did you write any new necessary tests?: N/A — the existing tests/examples/diffusers/ suite is what this unblocks.
  • Did you update Changelog?: N/A — dependency-pin fix for a break introduced and fixed within the same unreleased cycle.
  • Did you get Claude approval on this PR?: ❌

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dependency compatibility for the FastGen diffusion example.
    • Prevented installation of versions that could cause the example to fail at startup.

0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a
replacement, so dmd2_recipe.py fails to import and every diffusers example test
errors at collection.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code ownerAugust 26, 2026 23:09
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c88c6187-1b4b-44f2-9939-04a9376fe97d

📥 Commits

Reviewing files that changed from the base of the PR and between a0513f1 and b2924a0.

📒 Files selected for processing (1)
  • examples/diffusers/fastgen/requirements.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The FastGen requirements file changes the nemo_automodel[diffusion] upper version bound from <1.0 to <0.6 while retaining the >=0.4.0 lower bound.

Changes

FastGen dependency compatibility

Layer / File(s)Summary
Constrain diffusion dependency version
examples/diffusers/fastgen/requirements.txt
The nemo_automodel[diffusion] requirement now allows versions from 0.4.0 up to, but not including, 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to b2924

This localized dependency pin restores compatibility for the fastgen example, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers:jingyu-ml, chenhanyu, shengliangxu

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: pinning nemo_automodel below version 0.6 for the fastgen example.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Security Anti-Patterns✅ PassedPASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound <1.0 wit…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Security Anti-Patterns

Explanation

PASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound &lt;1.0 with &lt;0.6 and adds explanatory comments. It does not add a PIP dependency, and the changed content contains no prohibited deserialization, remote-code, eval/exec, or # nosec pattern.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/pin-nemo-automodel

Comment @coderabbitai help to get the list of available commands.

@codecov

codecovBot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.92%. Comparing base (a0513f1) to head (b2924a0).

Additional details and impacted files
@@ Coverage Diff @@## main #2260 +/- ##
=======================================
Coverage 78.92% 78.92% =======================================
Files 523 523 Lines 60747 60747 =======================================
Hits 47943 47943 Misses 12804 12804 
FlagCoverage Δ
examples-diffusers20.69% <ø> (-0.02%)⬇️
examples-torch_onnx21.77% <ø> (-0.02%)⬇️
examples-torch_trt15.03% <ø> (-0.01%)⬇️
unit55.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit 449a399 into mainAug 27, 2026
34 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/pin-nemo-automodel branch August 27, 2026 00:29
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-27 00:29 UTC

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kevalmorabia97
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Pin nemo_automodel below 0.6 for the fastgen example - #2260

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel
Aug 27, 2026
Merged

Pin nemo_automodel below 0.6 for the fastgen example#2260
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel

Conversation

@kevalmorabia97

@kevalmorabia97kevalmorabia97 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: Bug fix

nemo_automodel 0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a replacement (it was a three-line rank-zero predicate in 0.5.0, and 0.6.0 defines no equivalent anywhere in the package). examples/diffusers/fastgen/dmd2_recipe.py imports it, so the example's import guard fires and every test in tests/examples/diffusers/ errors at collection:

ImportError: cannot import name 'is_main_process' from 'nemo_automodel.recipes.diffusion.train'
tests/examples/diffusers/fastgen/test_resume_dataloader.py
E ImportError: The DMD2 fastgen example requires `nemo_automodel`. ...
collected 42 items / 1 error

The requirement was >=0.4.0,<1.0, so CI picked 0.6.0 as soon as it was published and the onnx (diffusers) job started failing on every PR (e.g. runs 33020467654, 33019418460, 33010815298, 33007613265, 33006944292 — all unrelated branches). Capping at <0.6 restores the tested range.

Every other nemo_automodel symbol the example imports still exists in 0.6.0 (_diffusers.auto_diffusion_pipeline.NeMoAutoDiffusionPipeline, recipes.diffusion.train.TrainDiffusionRecipe, and the four components.datasets.diffusion.* helpers), so is_main_process is the only blocker; the alternative is defining that predicate locally and widening the cap again, which is worth doing separately if the example is meant to track 0.6.

Usage

pip install -r examples/diffusers/fastgen/requirements.txt

Testing

Reproduced the break by diffing the published wheels: is_main_process is defined at nemo_automodel/recipes/diffusion/train.py:692 in 0.5.0 and absent from 0.6.0 (grep -rn "def is_main_process" over the unpacked 0.6.0 wheel returns nothing). Confirmed the remaining imported symbols are all still present in 0.6.0.

CI on this PR exercises the fix directly: the onnx (diffusers) job installs from this requirements file and is the job that has been failing.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A — existing dependency, tightened bound.
  • Did you write any new necessary tests?: N/A — the existing tests/examples/diffusers/ suite is what this unblocks.
  • Did you update Changelog?: N/A — dependency-pin fix for a break introduced and fixed within the same unreleased cycle.
  • Did you get Claude approval on this PR?: ❌

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dependency compatibility for the FastGen diffusion example.
    • Prevented installation of versions that could cause the example to fail at startup.

0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a
replacement, so dmd2_recipe.py fails to import and every diffusers example test
errors at collection.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code ownerAugust 26, 2026 23:09
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c88c6187-1b4b-44f2-9939-04a9376fe97d

📥 Commits

Reviewing files that changed from the base of the PR and between a0513f1 and b2924a0.

📒 Files selected for processing (1)
  • examples/diffusers/fastgen/requirements.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The FastGen requirements file changes the nemo_automodel[diffusion] upper version bound from <1.0 to <0.6 while retaining the >=0.4.0 lower bound.

Changes

FastGen dependency compatibility

Layer / File(s)Summary
Constrain diffusion dependency version
examples/diffusers/fastgen/requirements.txt
The nemo_automodel[diffusion] requirement now allows versions from 0.4.0 up to, but not including, 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to b2924

This localized dependency pin restores compatibility for the fastgen example, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers:jingyu-ml, chenhanyu, shengliangxu

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: pinning nemo_automodel below version 0.6 for the fastgen example.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Security Anti-Patterns✅ PassedPASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound <1.0 wit…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Security Anti-Patterns

Explanation

PASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound &lt;1.0 with &lt;0.6 and adds explanatory comments. It does not add a PIP dependency, and the changed content contains no prohibited deserialization, remote-code, eval/exec, or # nosec pattern.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/pin-nemo-automodel

Comment @coderabbitai help to get the list of available commands.

@codecov

codecovBot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.92%. Comparing base (a0513f1) to head (b2924a0).

Additional details and impacted files
@@ Coverage Diff @@## main #2260 +/- ##
=======================================
Coverage 78.92% 78.92% =======================================
Files 523 523 Lines 60747 60747 =======================================
Hits 47943 47943 Misses 12804 12804 
FlagCoverage Δ
examples-diffusers20.69% <ø> (-0.02%)⬇️
examples-torch_onnx21.77% <ø> (-0.02%)⬇️
examples-torch_trt15.03% <ø> (-0.01%)⬇️
unit55.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit 449a399 into mainAug 27, 2026
34 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/pin-nemo-automodel branch August 27, 2026 00:29
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-27 00:29 UTC

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kevalmorabia97
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Pin nemo_automodel below 0.6 for the fastgen example - #2260

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel
Aug 27, 2026
Merged

Pin nemo_automodel below 0.6 for the fastgen example#2260
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel

Conversation

@kevalmorabia97

@kevalmorabia97kevalmorabia97 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: Bug fix

nemo_automodel 0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a replacement (it was a three-line rank-zero predicate in 0.5.0, and 0.6.0 defines no equivalent anywhere in the package). examples/diffusers/fastgen/dmd2_recipe.py imports it, so the example's import guard fires and every test in tests/examples/diffusers/ errors at collection:

ImportError: cannot import name 'is_main_process' from 'nemo_automodel.recipes.diffusion.train'
tests/examples/diffusers/fastgen/test_resume_dataloader.py
E ImportError: The DMD2 fastgen example requires `nemo_automodel`. ...
collected 42 items / 1 error

The requirement was >=0.4.0,<1.0, so CI picked 0.6.0 as soon as it was published and the onnx (diffusers) job started failing on every PR (e.g. runs 33020467654, 33019418460, 33010815298, 33007613265, 33006944292 — all unrelated branches). Capping at <0.6 restores the tested range.

Every other nemo_automodel symbol the example imports still exists in 0.6.0 (_diffusers.auto_diffusion_pipeline.NeMoAutoDiffusionPipeline, recipes.diffusion.train.TrainDiffusionRecipe, and the four components.datasets.diffusion.* helpers), so is_main_process is the only blocker; the alternative is defining that predicate locally and widening the cap again, which is worth doing separately if the example is meant to track 0.6.

Usage

pip install -r examples/diffusers/fastgen/requirements.txt

Testing

Reproduced the break by diffing the published wheels: is_main_process is defined at nemo_automodel/recipes/diffusion/train.py:692 in 0.5.0 and absent from 0.6.0 (grep -rn "def is_main_process" over the unpacked 0.6.0 wheel returns nothing). Confirmed the remaining imported symbols are all still present in 0.6.0.

CI on this PR exercises the fix directly: the onnx (diffusers) job installs from this requirements file and is the job that has been failing.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A — existing dependency, tightened bound.
  • Did you write any new necessary tests?: N/A — the existing tests/examples/diffusers/ suite is what this unblocks.
  • Did you update Changelog?: N/A — dependency-pin fix for a break introduced and fixed within the same unreleased cycle.
  • Did you get Claude approval on this PR?: ❌

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dependency compatibility for the FastGen diffusion example.
    • Prevented installation of versions that could cause the example to fail at startup.

0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a
replacement, so dmd2_recipe.py fails to import and every diffusers example test
errors at collection.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code ownerAugust 26, 2026 23:09
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c88c6187-1b4b-44f2-9939-04a9376fe97d

📥 Commits

Reviewing files that changed from the base of the PR and between a0513f1 and b2924a0.

📒 Files selected for processing (1)
  • examples/diffusers/fastgen/requirements.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The FastGen requirements file changes the nemo_automodel[diffusion] upper version bound from <1.0 to <0.6 while retaining the >=0.4.0 lower bound.

Changes

FastGen dependency compatibility

Layer / File(s)Summary
Constrain diffusion dependency version
examples/diffusers/fastgen/requirements.txt
The nemo_automodel[diffusion] requirement now allows versions from 0.4.0 up to, but not including, 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to b2924

This localized dependency pin restores compatibility for the fastgen example, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers:jingyu-ml, chenhanyu, shengliangxu

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: pinning nemo_automodel below version 0.6 for the fastgen example.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Security Anti-Patterns✅ PassedPASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound <1.0 wit…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Security Anti-Patterns

Explanation

PASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound &lt;1.0 with &lt;0.6 and adds explanatory comments. It does not add a PIP dependency, and the changed content contains no prohibited deserialization, remote-code, eval/exec, or # nosec pattern.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/pin-nemo-automodel

Comment @coderabbitai help to get the list of available commands.

@codecov

codecovBot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.92%. Comparing base (a0513f1) to head (b2924a0).

Additional details and impacted files
@@ Coverage Diff @@## main #2260 +/- ##
=======================================
Coverage 78.92% 78.92% =======================================
Files 523 523 Lines 60747 60747 =======================================
Hits 47943 47943 Misses 12804 12804 
FlagCoverage Δ
examples-diffusers20.69% <ø> (-0.02%)⬇️
examples-torch_onnx21.77% <ø> (-0.02%)⬇️
examples-torch_trt15.03% <ø> (-0.01%)⬇️
unit55.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit 449a399 into mainAug 27, 2026
34 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/pin-nemo-automodel branch August 27, 2026 00:29
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-27 00:29 UTC

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kevalmorabia97
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Pin nemo_automodel below 0.6 for the fastgen example - #2260

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel
Aug 27, 2026
Merged

Pin nemo_automodel below 0.6 for the fastgen example#2260
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel

Conversation

@kevalmorabia97

@kevalmorabia97kevalmorabia97 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: Bug fix

nemo_automodel 0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a replacement (it was a three-line rank-zero predicate in 0.5.0, and 0.6.0 defines no equivalent anywhere in the package). examples/diffusers/fastgen/dmd2_recipe.py imports it, so the example's import guard fires and every test in tests/examples/diffusers/ errors at collection:

ImportError: cannot import name 'is_main_process' from 'nemo_automodel.recipes.diffusion.train'
tests/examples/diffusers/fastgen/test_resume_dataloader.py
E ImportError: The DMD2 fastgen example requires `nemo_automodel`. ...
collected 42 items / 1 error

The requirement was >=0.4.0,<1.0, so CI picked 0.6.0 as soon as it was published and the onnx (diffusers) job started failing on every PR (e.g. runs 33020467654, 33019418460, 33010815298, 33007613265, 33006944292 — all unrelated branches). Capping at <0.6 restores the tested range.

Every other nemo_automodel symbol the example imports still exists in 0.6.0 (_diffusers.auto_diffusion_pipeline.NeMoAutoDiffusionPipeline, recipes.diffusion.train.TrainDiffusionRecipe, and the four components.datasets.diffusion.* helpers), so is_main_process is the only blocker; the alternative is defining that predicate locally and widening the cap again, which is worth doing separately if the example is meant to track 0.6.

Usage

pip install -r examples/diffusers/fastgen/requirements.txt

Testing

Reproduced the break by diffing the published wheels: is_main_process is defined at nemo_automodel/recipes/diffusion/train.py:692 in 0.5.0 and absent from 0.6.0 (grep -rn "def is_main_process" over the unpacked 0.6.0 wheel returns nothing). Confirmed the remaining imported symbols are all still present in 0.6.0.

CI on this PR exercises the fix directly: the onnx (diffusers) job installs from this requirements file and is the job that has been failing.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A — existing dependency, tightened bound.
  • Did you write any new necessary tests?: N/A — the existing tests/examples/diffusers/ suite is what this unblocks.
  • Did you update Changelog?: N/A — dependency-pin fix for a break introduced and fixed within the same unreleased cycle.
  • Did you get Claude approval on this PR?: ❌

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dependency compatibility for the FastGen diffusion example.
    • Prevented installation of versions that could cause the example to fail at startup.

0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a
replacement, so dmd2_recipe.py fails to import and every diffusers example test
errors at collection.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code ownerAugust 26, 2026 23:09
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c88c6187-1b4b-44f2-9939-04a9376fe97d

📥 Commits

Reviewing files that changed from the base of the PR and between a0513f1 and b2924a0.

📒 Files selected for processing (1)
  • examples/diffusers/fastgen/requirements.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The FastGen requirements file changes the nemo_automodel[diffusion] upper version bound from <1.0 to <0.6 while retaining the >=0.4.0 lower bound.

Changes

FastGen dependency compatibility

Layer / File(s)Summary
Constrain diffusion dependency version
examples/diffusers/fastgen/requirements.txt
The nemo_automodel[diffusion] requirement now allows versions from 0.4.0 up to, but not including, 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to b2924

This localized dependency pin restores compatibility for the fastgen example, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers:jingyu-ml, chenhanyu, shengliangxu

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: pinning nemo_automodel below version 0.6 for the fastgen example.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Security Anti-Patterns✅ PassedPASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound <1.0 wit…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Security Anti-Patterns

Explanation

PASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound &lt;1.0 with &lt;0.6 and adds explanatory comments. It does not add a PIP dependency, and the changed content contains no prohibited deserialization, remote-code, eval/exec, or # nosec pattern.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/pin-nemo-automodel

Comment @coderabbitai help to get the list of available commands.

@codecov

codecovBot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.92%. Comparing base (a0513f1) to head (b2924a0).

Additional details and impacted files
@@ Coverage Diff @@## main #2260 +/- ##
=======================================
Coverage 78.92% 78.92% =======================================
Files 523 523 Lines 60747 60747 =======================================
Hits 47943 47943 Misses 12804 12804 
FlagCoverage Δ
examples-diffusers20.69% <ø> (-0.02%)⬇️
examples-torch_onnx21.77% <ø> (-0.02%)⬇️
examples-torch_trt15.03% <ø> (-0.01%)⬇️
unit55.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit 449a399 into mainAug 27, 2026
34 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/pin-nemo-automodel branch August 27, 2026 00:29
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-27 00:29 UTC

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kevalmorabia97
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Pin nemo_automodel below 0.6 for the fastgen example - #2260

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel
Aug 27, 2026
Merged

Pin nemo_automodel below 0.6 for the fastgen example#2260
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/pin-nemo-automodel

Conversation

@kevalmorabia97

@kevalmorabia97kevalmorabia97 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: Bug fix

nemo_automodel 0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a replacement (it was a three-line rank-zero predicate in 0.5.0, and 0.6.0 defines no equivalent anywhere in the package). examples/diffusers/fastgen/dmd2_recipe.py imports it, so the example's import guard fires and every test in tests/examples/diffusers/ errors at collection:

ImportError: cannot import name 'is_main_process' from 'nemo_automodel.recipes.diffusion.train'
tests/examples/diffusers/fastgen/test_resume_dataloader.py
E ImportError: The DMD2 fastgen example requires `nemo_automodel`. ...
collected 42 items / 1 error

The requirement was >=0.4.0,<1.0, so CI picked 0.6.0 as soon as it was published and the onnx (diffusers) job started failing on every PR (e.g. runs 33020467654, 33019418460, 33010815298, 33007613265, 33006944292 — all unrelated branches). Capping at <0.6 restores the tested range.

Every other nemo_automodel symbol the example imports still exists in 0.6.0 (_diffusers.auto_diffusion_pipeline.NeMoAutoDiffusionPipeline, recipes.diffusion.train.TrainDiffusionRecipe, and the four components.datasets.diffusion.* helpers), so is_main_process is the only blocker; the alternative is defining that predicate locally and widening the cap again, which is worth doing separately if the example is meant to track 0.6.

Usage

pip install -r examples/diffusers/fastgen/requirements.txt

Testing

Reproduced the break by diffing the published wheels: is_main_process is defined at nemo_automodel/recipes/diffusion/train.py:692 in 0.5.0 and absent from 0.6.0 (grep -rn "def is_main_process" over the unpacked 0.6.0 wheel returns nothing). Confirmed the remaining imported symbols are all still present in 0.6.0.

CI on this PR exercises the fix directly: the onnx (diffusers) job installs from this requirements file and is the job that has been failing.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A — existing dependency, tightened bound.
  • Did you write any new necessary tests?: N/A — the existing tests/examples/diffusers/ suite is what this unblocks.
  • Did you update Changelog?: N/A — dependency-pin fix for a break introduced and fixed within the same unreleased cycle.
  • Did you get Claude approval on this PR?: ❌

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dependency compatibility for the FastGen diffusion example.
    • Prevented installation of versions that could cause the example to fail at startup.

0.6.0 removed nemo_automodel.recipes.diffusion.train.is_main_process without a
replacement, so dmd2_recipe.py fails to import and every diffusers example test
errors at collection.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code ownerAugust 26, 2026 23:09
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c88c6187-1b4b-44f2-9939-04a9376fe97d

📥 Commits

Reviewing files that changed from the base of the PR and between a0513f1 and b2924a0.

📒 Files selected for processing (1)
  • examples/diffusers/fastgen/requirements.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The FastGen requirements file changes the nemo_automodel[diffusion] upper version bound from <1.0 to <0.6 while retaining the >=0.4.0 lower bound.

Changes

FastGen dependency compatibility

Layer / File(s)Summary
Constrain diffusion dependency version
examples/diffusers/fastgen/requirements.txt
The nemo_automodel[diffusion] requirement now allows versions from 0.4.0 up to, but not including, 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to b2924

This localized dependency pin restores compatibility for the fastgen example, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers:jingyu-ml, chenhanyu, shengliangxu

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: pinning nemo_automodel below version 0.6 for the fastgen example.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Security Anti-Patterns✅ PassedPASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound <1.0 wit…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Security Anti-Patterns

Explanation

PASS. The commit changes only examples/diffusers/fastgen/requirements.txt; no modelopt or examples Python files changed. It replaces the existing nemo_automodel[diffusion] upper bound &lt;1.0 with &lt;0.6 and adds explanatory comments. It does not add a PIP dependency, and the changed content contains no prohibited deserialization, remote-code, eval/exec, or # nosec pattern.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/pin-nemo-automodel

Comment @coderabbitai help to get the list of available commands.

@codecov

codecovBot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.92%. Comparing base (a0513f1) to head (b2924a0).

Additional details and impacted files
@@ Coverage Diff @@## main #2260 +/- ##
=======================================
Coverage 78.92% 78.92% =======================================
Files 523 523 Lines 60747 60747 =======================================
Hits 47943 47943 Misses 12804 12804 
FlagCoverage Δ
examples-diffusers20.69% <ø> (-0.02%)⬇️
examples-torch_onnx21.77% <ø> (-0.02%)⬇️
examples-torch_trt15.03% <ø> (-0.01%)⬇️
unit55.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit 449a399 into mainAug 27, 2026
34 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/pin-nemo-automodel branch August 27, 2026 00:29
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-27 00:29 UTC

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kevalmorabia97