Skip to content

hi_itn_electronic - #437

Open
mayuris-00 wants to merge 14 commits into
NVIDIA:staging/hi_itn_v3from
mayuris-00:hi-itn-electronic-clean
Open

hi_itn_electronic#437
mayuris-00 wants to merge 14 commits into
NVIDIA:staging/hi_itn_v3from
mayuris-00:hi-itn-electronic-clean

Conversation

@mayuris-00

@mayuris-00mayuris-00 commented Jun 8, 2026•
edited
Loading

Copy link
Copy Markdown

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

@mayuris-00
feat(hi): add Hindi ITN electronic class
56f129c
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00
chore: remove laptop setup guide and temp diag scripts
5bd93ca
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00
chore: remove scratch helper script
933155b
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00
chore(hi): remove percentage class (out of scope for electronic PR)
12e49f0
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00
chore(hi): remove leftover percentage tagger and verbalizer
d4c9cf6
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00
Merge branch 'staging/hi_itn_v3' into hi-itn-electronic-clean
c470cc9
Signed-off-by: mayuris-00 <mayuris@nvidia.com>
@mayuris-00
style: apply black and isort formatting
01b2fc4
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00
mayuris-00force-pushed the hi-itn-electronic-clean branch from 3e004de to 01b2fc4CompareJune 10, 2026 04:35
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/data/electronic/chemical_formulas.tsv Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/data/electronic/common_words.tsv Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/data/electronic/common_words.tsv Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/data/electronic/digit_glyphs.tsv Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/data/electronic/digit_words.tsv Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/data/electronic/domain.tsv Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/data/electronic/server_name.tsv Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/data/electronic/special_codes.tsv Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
mgrafu
mgrafu reviewed Jun 15, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
@mayuris-00
mayuris-00force-pushed the hi-itn-electronic-clean branch from 812333f to 99a6eefCompareJune 23, 2026 04:30
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/cardinal.py
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
+ pynini.closure(
pynutil.add_weight(
(delete_space + path_atom)
| win_hyphen

@mgrafumgrafuJun 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like a lot of these follow the same pattern. can we create one rule for all symbols instead of individual rules?

mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/serial.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/serial.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/serial.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/serial.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/serial.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/serial.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/serial.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/verbalizers/electronic.py
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/verbalizers/electronic.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/verbalizers/serial.py Outdated
mgrafu
mgrafu reviewed Jun 24, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/verbalizers/verbalize_final.py Outdated
@github-actions

github-actionsBot commented Jul 9, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@mgrafumgrafu removed the Stale label Jul 9, 2026
@mayuris-00
updating fixes
b421bb7
Signed-off-by: Mayuri S <mayuris@nvidia.com>
mgrafu
mgrafu reviewed Jul 14, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
mgrafu
mgrafu reviewed Jul 14, 2026
View reviewed changes
Comment threadtests/nemo_text_processing/hi/data_inverse_text_normalization/test_cases_serial.txt Outdated
mgrafu
mgrafu reviewed Jul 14, 2026
View reviewed changes
Comment threadtests/nemo_text_processing/hi/data_inverse_text_normalization/test_cases_electronic.txt Outdated
mgrafu
mgrafu reviewed Jul 14, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
| (delete_space + sym["minus"])
)

chem_spelled_fst = (

@mgrafumgrafuJul 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this too general? would it potentially cover any random combination of letters or digits?

mgrafu
mgrafu reviewed Jul 14, 2026
View reviewed changes
Comment threadnemo_text_processing/inverse_text_normalization/hi/taggers/electronic.py Outdated
@mayuris-00
hi ITN: updated the changes
c9f1358
Signed-off-by: Mayuri S <mayuris@nvidia.com>
mgrafu
mgrafu reviewed Jul 15, 2026
View reviewed changes
Comment threadtests/nemo_text_processing/hi/test_serial.py Outdated
@pytest.mark.unit
def test_denorm(self, test_input, expected):
pred = self.inverse_normalizer.inverse_normalize(test_input, verbose=False)
assert pred.strip() == expected.strip()

@mgrafumgrafuJul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove .strip() from all tests

@mayuris-00
hi ITN: move telephone changes to a separate PR
06919a8
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00
hi ITN: use exact match in serial and electronic tests
34403e3
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00
hi ITN: removed strip() from the test cases
960d52e
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00mayuris-00 mentioned this pull request Jul 17, 2026
Open
14 tasks
@github-actions

github-actionsBot commented Aug 1, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actionsgithub-actionsBot added Stale and removed Stale labels Aug 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrafumgrafumgrafu left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mayuris-00@mgrafu