Uh oh!
There was an error while loading. Please reload this page.
Added cardinal semiotic class for te ITN - #451
Conversation
folivoramanh
left a comment
There was a problem hiding this comment.
- add sparrowhawk file and run sh test (we need to make sure both pytest and sparrowhawk pass)
- add te to jenkins file
- try to optimize cardinal logic (you can look up other languages eg. Hindi, Spanish, Portuguese, etc... for both TN and ITN) to optimize graph logic, too much looping could lead to slow runtime
- do te ITN support english number (eg. 123456789?) if yes, can you add test cases for both te number and en number?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
33c98ab to
f5bb3deCompareAdd the Telugu (te) cardinal semiotic class for ITN: taggers, verbalizers, data files, graph_utils and utils. Uses the Indian numbering system (hundred/thousand/lakh/crore) with a fixed-width place-value graph and native Telugu digit output; English digits are passed through. The number lexicon is data-driven via TSV files. Adds pytest cases and a Sparrowhawk test, and registers te in the Jenkinsfile and pynini_export. Signed-off-by: jaya-TN <seruganti@nvidia.com>
f5bb3de to
ddc54adCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: jaya-TN <seruganti@nvidia.com>
jaya-TN
commented
Aug 6, 2026
Hi @folivoramanh, I've addressed all the requested changes, updated the PR, and requested a re-review. |
61dfd0f to
514d549CompareSigned-off-by: jaya-TN <seruganti@nvidia.com>
What does this PR do ?
This PR adds support for the Telugu Inverse Text Normalization (ITN) Cardinal semiotic class.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.