Skip to content

Security hardening: remediate aardvark/codex scanner findings #350

Description

@johntmyers

Summary

An automated security scanner (aardvark/codex) opened 13 PRs (#337-#349) against the repository. After principal-engineer review, 11 were validated as legitimate and 2 were rejected (one as security theater, one as destructive). The original PRs were closed due to provenance issues and are being re-implemented cleanly in a single PR.

Validated Findings

PRSeverityTitleStatus
#342CriticalL7 REST parser overread enables request smugglingImplementing
#345CriticalOPA policy matches attacker-controlled cmdline pathsImplementing
#347CriticalSymlink following in read_write chown enables privilege escalationImplementing
#338CriticalNo application-layer auth in dual-auth/edge modeImplementing
#337HighMissing process identity skips privilege droppingImplementing
#339HighForward proxy bypasses L7 method/path enforcementImplementing
#340HighNo validation on sandbox-discovered policy without baselineImplementing
#341HighTLS secret volume readable by sandbox user (0644 default)Implementing
#344HighProvider CRUD RPCs return plaintext credentialsImplementing
#346Lowdrop_privileges no-op when process user unset (defense-in-depth, overlaps #337)Implementing
#348LowServer binds 0.0.0.0 by default (hardening)Implementing

Rejected Findings

PRReason
#343Security theater: x-sandbox-id header is self-asserted with no cryptographic binding. Also breaks all existing callers since the sandbox client never sets the header. Needs redesign with per-sandbox certs or server-issued tokens.
#349Destructive: blocking AF_INET/AF_INET6 in proxy mode would break the proxy itself. Sandboxed processes must create inet sockets to reach the proxy at 10.200.0.1:3128. Network isolation is already enforced by the network namespace + iptables rules.

Agent Diagnostic

All 13 PRs were reviewed using the review-security-issue skill with principal-engineer-reviewer sub-agents. Each finding was traced through the codebase to validate or refute the claimed vulnerability, assess severity, and evaluate the proposed fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions