Skip to content

fix(sandbox): stabilize forked socket owner test - #1417

Merged
mrunalp merged 1 commit into
NVIDIA:mainfrom
derekwaynecarr:fix/procfs-fork-test-flake
May 18, 2026
Merged

fix(sandbox): stabilize forked socket owner test#1417
mrunalp merged 1 commit into
NVIDIA:mainfrom
derekwaynecarr:fix/procfs-fork-test-flake

Conversation

@derekwaynecarr

@derekwaynecarrderekwaynecarr commented May 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Increase the polling deadline from 2s to 5s to tolerate loaded CI machines, and add a ChildGuard drop guard so the forked child is always reaped even if the test panics.

Related Issue

Changes

Testing

  • [x ] mise run pre-commit passes
  • [x ] Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • [x ] Follows Conventional Commits
  • [ x] Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@derekwaynecarr
fix(sandbox): stabilize forked socket owner test
f1fd4b5
Increase the polling deadline from 2s to 5s to tolerate loaded CI
machines, and add a ChildGuard drop guard so the forked child is always
reaped even if the test panics.
Signed-off-by: Derek Carr <decarr@redhat.com>
@copy-pr-bot

copy-pr-botBot commented May 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@derekwaynecarrderekwaynecarr mentioned this pull request May 16, 2026
Merged
@derekwaynecarr

derekwaynecarr commented May 16, 2026

Copy link
Copy Markdown
CollaboratorAuthor

/ok to test f1fd4b5

@mrunalp
mrunalp merged commit b4c7bc4 into NVIDIA:mainMay 18, 2026
27 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drewdrewdrew approved these changes
@mrunalpmrunalpAwaiting requested review from mrunalpmrunalp is a code owner
@maxamillionmaxamillionAwaiting requested review from maxamillionmaxamillion is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derekwaynecarr@drew@mrunalp