Uh oh!
There was an error while loading. Please reload this page.
feat(sandbox): upgrade Landlock to ABI V2 and fix sandbox venv PATH#151
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| """Tests for the writable sandbox venv, PATH, and package installation. | ||
| Verifies that: | ||
| - /sandbox/.venv/bin is in PATH for both interactive and non-interactive sessions | ||
| - pip install works inside the sandbox (pypi policy in dev-sandbox-policy.yaml) | ||
| - uv pip install works (validates Landlock V2 cross-directory rename support) | ||
| - uv run --with works for ephemeral dependency injection | ||
| - Installed packages are importable after installation | ||
| All tests use the default dev sandbox policy -- no custom policy overrides. | ||
| The SDK omits the policy field from the spec so the sandbox container discovers | ||
| its policy from /etc/navigator/policy.yaml (the dev-sandbox-policy.yaml baked | ||
| into the image), which already includes the pypi network policy. | ||
| """ | ||
| from __future__ import annotations | ||
| from typing import TYPE_CHECKING | ||
| if TYPE_CHECKING: | ||
| from collections.abc import Callable | ||
| from navigator import Sandbox | ||
| def test_sandbox_venv_in_path( | ||
| sandbox: Callable[..., Sandbox], | ||
| ) -> None: | ||
| """Non-interactive exec sees /sandbox/.venv/bin in PATH.""" | ||
| with sandbox(delete_on_exit=True) as sb: | ||
| result = sb.exec(["bash", "-c", "echo $PATH"], timeout_seconds=20) | ||
| assert result.exit_code == 0, result.stderr | ||
| path_dirs = result.stdout.strip().split(":") | ||
| assert "/sandbox/.venv/bin" in path_dirs, ( | ||
| f"Expected /sandbox/.venv/bin in PATH, got: {result.stdout.strip()}" | ||
| ) | ||
| # /sandbox/.venv/bin must come before /app/.venv/bin | ||
| sandbox_idx = path_dirs.index("/sandbox/.venv/bin") | ||
| app_idx = path_dirs.index("/app/.venv/bin") | ||
| assert sandbox_idx < app_idx, ( | ||
| "/sandbox/.venv/bin must precede /app/.venv/bin in PATH" | ||
| ) | ||
| def test_pip_install_in_sandbox( | ||
| sandbox: Callable[..., Sandbox], | ||
| ) -> None: | ||
| """pip install works inside the sandbox and installed packages are importable.""" | ||
| with sandbox(delete_on_exit=True) as sb: | ||
| install = sb.exec( | ||
| ["pip", "install", "--quiet", "cowsay"], | ||
| timeout_seconds=60, | ||
| ) | ||
| assert install.exit_code == 0, ( | ||
| f"pip install failed:\nstdout: {install.stdout}\nstderr: {install.stderr}" | ||
| ) | ||
| # Verify the package is importable | ||
| verify = sb.exec( | ||
| ["python", "-c", "import cowsay; print(cowsay.char_names[0])"], | ||
| timeout_seconds=20, | ||
| ) | ||
| assert verify.exit_code == 0, ( | ||
| f"import failed:\nstdout: {verify.stdout}\nstderr: {verify.stderr}" | ||
| ) | ||
| assert verify.stdout.strip(), "Expected non-empty output from cowsay" | ||
| def test_uv_pip_install_in_sandbox( | ||
| sandbox: Callable[..., Sandbox], | ||
| ) -> None: | ||
| """uv pip install works inside the sandbox (validates Landlock V2 REFER support). | ||
| Under Landlock V1 this would fail with EXDEV (cross-device link, os error 18) | ||
| because uv uses cross-directory rename() for cache population and installation. | ||
| Landlock V2 adds the REFER right which permits this. | ||
| """ | ||
| with sandbox(delete_on_exit=True) as sb: | ||
| install = sb.exec( | ||
| [ | ||
| "uv", | ||
| "pip", | ||
| "install", | ||
| "--python", | ||
| "/sandbox/.venv/bin/python", | ||
| "--quiet", | ||
| "cowsay", | ||
| ], | ||
| timeout_seconds=60, | ||
| ) | ||
| assert install.exit_code == 0, ( | ||
| f"uv pip install failed:\nstdout: {install.stdout}\nstderr: {install.stderr}" | ||
| ) | ||
| # Verify the package is importable | ||
| verify = sb.exec( | ||
| ["python", "-c", "import cowsay; print(cowsay.char_names[0])"], | ||
| timeout_seconds=20, | ||
| ) | ||
| assert verify.exit_code == 0, ( | ||
| f"import failed after uv install:\n" | ||
| f"stdout: {verify.stdout}\nstderr: {verify.stderr}" | ||
| ) | ||
| assert verify.stdout.strip(), "Expected non-empty output from cowsay" | ||
| def test_uv_run_with_ephemeral_dependency( | ||
| sandbox: Callable[..., Sandbox], | ||
| ) -> None: | ||
| """uv run --with installs a dependency on-the-fly and runs a script using it.""" | ||
| with sandbox(delete_on_exit=True) as sb: | ||
| result = sb.exec( | ||
| [ | ||
| "uv", | ||
| "run", | ||
| "--python", | ||
| "/sandbox/.venv/bin/python", | ||
| "--with", | ||
| "cowsay", | ||
| "python", | ||
| "-c", | ||
| "import cowsay; print(cowsay.char_names[0])", | ||
| ], | ||
| timeout_seconds=60, | ||
| ) | ||
| assert result.exit_code == 0, ( | ||
| f"uv run --with failed:\nstdout: {result.stdout}\nstderr: {result.stderr}" | ||
| ) | ||
| assert result.stdout.strip(), "Expected non-empty output from uv run" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!!