Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(kubernetes): warm-pooled sandboxes via agent-sandbox extension CRDs#1892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
8d5008822db765c385179672ee5c7e8ce1a35d38eea7ee7bcd390efcd8fc3ab9327a16File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1421,7 +1421,7 @@ impl ComputeDriver for DockerComputeDriver { | ||
| .sandbox | ||
| .ok_or_else(|| Status::invalid_argument("sandbox is required"))?; | ||
| self.create_sandbox_inner(&sandbox).await?; | ||
| Ok(Response::new(CreateSandboxResponse {})) | ||
| Ok(Response::new(CreateSandboxResponse { warm_claim: None })) | ||
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't want to leak this into docker and other drivers. | ||
| } | ||
| async fn stop_sandbox( | ||
| @@ -1546,6 +1546,8 @@ fn pending_sandbox_snapshot( | ||
| sandbox_fd: String::new(), | ||
| conditions: vec![condition], | ||
| deleting, | ||
| // Warm-pool claim fields apply to the Kubernetes driver only. | ||
| ..Default::default() | ||
| }), | ||
| } | ||
| } | ||
| @@ -2732,6 +2734,8 @@ fn driver_status_from_summary( | ||
| last_transition_time: String::new(), | ||
| }], | ||
| deleting, | ||
| // Warm-pool claim fields apply to the Kubernetes driver only. | ||
| ..Default::default() | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a lot of implementation detail from Kubernetes to leak into a core crate.