Uh oh!
There was an error while loading. Please reload this page.
test(server): fix race condition in tracing tests - #2604
Merged
Conversation
krishicks
requested review from
a team, derekwaynecarr, maxamillion and mrunalp
as code ownersAugust 3, 2026 23:18
krishicks
enabled auto-merge
August 3, 2026 23:19
krishicksforce-pushed
the
hicks/push-mnmulylrwmwv
branch
from
August 4, 2026 01:59
e0bd740 to
95788b1CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
krishicksforce-pushed
the
hicks/push-mnmulylrwmwv
branch
3 times, most recently
from
August 4, 2026 14:11
5565fdd to
6d78860CompareKeep the completed instrumented handler future in an explicit pinned box and drop it after the await. This releases the handler-side request span clone before the disconnect test checks producer ownership, avoiding compiler- and platform-dependent retention of an unfinished span. Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicksforce-pushed
the
hicks/push-mnmulylrwmwv
branch
from
August 4, 2026 14:53
6d78860 to
2f1bbabComparematthewgrossman
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Try to fix the flaky tracing tests.
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist