Uh oh!
There was an error while loading. Please reload this page.
fix(supervisor-middleware): configure HTTP/2 keepalive on middleware gRPC channel - #2608
Queued
letv1nnn wants to merge 1 commit into
Queued
fix(supervisor-middleware): configure HTTP/2 keepalive on middleware gRPC channel#2608letv1nnn wants to merge 1 commit into
letv1nnn wants to merge 1 commit into
Conversation
letv1nnn
requested review from
a team, derekwaynecarr, maxamillion and mrunalp
as code ownersAugust 4, 2026 10:36
pimlock
commented
Aug 4, 2026
Collaborator
/ok to test dc3b339 |
pimlock
reviewed
Aug 5, 2026
Uh oh!
There was an error while loading. Please reload this page.
pimlock
commented
Aug 5, 2026
Collaborator
Thanks for picking this up. One small nit and this should be good to go. |
…gRPC channel Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
letv1nnnforce-pushed
the
fix-middleware-grpc-keepalive
branch
from
August 5, 2026 22:59
dc3b339 to
5c87d01Comparepimlock
commented
Aug 5, 2026
Collaborator
/ok to test 5c87d01 |
pimlock
approved these changes
Aug 5, 2026
pimlock
enabled auto-merge
August 5, 2026 23:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The middleware gRPC channel was the only long-lived client in the repo without HTTP/2 keepalive config. Without it, idle connections are silently reaped by intermediaries and dead peers go undetected until the next evaluation attempt.
This is a prerequisite for #2428 (WebSocket middleware), where long-lived bidirectional streams make a stale connection session-fatal rather than a single-retry inconvenience.
Related Issue
#2474
Changes
http2_keep_alive_interval,keep_alive_while_idle,keep_alive_timeout, andhttp2_adaptive_windowto the Endpoint builder incrates/openshell-supervisor-middleware/src/remote.rs. The configuration is the same as in thecrates/openshell-core/src/grpc_client.rsgRPC channel builder.Testing
mise run pre-commitpassesChecklist