Skip to content

fix(supervisor-middleware): configure HTTP/2 keepalive on middleware gRPC channel - #2608

Queued
letv1nnn wants to merge 1 commit into
NVIDIA:mainfrom
letv1nnn:fix-middleware-grpc-keepalive
Queued

fix(supervisor-middleware): configure HTTP/2 keepalive on middleware gRPC channel#2608
letv1nnn wants to merge 1 commit into
NVIDIA:mainfrom
letv1nnn:fix-middleware-grpc-keepalive

Conversation

@letv1nnn

Copy link
Copy Markdown
Contributor

Summary

The middleware gRPC channel was the only long-lived client in the repo without HTTP/2 keepalive config. Without it, idle connections are silently reaped by intermediaries and dead peers go undetected until the next evaluation attempt.

This is a prerequisite for #2428 (WebSocket middleware), where long-lived bidirectional streams make a stale connection session-fatal rather than a single-retry inconvenience.

Related Issue

#2474

Changes

  • Added http2_keep_alive_interval, keep_alive_while_idle, keep_alive_timeout, and http2_adaptive_window to the Endpoint builder in crates/openshell-supervisor-middleware/src/remote.rs. The configuration is the same as in the crates/openshell-core/src/grpc_client.rs gRPC channel builder.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@pimlock

Copy link
Copy Markdown
Collaborator

/ok to test dc3b339

Comment threadcrates/openshell-supervisor-middleware/src/remote.rs Outdated
@pimlock

Copy link
Copy Markdown
Collaborator

Thanks for picking this up. One small nit and this should be good to go.

…gRPC channel
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
@letv1nnn
letv1nnnforce-pushed the fix-middleware-grpc-keepalive branch from dc3b339 to 5c87d01CompareAugust 5, 2026 22:59
@letv1nnn
letv1nnn requested a review from pimlockAugust 5, 2026 23:02
@pimlock

Copy link
Copy Markdown
Collaborator

/ok to test 5c87d01

@pimlock
pimlock enabled auto-merge August 5, 2026 23:03
@pimlock
pimlock added this pull request to the merge queueAug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@letv1nnn@pimlock