Uh oh!
There was an error while loading. Please reload this page.
refactor(compute): support external driver parity - #2744
Conversation
🌿 Preview your docs:https://nvidia-preview-pr-2744.docs.buildwithfern.com/openshell |
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
eb4006a to
0801416Comparedaf85c9 to
680d1c2CompareUh oh!
There was an error while loading. Please reload this page.
680d1c2 to
a06e71fComparea06e71f to
bb6f185CompareLabel |
e174352 to
46b9a23Comparedrew
commented
Aug 19, 2026
/ok to test 46b9a23 |
elezar
left a comment
There was a problem hiding this comment.
Non-blocking review suggestions for clarity and maintainability. These are not approval-blocking concerns.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fb5349b to
b7b0e0cCompareb7b0e0c to
f067e60Compareelezar
commented
Aug 20, 2026
/ok-to-test f067e60 |
f067e60 to
a42a0adComparedrew
commented
Aug 20, 2026
/ok to test |
a42a0ad to
f067e60Compareelezar
commented
Aug 20, 2026
/ok-to-test f067e60 |
elezar
commented
Aug 20, 2026
/ok-to-test f067e60 |
f067e60 to
a42a0adComparea42a0ad to
f067e60Compareelezar
commented
Aug 20, 2026
/ok-to-test f067e60 |
elezar
commented
Aug 20, 2026
@drew A quick summary of the small review changes I folded into this PR before restoring the branch to f067e60:
These were documentation and contract-clarity changes only; they did not add another behavior change to the PR. |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
f067e60 to
48c9287Compare
elezar
left a comment
There was a problem hiding this comment.
Reviewed and addressed issues as called out in the comment.
LGTM, but feel free to get a second opinion.
elezar
commented
Aug 20, 2026
/ok-to-test 48c9287 |
Summary
Make external compute drivers follow the same public gRPC boundary as in-tree drivers. Canonical driver names can be supplied over UDS, driver-requested callback listeners are validated generically, and omitted process identity remains omitted so every runtime can apply its native defaults.
Related Issue
Part of #2417
Stacked on #2743.
Changes
--compute-driver-socket, with the explicit endpoint taking precedencedocs/changes are includedTesting
mise run pre-commitChecklist