Uh oh!
There was an error while loading. Please reload this page.
feat(supervisor): expose sandbox name to middleware request context - #2771
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
9d38ccf to
803dc62CompareUh oh!
There was an error while loading. Please reload this page.
pimlock
left a comment
There was a problem hiding this comment.
Thanks! This looks good now, just one small comment for the documentation update.
803dc62 to
7ce3d62Comparepimlock
commented
Aug 21, 2026
/ok to test 7ce3d62 |
Uh oh!
There was an error while loading. Please reload this page.
pimlock
commented
Aug 21, 2026
@letv1nnn looks like the change doesn't build on main (https://github.com/NVIDIA/OpenShell/actions/runs/32503624769/job/96838754570), due to some recent changes needing to handle the extra params. Please rebase your branch on main, update any new code and this should be good to go. Thanks! |
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
7ce3d62 to
89af438Comparepimlock
commented
Aug 21, 2026
/ok to test 89af438 |
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
89af438 to
244935eCompare@pimlock, rebased onto latest main and fixed the transparent-TCP |
pimlock
commented
Aug 21, 2026
/ok to test 244935e |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Adds the originating sandbox name to the supervisor middleware request context. Operator-run middleware already receives the sandbox ID; passing the name alongside it lets audit and approval interfaces show a human-readable identifier instead of an opaque UUID, using data the supervisor already owns.
Related Issue
Closes#2754
Changes
sandbox_namefield toRequestContextinproto/supervisor_middleware.proto; existing field numbers are unchanged for wire compatibility.sandbox_nametoopenshell_supervisor_middleware::HttpRequestInputand carry it into the gRPCRequestContext.sandbox_idandsandbox_namefrom the process-wideopenshell_ocsf::SandboxContextwhen the network supervisor builds middleware input.SandboxContextintomiddleware_request_inputinstead of reading the global inside it, making the identifier copy unit-testable with a real name.docs/extensibility/supervisor-middleware.mdx.#[cfg(target_os = "linux")]gate on thestd::path::Pathimport inopenshell-driver-podman'scontainer.rs.Pathis used unconditionally in a public function signature, so the gated import broke the non-Linux (macOS) build after mergingmain. Unrelated to the feature but required for the branch to compile cross-platform.Testing
mise run pre-commitpassesChecklist