Skip to content

fix(driver-podman): compile container spec on macOS - #2789

Merged
elezar merged 2 commits into
mainfrom
codex/ci-macos-driver-lint
Aug 18, 2026
Merged

fix(driver-podman): compile container spec on macOS#2789
elezar merged 2 commits into
mainfrom
codex/ci-macos-driver-lint

Conversation

@elezar

@elezarelezar commented Aug 18, 2026

Copy link
Copy Markdown
Member

Summary

Fix the macOS Podman driver compilation failure and extend the existing macOS Clippy guard to cover portable non-VM driver crates. This prevents the same cfg regression from reaching a release build.

Related Issue

No issue required: localized CI coverage maintenance and an obvious compilation fix following a release-build regression.

Regression links:

Changes

  • Import Path unconditionally because it appears in an unconditional Podman container-spec function signature.
  • Add the db-credstore, Docker, Kubernetes, Kubernetes Secrets, Podman, and Vault driver crates to macOS Clippy.
  • Keep the VM driver excluded because its build script embeds runtime assets.

Testing

  • mise run pre-commit passes (not run: mise and cargo are unavailable in this shell)
  • Unit tests added/updated (not run: cargo is unavailable in this shell)
  • Actions workflow YAML parses successfully
  • git diff --check passes
  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezarelezar changed the title ci(drivers): lint portable drivers on macOSfix(driver-podman): compile container spec on macOSAug 18, 2026
@elezar
elezar added this pull request to the merge queueAug 18, 2026
Merged via the queue into main with commit 2115b0cAug 18, 2026
37 checks passed
@elezar
elezar deleted the codex/ci-macos-driver-lint branch August 18, 2026 12:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@elezar@alangou