Uh oh!
There was an error while loading. Please reload this page.
feat(sandbox): add main restart policy - #2798
Open
drew wants to merge 2 commits into
Open
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
🌿 Preview your docs:https://nvidia-preview-pr-2798.docs.buildwithfern.com/openshell |
drewforce-pushed
the
codex/2710-main-restart-policy
branch
from
August 19, 2026 00:28
5040f5c to
bab5935Comparedrew
marked this pull request as ready for review
August 19, 2026 00:30
drew
requested review from
a team, derekwaynecarr, mrunalp and sjenning
as code ownersAugust 19, 2026 00:30
drewforce-pushed
the
codex/2710-main-restart-policy
branch
5 times, most recently
from
August 19, 2026 15:43
1a75200 to
e881c9cComparedrewforce-pushed
the
codex/2710-main-restart-policy
branch
from
August 19, 2026 17:40
e881c9c to
5ce1324Comparedrewforce-pushed
the
codex/2710-main-restart-policy
branch
from
August 20, 2026 01:46
5ce1324 to
4846676Comparedrewforce-pushed
the
codex/2710-main-restart-policy
branch
2 times, most recently
from
August 20, 2026 15:39
2de9ac5 to
d8d2e54Comparedrewforce-pushed
the
codex/2710-main-restart-policy
branch
2 times, most recently
from
August 20, 2026 20:56
31bc2c1 to
59b2879Compare9 tasks
drewforce-pushed
the
codex/2710-main-restart-policy
branch
from
August 20, 2026 21:05
59b2879 to
71936efComparedrewforce-pushed
the
codex/2710-main-restart-policy
branch
from
August 20, 2026 22:01
71936ef to
bb5859aCompareSigned-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
sjenningforce-pushed
the
codex/2710-main-restart-policy
branch
from
August 20, 2026 22:32
bb5859a to
a5f39e2Comparedrew
commented
Aug 21, 2026
CollaboratorAuthor
/ok to test a5f39e2 |
| SANDBOX_PHASE_STOPPING = 6; | ||
| SANDBOX_PHASE_STOPPED = 7; | ||
| SANDBOX_PHASE_STARTING = 8; | ||
| SANDBOX_PHASE_RESTARTING = 9; |
Collaborator
There was a problem hiding this comment.
Do we want the distinction between starting and restarting?
CollaboratorAuthor
There was a problem hiding this comment.
no, i think sticking with starting makes more sense.
sjenning
commented
Aug 25, 2026
Collaborator
review-github-pr skill with 5.6-sol Potential Concerns
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a gateway-owned restart policy for the canonical sandbox main process introduced by #2726. Sandboxes default to
Neverand may opt into Kubernetes-styleOnFailureorAlwaysreplacement with durable exponential backoff.This is the second PR in the stack and must be reviewed after #2726.
Related Issue
Relates to #2710.
Depends on #2726.
Changes
Never,OnFailure, andAlwaysrestart policies plus theRestartingsandbox phase.Testing
mise run pre-commitmise run testwith an isolated system-gateway directoryReadytoRestartingto replacementReadywith workspace preservationThe unmodified host environment contains
/etc/openshell/gateways/default, so the no-config completer test requires an isolatedOPENSHELL_SYSTEM_GATEWAY_DIR; the full suite passes with that isolation.Checklist