Skip to content

fix(cli): reuse sandbox provisioning display - #2816

Merged
sjenning merged 1 commit into
NVIDIA:mainfrom
sjenning:sandbox-create-progress-rendering/sj
Aug 19, 2026
Merged

fix(cli): reuse sandbox provisioning display#2816
sjenning merged 1 commit into
NVIDIA:mainfrom
sjenning:sandbox-create-progress-rendering/sj

Conversation

@sjenning

@sjenningsjenning commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix the interactive provisioning display across platform progress events during openshell sandbox create. This prevents repeated events from recreating the display and duplicating or discarding rendered progress steps.

Regression introduced by #1989

Before:

$ openshell sandbox create
Created sandbox: regular-ribbonfish
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
✓ Sandbox allocated (2s)
1000780000@default--regular-ribbonfish:/sandbox$

After

$ openshell sandbox create
Created sandbox: punctual-saury
1000780000@default--punctual-saury:~$

Related Issue

No issue required: this is an obvious localized CLI rendering bug fix.

Changes

  • Borrow the existing interactive ProvisioningDisplay while handling platform progress events
  • Keep plain progress output behavior unchanged
  • Add a regression test proving repeated events reuse one display without duplicate completed steps

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (not applicable; no sandbox infrastructure or protocol behavior changed)
  • cargo test -p openshell-cli platform_progress_events_update_borrowed_display_without_duplicate_steps

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable; implementation-only rendering fix)

Signed-off-by: Seth Jennings <sjenning@redhat.com>
@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@drewdrew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drew

drew commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 4aa6c27

@sjenning
sjenning added this pull request to the merge queueAug 19, 2026
Merged via the queue into NVIDIA:main with commit c90fd64Aug 19, 2026
38 checks passed
@sjenning
sjenning deleted the sandbox-create-progress-rendering/sj branch August 19, 2026 22:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sjenning@drew