Skip to content

fix(sandbox): stabilize canonical main process tests - #2854

Merged
drew merged 1 commit into
mainfrom
codex/fix-main-process-e2e
Aug 20, 2026
Merged

fix(sandbox): stabilize canonical main process tests#2854
drew merged 1 commit into
mainfrom
codex/fix-main-process-e2e

Conversation

@drew

@drewdrew commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix the main-branch E2E regressions exposed after #2726 merged. Preserve the canonical-main lifecycle semantics while making VM transport lossless and updating test sandboxes that are expected to remain ready.

Related Issue

No issue required: localized regression follow-up to #2726 and the failing main run https://github.com/NVIDIA/OpenShell/actions/runs/32423676399.

Changes

  • Encode the VM main-process specification in a whitespace-free base64url envelope while continuing to decode legacy raw JSON.
  • Add unit coverage for commands containing spaces across the VM guest environment boundary.
  • Keep MCP, OIDC, and Kubernetes workspace test main processes alive instead of using commands that immediately terminate their sandboxes.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)
  • cargo test -p openshell-core sandbox_env::tests -- --nocapture
  • cargo test -p openshell-driver-vm build_guest_environment --lib -- --nocapture
  • Kubernetes managed/operator and OIDC PKCE E2E test binaries compile with their required features
  • bash -n e2e/mcp-conformance.sh
  • mise run test in this worktree: all completed lanes passed, but the Rust lane hit the unrelated environment-sensitive gateway_completer_returns_empty_when_no_config test because a gateway is registered locally; clean CI will rerun it

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable; no contract or intended behavior change)

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew
drew enabled auto-merge August 20, 2026 23:32
@drew
drew disabled auto-merge August 20, 2026 23:33
@drew
drew merged commit 6c34a3c into mainAug 20, 2026
37 of 38 checks passed
@drew
drew deleted the codex/fix-main-process-e2e branch August 20, 2026 23:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@drew@johntmyers