Uh oh!
There was an error while loading. Please reload this page.
docs(agents): clarify user-visible PR review feedback - #2910
Open
krishicks wants to merge 1 commit into
Open
Conversation
Agents will often give a ton of feedback, but it can be hard to quantify the impact of the issue the feedback is about. This change updates the PR review feedback template to be more human-readable, rooting any concerns in user-visible behavior when appropriate, and comparing the new behavior to old behavior so that PR authors can make a determination of whether they want to accept or reject the feedback. Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
requested review from
a team, derekwaynecarr, mrunalp and sjenning
as code ownersAugust 24, 2026 18:18
johntmyers
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agents will often give a ton of feedback, but it can be hard to quantify the impact of the issue the feedback is about.
This change updates the PR review feedback template to be more human-readable, rooting any concerns in user-visible behavior when appropriate, and comparing the new behavior to old behavior so that PR authors can make a determination of whether they want to accept or reject the feedback.
This is an example of this new-style feedback: #2884 (comment)
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist