Uh oh!
There was an error while loading. Please reload this page.
feat(cli): add --from flag to sandbox create for unified image sources - #89
Merged
Conversation
The sandbox create --from flag already handles Dockerfile builds, image references, and community sandbox names. The separate sandbox image push command is redundant and adds unnecessary surface area to the CLI.
Uh oh!
There was an error while loading. Please reload this page.
drew added a commit
that referenced
this pull request
Mar 16, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#88
Summary
--imagewith a unified--fromflag onncl sandbox createthat accepts community sandbox names (openclaw), Dockerfile paths, directories with Dockerfiles, and full container image referencesresolve_from()heuristic that classifies the input and either resolves it to an image reference or builds from a Dockerfile automatically before creating the sandboxghcr.io/nvidia/nemoclaw-community/sandboxes/<name>:latest(overridable viaNEMOCLAW_COMMUNITY_REGISTRYenv var)How it works
The
--fromvalue is classified in order:--from ./DockerfileDockerfile--from ./my-sandbox//,:, or.--from myregistry.com/img:tag--from openclawFor Dockerfile sources, the CLI reuses the existing
build_and_push_imagepipeline to build locally and import into the cluster's containerd — same mechanism asncl sandbox image push.Files changed
crates/navigator-cli/src/run.rs—ResolvedSourceenum,resolve_from(),build_from_dockerfile()helper, updatedsandbox_create/sandbox_create_with_bootstrapsignaturescrates/navigator-cli/src/main.rs—--image→--fromin CLI args and dispatcharchitecture/sandbox-custom-containers.md— Rewritten with--fromdocumentationCONTRIBUTING.md— Updated examplesexamples/bring-your-own-container/README.md— Updated examplese2e/bash/test_sandbox_custom_image.sh— Updated--image→--fromTest plan
cargo clippy— no new warningscargo fmt --check— clean