Skip to content

feat(server): add request-level logging via TraceLayer - #895

Merged
TaylorMutch merged 1 commit into
NVIDIA:mainfrom
sjenning:feat/gateway-request-logging
Apr 21, 2026
Merged

feat(server): add request-level logging via TraceLayer#895
TaylorMutch merged 1 commit into
NVIDIA:mainfrom
sjenning:feat/gateway-request-logging

Conversation

@sjenning

Copy link
Copy Markdown
Collaborator

Summary

  • Add tower_http::trace::TraceLayer to gRPC and HTTP services in the gateway multiplexer to log method, path, HTTP status, and latency for every request
  • Health/readiness probe endpoints (/health, /healthz, /readyz) are logged at debug level to reduce noise
  • No new dependencies — tower-http with the trace feature was already in the workspace

Fixes#892

Related Issue

#892

Changes

  • crates/openshell-server/src/multiplex.rs: Wrap both inner services with TraceLayer in MultiplexService::serve(), add make_request_span and log_response helper functions

Testing

  • cargo check -p openshell-server passes
  • cargo test -p openshell-server — all 8 tests pass (unit + integration)
  • Verified TraceLayer is exercised by existing multiplex and WebSocket tunnel integration tests

Checklist

  • Code compiles without errors
  • Existing tests pass
  • No new dependencies added
  • Follows project conventions (conventional commits, no AI attribution)

Wrap gRPC and HTTP services with TraceLayer to log method, path,
status, and latency for every request. Health/readiness probe
endpoints are logged at debug level to reduce noise.
@sjenning
sjenning requested a review from a team as a code ownerApril 20, 2026 19:01
@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actionsBot commented Apr 20, 2026

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@sjenning

Copy link
Copy Markdown
CollaboratorAuthor

I have read the DCO document and I hereby sign the DCO.

@sjenning

Copy link
Copy Markdown
CollaboratorAuthor

recheck

@TaylorMutchTaylorMutch self-assigned this Apr 20, 2026
@TaylorMutch
TaylorMutch merged commit ba56206 into NVIDIA:mainApr 21, 2026
10 of 11 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in OpenShell RoadmapApr 21, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add request-level HTTP/gRPC tracing to openshell-server

4 participants

@sjenning@pimlock@TaylorMutch@kirit93