Skip to content

feat(server): add object meta convention to top-level objects - #919

Merged
johntmyers merged 1 commit into
NVIDIA:mainfrom
derekwaynecarr:feat/864-object-metadata/derekwaynecarr
Apr 27, 2026
Merged

feat(server): add object meta convention to top-level objects#919
johntmyers merged 1 commit into
NVIDIA:mainfrom
derekwaynecarr:feat/864-object-metadata/derekwaynecarr

Conversation

@derekwaynecarr

@derekwaynecarrderekwaynecarr commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add object meta convention to top-level objects.

  • adds filterable label selectors on resources

Related Issue

Closes#864

Changes

  • add object meta to top level domain objects
  • add ability to filter sandboxes in key/value pairs
  • update tui / cli to render fields

Testing

  • [x ] mise run pre-commit passes
  • [ x] Unit tests added/updated
  • [ x] E2E tests added/updated (if applicable)

Checklist

  • [ x] Follows Conventional Commits
  • [ x] Commits are signed off (DCO)
  • [ x] Architecture docs updated (if applicable)

@derekwaynecarr
derekwaynecarr requested a review from a team as a code ownerApril 22, 2026 18:01
@copy-pr-bot

copy-pr-botBot commented Apr 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actionsBot commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@derekwaynecarr

derekwaynecarr commented Apr 22, 2026

Copy link
Copy Markdown
CollaboratorAuthor

I have read the DCO document and I hereby sign the DCO.

@derekwaynecarr

derekwaynecarr commented Apr 22, 2026

Copy link
Copy Markdown
CollaboratorAuthor

recheck

@derekwaynecarr

derekwaynecarr commented Apr 22, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Just a note for the reviewer, I had intended to add resource_version, but the change grew large and decided to defer that to a later time.

@TaylorMutch

TaylorMutch commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

@derekwaynecarr can you resolve the branch conflicts?

@TaylorMutchTaylorMutch self-assigned this Apr 23, 2026
@derekwaynecarr
derekwaynecarrforce-pushed the feat/864-object-metadata/derekwaynecarr branch from 3cda77c to b5935a0CompareApril 23, 2026 16:54
@derekwaynecarr

derekwaynecarr commented Apr 23, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@TaylorMutch rebased and pushed, thanks!

@derekwaynecarr
derekwaynecarrforce-pushed the feat/864-object-metadata/derekwaynecarr branch 2 times, most recently from ec09a00 to ded972cCompareApril 23, 2026 17:45
@derekwaynecarr

derekwaynecarr commented Apr 23, 2026

Copy link
Copy Markdown
CollaboratorAuthor

/recheck

@derekwaynecarr

derekwaynecarr commented Apr 23, 2026

Copy link
Copy Markdown
CollaboratorAuthor

recheck

@derekwaynecarr
derekwaynecarrforce-pushed the feat/864-object-metadata/derekwaynecarr branch from ded972c to 0e6d0ffCompareApril 23, 2026 20:35
@johntmyers

johntmyers commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Does https://github.com/derekwaynecarr/OpenShell/blob/0e6d0fff319a9c8a1b52cc3fbe9014016b998d51/python/openshell/sandbox.py#L195 need to be updated to response.sandbox.metadata.id or just use _sandbox_ref(response.sandbox)?

@derekwaynecarr
derekwaynecarrforce-pushed the feat/864-object-metadata/derekwaynecarr branch from 0e6d0ff to 9d6c2a1CompareApril 24, 2026 00:35
@derekwaynecarr

derekwaynecarr commented Apr 24, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@johntmyers rebased and fixed up python and corresponding e2e.

@johntmyersjohntmyers added the test:e2e Requires end-to-end coverage label Apr 24, 2026
@johntmyersjohntmyers self-assigned this Apr 24, 2026
@derekwaynecarr
derekwaynecarrforce-pushed the feat/864-object-metadata/derekwaynecarr branch 3 times, most recently from 32931cf to ddf2e40CompareApril 24, 2026 22:18
@johntmyers

johntmyers commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 9d6c2a1

@copy-pr-bot

copy-pr-botBot commented Apr 24, 2026

Copy link
Copy Markdown

/ok to test 9d6c2a1

@johntmyers, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@johntmyers

johntmyers commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 9d6c2a1

@copy-pr-bot

copy-pr-botBot commented Apr 24, 2026

Copy link
Copy Markdown

/ok to test 9d6c2a1

@johntmyers, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@johntmyers

johntmyers commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

/ok to test ddf2e40

@derekwaynecarr
feat(server): add object meta convention to top-level objects
46a37df
- adds filterable label selectors on resources
ClosesNVIDIA#864
Signed-off-by: Derek Carr <decarr@redhat.com>
@derekwaynecarr
derekwaynecarrforce-pushed the feat/864-object-metadata/derekwaynecarr branch from ddf2e40 to 46a37dfCompareApril 24, 2026 22:30
@johntmyers

johntmyers commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 46a37df

@johntmyers
johntmyers merged commit 5e28ea3 into NVIDIA:mainApr 27, 2026
24 of 26 checks passed
@miyoungcmiyoungc mentioned this pull request Apr 27, 2026
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johntmyersjohntmyersjohntmyers approved these changes

Assignees

@johntmyersjohntmyers

@TaylorMutchTaylorMutch

Labels

test:e2eRequires end-to-end coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add Kubernetes-style metadata to all domain objects

3 participants

@derekwaynecarr@TaylorMutch@johntmyers