Skip to content

test(e2e): fix filtered upload path assertion - #963

Merged
pimlock merged 3 commits into
mainfrom
upload-bugfix-followup
Apr 24, 2026
Merged

test(e2e): fix filtered upload path assertion#963
pimlock merged 3 commits into
mainfrom
upload-bugfix-followup

Conversation

@drew

@drewdrew commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix the remaining Rust e2e regression after #960 by restoring the git-filtered upload expectation to the unwrapped destination path. sandbox upload preserves the basename for plain directory uploads, but the git-filtered code path streams the selected subtree contents directly.

Related Issue

Follow-up to #960
Failed workflow: https://github.com/NVIDIA/OpenShell/actions/runs/24897579655/job/72908183051

Changes

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)
  • cargo fmt --all -- --check
  • RUSTC_WRAPPER= CARGO_BUILD_JOBS=1 cargo test --manifest-path e2e/rust/Cargo.toml --features e2e --test sync --no-run
  • Prior local mise run pre-commit attempts in this workspace are still blocked by an unrelated sccacheToo many open files failure during rust:check

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

drew added 2 commits April 24, 2026 08:10
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew
drew requested a review from a team as a code ownerApril 24, 2026 16:30
@drewdrew self-assigned this Apr 24, 2026
@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@drewdrew added the test:e2e Requires end-to-end coverage label Apr 24, 2026
@pimlock

Copy link
Copy Markdown
Collaborator

/ok to test 61ef4b6

@pimlock

Copy link
Copy Markdown
Collaborator

/ok to test a878af4

@pimlock
pimlock merged commit 25c827d into mainApr 24, 2026
23 of 25 checks passed
@pimlock
pimlock deleted the upload-bugfix-followup branch April 24, 2026 18:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2eRequires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@drew@pimlock@johntmyers