Conversation
Current code tries to parse FirmwareDevicePackageData field as utf-8 data. But according to the PLDM for Firmware Update Specification this field has no predefined encoding: """ FirmwareDevicePackageData An optional data field that can be provided within the firmware update package which the UA shall transfer to the FD during the firmware update process. The UA has no knowledge of what data is contained within this field, and will simply pass the contents of this field when the FD requests it via the GetPackageData command response. """ If data in this field is not encoded as utf-8 by chance, decode function can except and abort the script execution. To support generic FirmwareDevicePackageData field, replace utf-8 decoding with hex display. Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current code tries to parse FirmwareDevicePackageData field as utf-8 data. But according to the PLDM for Firmware Update Specification this field has no predefined encoding:
If data in this field is not encoded as utf-8 by chance, decode function can except and abort the script execution.
To support generic FirmwareDevicePackageData field, replace utf-8 decoding with hex display.