Uh oh!
There was an error while loading. Please reload this page.
[PyTorch] Branching operations - #1027
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10
commented
Jul 19, 2024
/te-ci pytorch |
timmoon10
commented
Jul 22, 2024
/te-ci pytorch |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| "are not compatible" | ||
| ) | ||
| # Check output tensor dims |
There was a problem hiding this comment.
I wonder if we need to do this here (same for input) or maybe we could rely on the error checking on the C++ side to minimize CPU overhead?
There was a problem hiding this comment.
I think that would be a good optimization in the future, especially since the linear functional API is used in multiple operations.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Output tensor dtype and device take precedence over weight tensor in linear functional API. Move some index calculation to fuser constructor. Avoid some unnecessary dereferences. Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10
commented
Aug 3, 2024
/te-ci pytorch |
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10
commented
Aug 5, 2024
/te-ci pytorch |
ptrendx
commented
Aug 9, 2024
Could you comment on how the change from your last commit helped with the unittest failures? The change from list comprehension to the for loop should not change the behavior, right? |
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
timmoon10
commented
Aug 9, 2024
/te-ci pytorch |
Description
This PR modifies the operation-based API (#707) to support some simple branching behavior: operations can now accept extra tensor inputs and generate extra tensor outputs. This enables fusions like GEMMs with
beta=1:Support for multiple inputs will also be necessary for cross-attention (and SSMs?). Note that we are not planning to support more complicated structures since that will take us down the road of general graph compilers.
Type of change
Changes
beta=1Checklist: