Skip to content

Fixes for pip wheels - #1042

Merged
ksivaman merged 2 commits into
NVIDIA:mainfrom
ksivaman:wheels_fix
Jul 25, 2024
Merged

Fixes for pip wheels#1042
ksivaman merged 2 commits into
NVIDIA:mainfrom
ksivaman:wheels_fix

Conversation

@ksivaman

@ksivamanksivaman commented Jul 25, 2024

Copy link
Copy Markdown
Member

Description

A follow-up PR to #1036 mainly enabling dynamic loading of a different cudnn lib version at runtime.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Use dynamic loading for cudnn-frontend using CMake flag.
  • Add the symbol for cudnn_dlhandle to debug linker issue.
  • Minor fix in paddle wheel CI test.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ksivaman
Fixes for wheels
e28b82b
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
Fix paddle wheel test
76a8c4a
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
ksivaman requested a review from deneraJuly 25, 2024 15:23
@ksivamanksivaman self-assigned this Jul 25, 2024
denera
denera approved these changes Jul 25, 2024
View reviewed changes

@deneradenera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ksivaman

ksivaman commented Jul 25, 2024

Copy link
Copy Markdown
MemberAuthor

/te-ci

@ksivaman

ksivaman commented Jul 25, 2024

Copy link
Copy Markdown
MemberAuthor

Pipeline 16916144

@ksivaman
ksivaman merged commit 1aaf1cc into NVIDIA:mainJul 25, 2024
ksivaman added a commit that referenced this pull request Jul 25, 2024
@ksivaman
Fixes for pip wheels (#1042)
469dcf3
* Fixes for wheels
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
* Fix paddle wheel test
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
---------
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@hungryGeek16hungryGeek16 mentioned this pull request May 31, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deneradeneradenera approved these changes

Assignees

@ksivamanksivaman

Labels

1.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ksivaman@denera