Skip to content

Update installation instruction for JAX and add some dependencies. - #117

Merged
ksivaman merged 10 commits into
NVIDIA:mainfrom
nouiz:jax_install
Apr 5, 2023
Merged

Update installation instruction for JAX and add some dependencies.#117
ksivaman merged 10 commits into
NVIDIA:mainfrom
nouiz:jax_install

Conversation

@nouiz

@nouiznouiz commented Mar 24, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@nouiznouiz changed the title Update installation instructio for JAX and add some dependencies.Update installation instruction for JAX and add some dependencies.Mar 24, 2023
ptrendx
ptrendx reviewed Mar 27, 2023
View reviewed changes
Comment threadREADME.rst Outdated
ptrendx
ptrendx reviewed Mar 27, 2023
View reviewed changes
Comment threadsetup.py Outdated
ptrendx
ptrendx reviewed Mar 27, 2023
View reviewed changes
Comment threadsetup.py Outdated
@ksivaman

ksivaman commented Mar 27, 2023

Copy link
Copy Markdown
Member

Could you sign-off your commits using the instructions here? @nouiz

@nouiz
nouizforce-pushed the jax_install branch 2 times, most recently from 421bea6 to c3e02edCompareMarch 28, 2023 14:06
@nouiz

nouiz commented Mar 28, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Could you sign-off your commits using the instructions here? @nouiz

Done.

nouiz
nouiz commented Mar 28, 2023
View reviewed changes
Comment threadsetup.py Outdated
timmoon10
timmoon10 reviewed Mar 29, 2023
View reviewed changes
Comment threadsetup.py Outdated
Comment threadsetup.py Outdated
Comment threadsetup.py Outdated
ptrendx
ptrendx reviewed Mar 29, 2023
View reviewed changes
Comment threaddocs/installation.rst Outdated
@nouiz

nouiz commented Mar 29, 2023

Copy link
Copy Markdown
CollaboratorAuthor

@timmoon10@ptrendx I did all the requested changes.
I didn't made the cmake packages a pytorch/tf dependency. I wasn't sure you wanted to change pytorch dependencies.
This can be done in a follow up PR if you want to do that.

@ksivaman

ksivaman commented Mar 30, 2023

Copy link
Copy Markdown
Member

Could you sign-off your commits using the instructions here? @nouiz

Please resolve the conflicts too, thanks!

@nouiz
Update installation instructio for JAX and add some depenencies.
e3268b5
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz

nouiz commented Mar 30, 2023

Copy link
Copy Markdown
CollaboratorAuthor

I rebased, squashed all the commits and signed it.
I did some fixes due to the rebase conflict. So it can be good that you look at the full diff again.

I didn't make cmake a pip dependency for all frameworks, but I think we should do that in a follow up PR while testing it for all FW. This will simplify the installation instruction.

ptrendx
ptrendx reviewed Mar 30, 2023
View reviewed changes
Comment threadREADME.rst
@ptrendx

ptrendx commented Mar 31, 2023

Copy link
Copy Markdown
Member

/te-ci

@nouiz
Bring back support for none pip installed pybind11.
94405bf
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz

nouiz commented Mar 31, 2023

Copy link
Copy Markdown
CollaboratorAuthor

/te-ci

ksivaman
ksivaman reviewed Apr 3, 2023
View reviewed changes
Comment threadsetup.py Outdated
Comment on lines +414 to +416
extras_require={
'test': ['pytest',
'tensorflow_datasets'],},

@ksivamanksivamanApr 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: onnxruntime is needed for the PyTorch tests.

@nouiznouizApr 4, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to handle this.
I think adding it for all FW isn't great.
I'm creating a "test_pytorch" extra.

ksivaman
ksivaman reviewed Apr 3, 2023
View reviewed changes
Comment threadREADME.rst Outdated
ksivaman
ksivaman reviewed Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
pip install pybind11

Clone the repository and inside it type:
Then, you can install this optional dependency:

@ksivamanksivamanApr 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then, you can install this optional dependency:
Then, the following optional dependencies can be installed:

@ksivamanksivamanApr 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the purpose of these dependencies would be useful, since they are 'optional'.

@nouiznouizApr 4, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wanted to do that. But it isn't clear to me what ninja bring.
I was told it could be faster in some cases, but I don't know which case and I didn't test it.

ksivaman
ksivaman reviewed Apr 3, 2023
View reviewed changes
Comment threadREADME.rst Outdated
ksivaman
ksivaman reviewed Apr 3, 2023
View reviewed changes
Comment threadREADME.rst Outdated
ksivaman
ksivaman reviewed Apr 3, 2023
View reviewed changes
Comment threadREADME.rst Outdated
ksivaman
ksivaman reviewed Apr 3, 2023
View reviewed changes
Comment threadsetup.py Outdated
ksivaman
ksivaman reviewed Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Comment on lines +211 to +215
# Trigger a better error when pybind11 isn't present.
# Sadly, if pybind11 was installed with `apt -y install pybind11-dev`
# This doesn't install a python packages. So the line bellow is too strict.
# When it fail, we need to detect if cmake will find pybind11.
# import pybind11

@ksivamanksivamanApr 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear, what is the goal of this comment?

@ksivamanksivamanApr 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to answer the question, "Why we're getting pybind11 via cmake?"

@nouiznouizApr 4, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pybind11 isn't installed, the error message is ugly and hard to read.
So I wanted to generate a better error by doing "import pybind11".
This work when we install pybind11 via pip, but it doesn't work when installed via apt-get.

@nouiz@ksivaman
Apply suggestions from code review
f610636
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
Changes following review.
d9ae968
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
timmoon10
timmoon10 reviewed Apr 4, 2023
View reviewed changes
Comment threaddocs/installation.rst Outdated
nouiz added 3 commits April 4, 2023 10:58
@nouiz
Change order to make it more clear.
0773865
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
Add other reviers suggestion.
3bd0c07
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
pybind11 is needed for all FW.
f59b91e
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
nouizand others added 2 commits April 4, 2023 13:34
@nouiz
Add flax as a dep
910cfd0
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@ksivaman
Merge branch 'main' into jax_install
cbbe556
timmoon10
timmoon10 approved these changes Apr 4, 2023
View reviewed changes

@timmoon10timmoon10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman

ksivaman commented Apr 4, 2023

Copy link
Copy Markdown
Member

/te-ci

@nouiz@ksivaman
Update README.rst
87b0b5e
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz

nouiz commented Apr 5, 2023

Copy link
Copy Markdown
CollaboratorAuthor

@ptrendx I accepted the suggested modification. But I don't see it anymore, so I can't comment on it.

@ksivaman
ksivaman merged commit 3069ebc into NVIDIA:mainApr 5, 2023
ptrendx pushed a commit that referenced this pull request Apr 5, 2023
@nouiz@ksivaman@ptrendx
Update installation instruction for JAX and add some dependencies. (#117
770e968
)
* Update installation instructio for JAX and add some depenencies.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Bring back support for none pip installed pybind11.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Apply suggestions from code review
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
* Changes following review.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Change order to make it more clear.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add other reviers suggestion.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* pybind11 is needed for all FW.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add flax as a dep
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Update README.rst
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
---------
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@hungryGeek16hungryGeek16 mentioned this pull request May 31, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptrendxptrendxptrendx left review comments
@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees

No one assigned

Labels

v0.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nouiz@ksivaman@ptrendx@timmoon10
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update installation instruction for JAX and add some dependencies. by nouiz · Pull Request #117 · NVIDIA/TransformerEngine · GitHub
Skip to content
Update installation instruction for JAX and add some dependencies. - #117
Merged
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Apr 5, 2023
Merged
Update installation instruction for JAX and add some dependencies.#117
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Conversation
@nouiz
@nouiznouiz
commented
Mar 24, 2023

Copy link


Copy Markdown

Collaborator
 No description provided. 
@nouiznouiz
changed the title
Update installation instructio for JAX and add some dependencies.Update installation instruction for JAX and add some dependencies.Mar 24, 2023
ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

@ksivaman
ksivaman
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
@nouiz
nouizforce-pushed
the
jax_install
branch
2 times, most recently
from
421bea6 to
c3e02edCompareMarch 28, 2023 14:06
@nouiz
nouiz
commented
Mar 28, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Could you sign-off your commits using the instructions here? @nouiz
Done.
nouiz
nouiz
commented
Mar 28, 2023
View reviewed changes
Comment threadsetup.py
Outdated

timmoon10
timmoon10
reviewed
Mar 29, 2023
View reviewed changes
Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 29, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

@nouiz
nouiz
commented
Mar 29, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@timmoon10@ptrendx I did all the requested changes.

I didn't made the cmake packages a pytorch/tf dependency. I wasn't sure you wanted to change pytorch dependencies.

This can be done in a follow up PR if you want to do that.
@ksivaman
ksivaman
commented
Mar 30, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
Please resolve the conflicts too, thanks!
@nouiz
Update installation instructio for JAX and add some depenencies.
e3268b5
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 30, 2023

Copy link


Copy Markdown

CollaboratorAuthor
I rebased, squashed all the commits and signed it.

I did some fixes due to the rebase conflict. So it can be good that you look at the full diff again.
I didn't make cmake a pip dependency for all frameworks, but I think we should do that in a follow up PR while testing it for all FW. This will simplify the installation instruction.
ptrendx
ptrendx
reviewed
Mar 30, 2023
View reviewed changes
Comment threadREADME.rst
@ptrendx
ptrendx
commented
Mar 31, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz
Bring back support for none pip installed pybind11.
94405bf
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 31, 2023

Copy link


Copy Markdown

CollaboratorAuthor
/te-ci
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated


Comment on lines

+414
 to 
+416

 extras_require={
 'test': ['pytest',
 'tensorflow_datasets'],},
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: onnxruntime is needed for the PyTorch tests.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to handle this.

I think adding it for all FW isn't great.

I'm creating a "test_pytorch" extra.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
pip install pybind11

Clone the repository and inside it type:
Then, you can install this optional dependency:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

Then, you can install this optional dependency:
Then, the following optional dependencies can be installed:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the purpose of these dependencies would be useful, since they are 'optional'.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wanted to do that. But it isn't clear to me what ninja bring.

I was told it could be faster in some cases, but I don't know which case and I didn't test it.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py

Comment on lines

+211
 to 
+215

 # Trigger a better error when pybind11 isn't present.
 # Sadly, if pybind11 was installed with `apt -y install pybind11-dev`
 # This doesn't install a python packages. So the line bellow is too strict.
 # When it fail, we need to detect if cmake will find pybind11.
 # import pybind11
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear, what is the goal of this comment?
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to answer the question, "Why we're getting pybind11 via cmake?"
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pybind11 isn't installed, the error message is ugly and hard to read.

So I wanted to generate a better error by doing "import pybind11".

This work when we install pybind11 via pip, but it doesn't work when installed via apt-get.
@nouiz@ksivaman
Apply suggestions from code review
f610636
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
Changes following review.
d9ae968
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
timmoon10
timmoon10
reviewed
Apr 4, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

nouiz
added 3 commits
April 4, 2023 10:58
@nouiz
Change order to make it more clear.
0773865
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
Add other reviers suggestion.
3bd0c07
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
pybind11 is needed for all FW.
f59b91e
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
nouizand others
added 2 commits
April 4, 2023 13:34
@nouiz
Add flax as a dep
910cfd0
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@ksivaman
Merge branch 'main' into jax_install
cbbe556
timmoon10
timmoon10
approved these changes
Apr 4, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
commented
Apr 4, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz@ksivaman
Update README.rst
87b0b5e
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
nouiz
commented
Apr 5, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@ptrendx I accepted the suggested modification. But I don't see it anymore, so I can't comment on it.
@ksivaman
ksivaman
merged commit 3069ebc
into
NVIDIA:mainApr 5, 2023
ptrendx pushed a commit
that referenced
this pull request
Apr 5, 2023
@nouiz@ksivaman@ptrendx
Update installation instruction for JAX and add some dependencies. (#117
770e968
)
* Update installation instructio for JAX and add some depenencies.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Bring back support for none pip installed pybind11.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Apply suggestions from code review
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
* Changes following review.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Change order to make it more clear.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add other reviers suggestion.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* pybind11 is needed for all FW.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add flax as a dep
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Update README.rst
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
---------
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@hungryGeek16hungryGeek16
mentioned this pull request
May 31, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ptrendxptrendxptrendx left review comments
@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels

v0.7.0

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@nouiz@ksivaman@ptrendx@timmoon10

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update installation instruction for JAX and add some dependencies. by nouiz · Pull Request #117 · NVIDIA/TransformerEngine · GitHub
Skip to content
Update installation instruction for JAX and add some dependencies. - #117
Merged
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Apr 5, 2023
Merged
Update installation instruction for JAX and add some dependencies.#117
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Conversation
@nouiz
@nouiznouiz
commented
Mar 24, 2023

Copy link


Copy Markdown

Collaborator
 No description provided. 
@nouiznouiz
changed the title
Update installation instructio for JAX and add some dependencies.Update installation instruction for JAX and add some dependencies.Mar 24, 2023
ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

@ksivaman
ksivaman
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
@nouiz
nouizforce-pushed
the
jax_install
branch
2 times, most recently
from
421bea6 to
c3e02edCompareMarch 28, 2023 14:06
@nouiz
nouiz
commented
Mar 28, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Could you sign-off your commits using the instructions here? @nouiz
Done.
nouiz
nouiz
commented
Mar 28, 2023
View reviewed changes
Comment threadsetup.py
Outdated

timmoon10
timmoon10
reviewed
Mar 29, 2023
View reviewed changes
Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 29, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

@nouiz
nouiz
commented
Mar 29, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@timmoon10@ptrendx I did all the requested changes.

I didn't made the cmake packages a pytorch/tf dependency. I wasn't sure you wanted to change pytorch dependencies.

This can be done in a follow up PR if you want to do that.
@ksivaman
ksivaman
commented
Mar 30, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
Please resolve the conflicts too, thanks!
@nouiz
Update installation instructio for JAX and add some depenencies.
e3268b5
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 30, 2023

Copy link


Copy Markdown

CollaboratorAuthor
I rebased, squashed all the commits and signed it.

I did some fixes due to the rebase conflict. So it can be good that you look at the full diff again.
I didn't make cmake a pip dependency for all frameworks, but I think we should do that in a follow up PR while testing it for all FW. This will simplify the installation instruction.
ptrendx
ptrendx
reviewed
Mar 30, 2023
View reviewed changes
Comment threadREADME.rst
@ptrendx
ptrendx
commented
Mar 31, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz
Bring back support for none pip installed pybind11.
94405bf
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 31, 2023

Copy link


Copy Markdown

CollaboratorAuthor
/te-ci
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated


Comment on lines

+414
 to 
+416

 extras_require={
 'test': ['pytest',
 'tensorflow_datasets'],},
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: onnxruntime is needed for the PyTorch tests.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to handle this.

I think adding it for all FW isn't great.

I'm creating a "test_pytorch" extra.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
pip install pybind11

Clone the repository and inside it type:
Then, you can install this optional dependency:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

Then, you can install this optional dependency:
Then, the following optional dependencies can be installed:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the purpose of these dependencies would be useful, since they are 'optional'.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wanted to do that. But it isn't clear to me what ninja bring.

I was told it could be faster in some cases, but I don't know which case and I didn't test it.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py

Comment on lines

+211
 to 
+215

 # Trigger a better error when pybind11 isn't present.
 # Sadly, if pybind11 was installed with `apt -y install pybind11-dev`
 # This doesn't install a python packages. So the line bellow is too strict.
 # When it fail, we need to detect if cmake will find pybind11.
 # import pybind11
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear, what is the goal of this comment?
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to answer the question, "Why we're getting pybind11 via cmake?"
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pybind11 isn't installed, the error message is ugly and hard to read.

So I wanted to generate a better error by doing "import pybind11".

This work when we install pybind11 via pip, but it doesn't work when installed via apt-get.
@nouiz@ksivaman
Apply suggestions from code review
f610636
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
Changes following review.
d9ae968
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
timmoon10
timmoon10
reviewed
Apr 4, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

nouiz
added 3 commits
April 4, 2023 10:58
@nouiz
Change order to make it more clear.
0773865
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
Add other reviers suggestion.
3bd0c07
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
pybind11 is needed for all FW.
f59b91e
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
nouizand others
added 2 commits
April 4, 2023 13:34
@nouiz
Add flax as a dep
910cfd0
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@ksivaman
Merge branch 'main' into jax_install
cbbe556
timmoon10
timmoon10
approved these changes
Apr 4, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
commented
Apr 4, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz@ksivaman
Update README.rst
87b0b5e
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
nouiz
commented
Apr 5, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@ptrendx I accepted the suggested modification. But I don't see it anymore, so I can't comment on it.
@ksivaman
ksivaman
merged commit 3069ebc
into
NVIDIA:mainApr 5, 2023
ptrendx pushed a commit
that referenced
this pull request
Apr 5, 2023
@nouiz@ksivaman@ptrendx
Update installation instruction for JAX and add some dependencies. (#117
770e968
)
* Update installation instructio for JAX and add some depenencies.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Bring back support for none pip installed pybind11.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Apply suggestions from code review
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
* Changes following review.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Change order to make it more clear.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add other reviers suggestion.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* pybind11 is needed for all FW.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add flax as a dep
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Update README.rst
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
---------
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@hungryGeek16hungryGeek16
mentioned this pull request
May 31, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ptrendxptrendxptrendx left review comments
@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels

v0.7.0

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@nouiz@ksivaman@ptrendx@timmoon10

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update installation instruction for JAX and add some dependencies. by nouiz · Pull Request #117 · NVIDIA/TransformerEngine · GitHub
Skip to content
Update installation instruction for JAX and add some dependencies. - #117
Merged
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Apr 5, 2023
Merged
Update installation instruction for JAX and add some dependencies.#117
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Conversation
@nouiz
@nouiznouiz
commented
Mar 24, 2023

Copy link


Copy Markdown

Collaborator
 No description provided. 
@nouiznouiz
changed the title
Update installation instructio for JAX and add some dependencies.Update installation instruction for JAX and add some dependencies.Mar 24, 2023
ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

@ksivaman
ksivaman
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
@nouiz
nouizforce-pushed
the
jax_install
branch
2 times, most recently
from
421bea6 to
c3e02edCompareMarch 28, 2023 14:06
@nouiz
nouiz
commented
Mar 28, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Could you sign-off your commits using the instructions here? @nouiz
Done.
nouiz
nouiz
commented
Mar 28, 2023
View reviewed changes
Comment threadsetup.py
Outdated

timmoon10
timmoon10
reviewed
Mar 29, 2023
View reviewed changes
Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 29, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

@nouiz
nouiz
commented
Mar 29, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@timmoon10@ptrendx I did all the requested changes.

I didn't made the cmake packages a pytorch/tf dependency. I wasn't sure you wanted to change pytorch dependencies.

This can be done in a follow up PR if you want to do that.
@ksivaman
ksivaman
commented
Mar 30, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
Please resolve the conflicts too, thanks!
@nouiz
Update installation instructio for JAX and add some depenencies.
e3268b5
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 30, 2023

Copy link


Copy Markdown

CollaboratorAuthor
I rebased, squashed all the commits and signed it.

I did some fixes due to the rebase conflict. So it can be good that you look at the full diff again.
I didn't make cmake a pip dependency for all frameworks, but I think we should do that in a follow up PR while testing it for all FW. This will simplify the installation instruction.
ptrendx
ptrendx
reviewed
Mar 30, 2023
View reviewed changes
Comment threadREADME.rst
@ptrendx
ptrendx
commented
Mar 31, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz
Bring back support for none pip installed pybind11.
94405bf
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 31, 2023

Copy link


Copy Markdown

CollaboratorAuthor
/te-ci
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated


Comment on lines

+414
 to 
+416

 extras_require={
 'test': ['pytest',
 'tensorflow_datasets'],},
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: onnxruntime is needed for the PyTorch tests.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to handle this.

I think adding it for all FW isn't great.

I'm creating a "test_pytorch" extra.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
pip install pybind11

Clone the repository and inside it type:
Then, you can install this optional dependency:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

Then, you can install this optional dependency:
Then, the following optional dependencies can be installed:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the purpose of these dependencies would be useful, since they are 'optional'.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wanted to do that. But it isn't clear to me what ninja bring.

I was told it could be faster in some cases, but I don't know which case and I didn't test it.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py

Comment on lines

+211
 to 
+215

 # Trigger a better error when pybind11 isn't present.
 # Sadly, if pybind11 was installed with `apt -y install pybind11-dev`
 # This doesn't install a python packages. So the line bellow is too strict.
 # When it fail, we need to detect if cmake will find pybind11.
 # import pybind11
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear, what is the goal of this comment?
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to answer the question, "Why we're getting pybind11 via cmake?"
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pybind11 isn't installed, the error message is ugly and hard to read.

So I wanted to generate a better error by doing "import pybind11".

This work when we install pybind11 via pip, but it doesn't work when installed via apt-get.
@nouiz@ksivaman
Apply suggestions from code review
f610636
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
Changes following review.
d9ae968
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
timmoon10
timmoon10
reviewed
Apr 4, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

nouiz
added 3 commits
April 4, 2023 10:58
@nouiz
Change order to make it more clear.
0773865
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
Add other reviers suggestion.
3bd0c07
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
pybind11 is needed for all FW.
f59b91e
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
nouizand others
added 2 commits
April 4, 2023 13:34
@nouiz
Add flax as a dep
910cfd0
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@ksivaman
Merge branch 'main' into jax_install
cbbe556
timmoon10
timmoon10
approved these changes
Apr 4, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
commented
Apr 4, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz@ksivaman
Update README.rst
87b0b5e
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
nouiz
commented
Apr 5, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@ptrendx I accepted the suggested modification. But I don't see it anymore, so I can't comment on it.
@ksivaman
ksivaman
merged commit 3069ebc
into
NVIDIA:mainApr 5, 2023
ptrendx pushed a commit
that referenced
this pull request
Apr 5, 2023
@nouiz@ksivaman@ptrendx
Update installation instruction for JAX and add some dependencies. (#117
770e968
)
* Update installation instructio for JAX and add some depenencies.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Bring back support for none pip installed pybind11.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Apply suggestions from code review
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
* Changes following review.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Change order to make it more clear.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add other reviers suggestion.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* pybind11 is needed for all FW.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add flax as a dep
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Update README.rst
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
---------
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@hungryGeek16hungryGeek16
mentioned this pull request
May 31, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ptrendxptrendxptrendx left review comments
@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels

v0.7.0

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@nouiz@ksivaman@ptrendx@timmoon10

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update installation instruction for JAX and add some dependencies. by nouiz · Pull Request #117 · NVIDIA/TransformerEngine · GitHub
Skip to content
Update installation instruction for JAX and add some dependencies. - #117
Merged
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Apr 5, 2023
Merged
Update installation instruction for JAX and add some dependencies.#117
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Conversation
@nouiz
@nouiznouiz
commented
Mar 24, 2023

Copy link


Copy Markdown

Collaborator
 No description provided. 
@nouiznouiz
changed the title
Update installation instructio for JAX and add some dependencies.Update installation instruction for JAX and add some dependencies.Mar 24, 2023
ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

@ksivaman
ksivaman
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
@nouiz
nouizforce-pushed
the
jax_install
branch
2 times, most recently
from
421bea6 to
c3e02edCompareMarch 28, 2023 14:06
@nouiz
nouiz
commented
Mar 28, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Could you sign-off your commits using the instructions here? @nouiz
Done.
nouiz
nouiz
commented
Mar 28, 2023
View reviewed changes
Comment threadsetup.py
Outdated

timmoon10
timmoon10
reviewed
Mar 29, 2023
View reviewed changes
Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 29, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

@nouiz
nouiz
commented
Mar 29, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@timmoon10@ptrendx I did all the requested changes.

I didn't made the cmake packages a pytorch/tf dependency. I wasn't sure you wanted to change pytorch dependencies.

This can be done in a follow up PR if you want to do that.
@ksivaman
ksivaman
commented
Mar 30, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
Please resolve the conflicts too, thanks!
@nouiz
Update installation instructio for JAX and add some depenencies.
e3268b5
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 30, 2023

Copy link


Copy Markdown

CollaboratorAuthor
I rebased, squashed all the commits and signed it.

I did some fixes due to the rebase conflict. So it can be good that you look at the full diff again.
I didn't make cmake a pip dependency for all frameworks, but I think we should do that in a follow up PR while testing it for all FW. This will simplify the installation instruction.
ptrendx
ptrendx
reviewed
Mar 30, 2023
View reviewed changes
Comment threadREADME.rst
@ptrendx
ptrendx
commented
Mar 31, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz
Bring back support for none pip installed pybind11.
94405bf
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 31, 2023

Copy link


Copy Markdown

CollaboratorAuthor
/te-ci
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated


Comment on lines

+414
 to 
+416

 extras_require={
 'test': ['pytest',
 'tensorflow_datasets'],},
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: onnxruntime is needed for the PyTorch tests.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to handle this.

I think adding it for all FW isn't great.

I'm creating a "test_pytorch" extra.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
pip install pybind11

Clone the repository and inside it type:
Then, you can install this optional dependency:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

Then, you can install this optional dependency:
Then, the following optional dependencies can be installed:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the purpose of these dependencies would be useful, since they are 'optional'.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wanted to do that. But it isn't clear to me what ninja bring.

I was told it could be faster in some cases, but I don't know which case and I didn't test it.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py

Comment on lines

+211
 to 
+215

 # Trigger a better error when pybind11 isn't present.
 # Sadly, if pybind11 was installed with `apt -y install pybind11-dev`
 # This doesn't install a python packages. So the line bellow is too strict.
 # When it fail, we need to detect if cmake will find pybind11.
 # import pybind11
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear, what is the goal of this comment?
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to answer the question, "Why we're getting pybind11 via cmake?"
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pybind11 isn't installed, the error message is ugly and hard to read.

So I wanted to generate a better error by doing "import pybind11".

This work when we install pybind11 via pip, but it doesn't work when installed via apt-get.
@nouiz@ksivaman
Apply suggestions from code review
f610636
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
Changes following review.
d9ae968
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
timmoon10
timmoon10
reviewed
Apr 4, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

nouiz
added 3 commits
April 4, 2023 10:58
@nouiz
Change order to make it more clear.
0773865
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
Add other reviers suggestion.
3bd0c07
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
pybind11 is needed for all FW.
f59b91e
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
nouizand others
added 2 commits
April 4, 2023 13:34
@nouiz
Add flax as a dep
910cfd0
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@ksivaman
Merge branch 'main' into jax_install
cbbe556
timmoon10
timmoon10
approved these changes
Apr 4, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
commented
Apr 4, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz@ksivaman
Update README.rst
87b0b5e
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
nouiz
commented
Apr 5, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@ptrendx I accepted the suggested modification. But I don't see it anymore, so I can't comment on it.
@ksivaman
ksivaman
merged commit 3069ebc
into
NVIDIA:mainApr 5, 2023
ptrendx pushed a commit
that referenced
this pull request
Apr 5, 2023
@nouiz@ksivaman@ptrendx
Update installation instruction for JAX and add some dependencies. (#117
770e968
)
* Update installation instructio for JAX and add some depenencies.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Bring back support for none pip installed pybind11.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Apply suggestions from code review
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
* Changes following review.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Change order to make it more clear.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add other reviers suggestion.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* pybind11 is needed for all FW.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add flax as a dep
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Update README.rst
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
---------
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@hungryGeek16hungryGeek16
mentioned this pull request
May 31, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ptrendxptrendxptrendx left review comments
@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels

v0.7.0

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@nouiz@ksivaman@ptrendx@timmoon10

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update installation instruction for JAX and add some dependencies. by nouiz · Pull Request #117 · NVIDIA/TransformerEngine · GitHub
Skip to content
Update installation instruction for JAX and add some dependencies. - #117
Merged
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Apr 5, 2023
Merged
Update installation instruction for JAX and add some dependencies.#117
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Conversation
@nouiz
@nouiznouiz
commented
Mar 24, 2023

Copy link


Copy Markdown

Collaborator
 No description provided. 
@nouiznouiz
changed the title
Update installation instructio for JAX and add some dependencies.Update installation instruction for JAX and add some dependencies.Mar 24, 2023
ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

@ksivaman
ksivaman
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
@nouiz
nouizforce-pushed
the
jax_install
branch
2 times, most recently
from
421bea6 to
c3e02edCompareMarch 28, 2023 14:06
@nouiz
nouiz
commented
Mar 28, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Could you sign-off your commits using the instructions here? @nouiz
Done.
nouiz
nouiz
commented
Mar 28, 2023
View reviewed changes
Comment threadsetup.py
Outdated

timmoon10
timmoon10
reviewed
Mar 29, 2023
View reviewed changes
Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 29, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

@nouiz
nouiz
commented
Mar 29, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@timmoon10@ptrendx I did all the requested changes.

I didn't made the cmake packages a pytorch/tf dependency. I wasn't sure you wanted to change pytorch dependencies.

This can be done in a follow up PR if you want to do that.
@ksivaman
ksivaman
commented
Mar 30, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
Please resolve the conflicts too, thanks!
@nouiz
Update installation instructio for JAX and add some depenencies.
e3268b5
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 30, 2023

Copy link


Copy Markdown

CollaboratorAuthor
I rebased, squashed all the commits and signed it.

I did some fixes due to the rebase conflict. So it can be good that you look at the full diff again.
I didn't make cmake a pip dependency for all frameworks, but I think we should do that in a follow up PR while testing it for all FW. This will simplify the installation instruction.
ptrendx
ptrendx
reviewed
Mar 30, 2023
View reviewed changes
Comment threadREADME.rst
@ptrendx
ptrendx
commented
Mar 31, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz
Bring back support for none pip installed pybind11.
94405bf
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 31, 2023

Copy link


Copy Markdown

CollaboratorAuthor
/te-ci
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated


Comment on lines

+414
 to 
+416

 extras_require={
 'test': ['pytest',
 'tensorflow_datasets'],},
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: onnxruntime is needed for the PyTorch tests.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to handle this.

I think adding it for all FW isn't great.

I'm creating a "test_pytorch" extra.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
pip install pybind11

Clone the repository and inside it type:
Then, you can install this optional dependency:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

Then, you can install this optional dependency:
Then, the following optional dependencies can be installed:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the purpose of these dependencies would be useful, since they are 'optional'.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wanted to do that. But it isn't clear to me what ninja bring.

I was told it could be faster in some cases, but I don't know which case and I didn't test it.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py

Comment on lines

+211
 to 
+215

 # Trigger a better error when pybind11 isn't present.
 # Sadly, if pybind11 was installed with `apt -y install pybind11-dev`
 # This doesn't install a python packages. So the line bellow is too strict.
 # When it fail, we need to detect if cmake will find pybind11.
 # import pybind11
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear, what is the goal of this comment?
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to answer the question, "Why we're getting pybind11 via cmake?"
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pybind11 isn't installed, the error message is ugly and hard to read.

So I wanted to generate a better error by doing "import pybind11".

This work when we install pybind11 via pip, but it doesn't work when installed via apt-get.
@nouiz@ksivaman
Apply suggestions from code review
f610636
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
Changes following review.
d9ae968
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
timmoon10
timmoon10
reviewed
Apr 4, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

nouiz
added 3 commits
April 4, 2023 10:58
@nouiz
Change order to make it more clear.
0773865
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
Add other reviers suggestion.
3bd0c07
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
pybind11 is needed for all FW.
f59b91e
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
nouizand others
added 2 commits
April 4, 2023 13:34
@nouiz
Add flax as a dep
910cfd0
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@ksivaman
Merge branch 'main' into jax_install
cbbe556
timmoon10
timmoon10
approved these changes
Apr 4, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
commented
Apr 4, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz@ksivaman
Update README.rst
87b0b5e
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
nouiz
commented
Apr 5, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@ptrendx I accepted the suggested modification. But I don't see it anymore, so I can't comment on it.
@ksivaman
ksivaman
merged commit 3069ebc
into
NVIDIA:mainApr 5, 2023
ptrendx pushed a commit
that referenced
this pull request
Apr 5, 2023
@nouiz@ksivaman@ptrendx
Update installation instruction for JAX and add some dependencies. (#117
770e968
)
* Update installation instructio for JAX and add some depenencies.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Bring back support for none pip installed pybind11.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Apply suggestions from code review
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
* Changes following review.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Change order to make it more clear.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add other reviers suggestion.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* pybind11 is needed for all FW.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add flax as a dep
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Update README.rst
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
---------
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@hungryGeek16hungryGeek16
mentioned this pull request
May 31, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ptrendxptrendxptrendx left review comments
@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels

v0.7.0

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@nouiz@ksivaman@ptrendx@timmoon10

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update installation instruction for JAX and add some dependencies. by nouiz · Pull Request #117 · NVIDIA/TransformerEngine · GitHub
Skip to content
Update installation instruction for JAX and add some dependencies. - #117
Merged
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Apr 5, 2023
Merged
Update installation instruction for JAX and add some dependencies.#117
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Conversation
@nouiz
@nouiznouiz
commented
Mar 24, 2023

Copy link


Copy Markdown

Collaborator
 No description provided. 
@nouiznouiz
changed the title
Update installation instructio for JAX and add some dependencies.Update installation instruction for JAX and add some dependencies.Mar 24, 2023
ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

@ksivaman
ksivaman
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
@nouiz
nouizforce-pushed
the
jax_install
branch
2 times, most recently
from
421bea6 to
c3e02edCompareMarch 28, 2023 14:06
@nouiz
nouiz
commented
Mar 28, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Could you sign-off your commits using the instructions here? @nouiz
Done.
nouiz
nouiz
commented
Mar 28, 2023
View reviewed changes
Comment threadsetup.py
Outdated

timmoon10
timmoon10
reviewed
Mar 29, 2023
View reviewed changes
Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 29, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

@nouiz
nouiz
commented
Mar 29, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@timmoon10@ptrendx I did all the requested changes.

I didn't made the cmake packages a pytorch/tf dependency. I wasn't sure you wanted to change pytorch dependencies.

This can be done in a follow up PR if you want to do that.
@ksivaman
ksivaman
commented
Mar 30, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
Please resolve the conflicts too, thanks!
@nouiz
Update installation instructio for JAX and add some depenencies.
e3268b5
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 30, 2023

Copy link


Copy Markdown

CollaboratorAuthor
I rebased, squashed all the commits and signed it.

I did some fixes due to the rebase conflict. So it can be good that you look at the full diff again.
I didn't make cmake a pip dependency for all frameworks, but I think we should do that in a follow up PR while testing it for all FW. This will simplify the installation instruction.
ptrendx
ptrendx
reviewed
Mar 30, 2023
View reviewed changes
Comment threadREADME.rst
@ptrendx
ptrendx
commented
Mar 31, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz
Bring back support for none pip installed pybind11.
94405bf
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 31, 2023

Copy link


Copy Markdown

CollaboratorAuthor
/te-ci
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated


Comment on lines

+414
 to 
+416

 extras_require={
 'test': ['pytest',
 'tensorflow_datasets'],},
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: onnxruntime is needed for the PyTorch tests.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to handle this.

I think adding it for all FW isn't great.

I'm creating a "test_pytorch" extra.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
pip install pybind11

Clone the repository and inside it type:
Then, you can install this optional dependency:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

Then, you can install this optional dependency:
Then, the following optional dependencies can be installed:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the purpose of these dependencies would be useful, since they are 'optional'.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wanted to do that. But it isn't clear to me what ninja bring.

I was told it could be faster in some cases, but I don't know which case and I didn't test it.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py

Comment on lines

+211
 to 
+215

 # Trigger a better error when pybind11 isn't present.
 # Sadly, if pybind11 was installed with `apt -y install pybind11-dev`
 # This doesn't install a python packages. So the line bellow is too strict.
 # When it fail, we need to detect if cmake will find pybind11.
 # import pybind11
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear, what is the goal of this comment?
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to answer the question, "Why we're getting pybind11 via cmake?"
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pybind11 isn't installed, the error message is ugly and hard to read.

So I wanted to generate a better error by doing "import pybind11".

This work when we install pybind11 via pip, but it doesn't work when installed via apt-get.
@nouiz@ksivaman
Apply suggestions from code review
f610636
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
Changes following review.
d9ae968
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
timmoon10
timmoon10
reviewed
Apr 4, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

nouiz
added 3 commits
April 4, 2023 10:58
@nouiz
Change order to make it more clear.
0773865
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
Add other reviers suggestion.
3bd0c07
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
pybind11 is needed for all FW.
f59b91e
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
nouizand others
added 2 commits
April 4, 2023 13:34
@nouiz
Add flax as a dep
910cfd0
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@ksivaman
Merge branch 'main' into jax_install
cbbe556
timmoon10
timmoon10
approved these changes
Apr 4, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
commented
Apr 4, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz@ksivaman
Update README.rst
87b0b5e
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
nouiz
commented
Apr 5, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@ptrendx I accepted the suggested modification. But I don't see it anymore, so I can't comment on it.
@ksivaman
ksivaman
merged commit 3069ebc
into
NVIDIA:mainApr 5, 2023
ptrendx pushed a commit
that referenced
this pull request
Apr 5, 2023
@nouiz@ksivaman@ptrendx
Update installation instruction for JAX and add some dependencies. (#117
770e968
)
* Update installation instructio for JAX and add some depenencies.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Bring back support for none pip installed pybind11.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Apply suggestions from code review
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
* Changes following review.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Change order to make it more clear.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add other reviers suggestion.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* pybind11 is needed for all FW.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add flax as a dep
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Update README.rst
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
---------
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@hungryGeek16hungryGeek16
mentioned this pull request
May 31, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ptrendxptrendxptrendx left review comments
@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels

v0.7.0

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@nouiz@ksivaman@ptrendx@timmoon10

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Update installation instruction for JAX and add some dependencies. by nouiz · Pull Request #117 · NVIDIA/TransformerEngine · GitHub
Skip to content
Update installation instruction for JAX and add some dependencies. - #117
Merged
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Apr 5, 2023
Merged
Update installation instruction for JAX and add some dependencies.#117
ksivaman merged 10 commits into
NVIDIA:mainfrom 
nouiz:jax_install
Conversation
@nouiz
@nouiznouiz
commented
Mar 24, 2023

Copy link


Copy Markdown

Collaborator
 No description provided. 
@nouiznouiz
changed the title
Update installation instructio for JAX and add some dependencies.Update installation instruction for JAX and add some dependencies.Mar 24, 2023
ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 27, 2023
View reviewed changes
Comment threadsetup.py
Outdated

@ksivaman
ksivaman
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
@nouiz
nouizforce-pushed
the
jax_install
branch
2 times, most recently
from
421bea6 to
c3e02edCompareMarch 28, 2023 14:06
@nouiz
nouiz
commented
Mar 28, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Could you sign-off your commits using the instructions here? @nouiz
Done.
nouiz
nouiz
commented
Mar 28, 2023
View reviewed changes
Comment threadsetup.py
Outdated

timmoon10
timmoon10
reviewed
Mar 29, 2023
View reviewed changes
Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

Comment threadsetup.py
Outdated

ptrendx
ptrendx
reviewed
Mar 29, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

@nouiz
nouiz
commented
Mar 29, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@timmoon10@ptrendx I did all the requested changes.

I didn't made the cmake packages a pytorch/tf dependency. I wasn't sure you wanted to change pytorch dependencies.

This can be done in a follow up PR if you want to do that.
@ksivaman
ksivaman
commented
Mar 30, 2023

Copy link


Copy Markdown

Member
Could you sign-off your commits using the instructions here? @nouiz
Please resolve the conflicts too, thanks!
@nouiz
Update installation instructio for JAX and add some depenencies.
e3268b5
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 30, 2023

Copy link


Copy Markdown

CollaboratorAuthor
I rebased, squashed all the commits and signed it.

I did some fixes due to the rebase conflict. So it can be good that you look at the full diff again.
I didn't make cmake a pip dependency for all frameworks, but I think we should do that in a follow up PR while testing it for all FW. This will simplify the installation instruction.
ptrendx
ptrendx
reviewed
Mar 30, 2023
View reviewed changes
Comment threadREADME.rst
@ptrendx
ptrendx
commented
Mar 31, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz
Bring back support for none pip installed pybind11.
94405bf
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
nouiz
commented
Mar 31, 2023

Copy link


Copy Markdown

CollaboratorAuthor
/te-ci
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated


Comment on lines

+414
 to 
+416

 extras_require={
 'test': ['pytest',
 'tensorflow_datasets'],},
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: onnxruntime is needed for the PyTorch tests.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to handle this.

I think adding it for all FW isn't great.

I'm creating a "test_pytorch" extra.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
pip install pybind11

Clone the repository and inside it type:
Then, you can install this optional dependency:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

Then, you can install this optional dependency:
Then, the following optional dependencies can be installed:
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the purpose of these dependencies would be useful, since they are 'optional'.
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wanted to do that. But it isn't clear to me what ninja bring.

I was told it could be faster in some cases, but I don't know which case and I didn't test it.
ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadREADME.rst
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py
Outdated

ksivaman
ksivaman
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsetup.py

Comment on lines

+211
 to 
+215

 # Trigger a better error when pybind11 isn't present.
 # Sadly, if pybind11 was installed with `apt -y install pybind11-dev`
 # This doesn't install a python packages. So the line bellow is too strict.
 # When it fail, we need to detect if cmake will find pybind11.
 # import pybind11
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear, what is the goal of this comment?
@ksivamanksivamanApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to answer the question, "Why we're getting pybind11 via cmake?"
@nouiznouizApr 4, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pybind11 isn't installed, the error message is ugly and hard to read.

So I wanted to generate a better error by doing "import pybind11".

This work when we install pybind11 via pip, but it doesn't work when installed via apt-get.
@nouiz@ksivaman
Apply suggestions from code review
f610636
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
Changes following review.
d9ae968
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
timmoon10
timmoon10
reviewed
Apr 4, 2023
View reviewed changes
Comment threaddocs/installation.rst
Outdated

nouiz
added 3 commits
April 4, 2023 10:58
@nouiz
Change order to make it more clear.
0773865
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
Add other reviers suggestion.
3bd0c07
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@nouiz
pybind11 is needed for all FW.
f59b91e
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
nouizand others
added 2 commits
April 4, 2023 13:34
@nouiz
Add flax as a dep
910cfd0
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
@ksivaman
Merge branch 'main' into jax_install
cbbe556
timmoon10
timmoon10
approved these changes
Apr 4, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
commented
Apr 4, 2023

Copy link


Copy Markdown

Member
/te-ci
@nouiz@ksivaman
Update README.rst
87b0b5e
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
@nouiz
nouiz
commented
Apr 5, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@ptrendx I accepted the suggested modification. But I don't see it anymore, so I can't comment on it.
@ksivaman
ksivaman
merged commit 3069ebc
into
NVIDIA:mainApr 5, 2023
ptrendx pushed a commit
that referenced
this pull request
Apr 5, 2023
@nouiz@ksivaman@ptrendx
Update installation instruction for JAX and add some dependencies. (#117
770e968
)
* Update installation instructio for JAX and add some depenencies.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Bring back support for none pip installed pybind11.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Apply suggestions from code review
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
* Changes following review.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Change order to make it more clear.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add other reviers suggestion.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* pybind11 is needed for all FW.
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Add flax as a dep
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
* Update README.rst
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
---------
Signed-off-by: Frederic Bastien <fbastien@nvidia.com>
Signed-off-by: Frédéric Bastien <frederic.bastien@gmail.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@hungryGeek16hungryGeek16
mentioned this pull request
May 31, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ptrendxptrendxptrendx left review comments
@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels

v0.7.0

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@nouiz@ksivaman@ptrendx@timmoon10