Uh oh!
There was an error while loading. Please reload this page.
Make userbuffers support strictly opt-in - #161
Closed
timmoon10 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10
marked this pull request as draft
April 20, 2023 06:07
timmoon10
commented
Apr 20, 2023
MemberAuthor
/te-ci |
MemberAuthor
Pipeline w/ userbuffers: 8020580 passed |
timmoon10
commented
Apr 20, 2023
MemberAuthor
Merged into #162. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#147 builds with support for userbuffers whenever
MPI_HOMEis set in the environment. This isn't great since users may run on non-DGX systems with MPI support (alas), not to mention userbuffers is very hacky. This PR only builds with userbuffers support when explicitly enabled:It also refactors the build system to handle MPI in a more standard way.