Skip to content

[PyTorch] Update PyTorch FSDP2 test to cover all TE layer types - #1777

Closed
denera wants to merge 5 commits into
NVIDIA:mainfrom
denera:pytorch/test-fsdp2-with-all-layers
Closed

[PyTorch] Update PyTorch FSDP2 test to cover all TE layer types#1777
denera wants to merge 5 commits into
NVIDIA:mainfrom
denera:pytorch/test-fsdp2-with-all-layers

Conversation

@denera

@deneradenera commented May 12, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR expands the FSDP2 test to cover fused and composite layers.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Alp Dener <adener@nvidia.com>
@deneradenera self-assigned this May 12, 2025
@deneradenera added testing Improvements to tests or testing infrastructure 2.4.0 labels May 12, 2025
@denera

Copy link
Copy Markdown
CollaboratorAuthor

/te-ci pytorch L1

Signed-off-by: Alp Dener <adener@nvidia.com>
Comment threadtests/pytorch/distributed/run_fsdp2_model.py
Comment threadtests/pytorch/distributed/run_fsdp2_model.py Outdated
@ksivaman

Copy link
Copy Markdown
Member

/te-ci pytorch L1

@ksivamanksivaman removed the 2.4.0 label May 21, 2025
@ptrendx

Copy link
Copy Markdown
Member

The FSDP2 enablement PR #2245 was merged that also includes changes from this PR.

@ptrendxptrendx closed this Nov 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testingImprovements to tests or testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@denera@ksivaman@ptrendx@youngeunkwon0405