Uh oh!
There was an error while loading. Please reload this page.
NVRTC kernels for cast-transpose - #258
Merged
Merged
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10force-pushed
the
nvrtc-cast-transpose
branch
from
June 1, 2023 21:24
dfc121b to
aed892aComparetimmoon10
commented
Jun 1, 2023
MemberAuthor
/te-ci |
timmoon10
commented
Jun 7, 2023
MemberAuthor
/te-ci |
timmoon10
commented
Jul 3, 2023
MemberAuthor
/te-ci |
timmoon10
commented
Nov 9, 2023
MemberAuthor
/te-ci |
timmoon10
commented
Nov 15, 2023
MemberAuthor
/te-ci |
timmoon10
commented
Dec 18, 2023
MemberAuthor
/te-ci |
timmoon10
commented
Jan 4, 2024
MemberAuthor
/te-ci |
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10
commented
Jan 6, 2024
MemberAuthor
/te-ci |
timmoon10
commented
Feb 6, 2024
MemberAuthor
/te-ci |
timmoon10
commented
Mar 6, 2024
MemberAuthor
/te-ci |
timmoon10
commented
Apr 5, 2024
MemberAuthor
/te-ci |
timmoon10
commented
Apr 5, 2024
MemberAuthor
If there are no objections, I will merge this after the 1.6 release. |
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10
commented
Apr 16, 2024
MemberAuthor
/te-ci |
timmoon10
commented
Apr 18, 2024
MemberAuthor
/te-ci |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| const size_t num_tiles) { | ||
| __launch_bounds__(block_size) | ||
| cast_transpose_general_kernel(const IType * __restrict__ const input, | ||
| const CType * const noop, |
Collaborator
There was a problem hiding this comment.
Was the restrict keyword intentionally omitted here?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Oleg-Goncharov
approved these changes
Apr 19, 2024
Oleg-Goncharov
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, besides the early return from the kernel configuration constructors
timmoon10
commented
Apr 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
timmoon10
commented
Apr 19, 2024
MemberAuthor
/te-ci |
pggPL pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 23, 2024
* Add NVRTC kernels for cast-transpose Signed-off-by: Tim Moon <tmoon@nvidia.com> * Update copyright year Signed-off-by: Tim Moon <tmoon@nvidia.com> * Add noop flag to NVRTC cast-transpose kernel Signed-off-by: Tim Moon <tmoon@nvidia.com> * Apply suggestions from code review Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #138 that adds NVRTC kernels for cast-transpose.
I've also tweaked the kernel selection heuristics to be a bit more general. There are some performance differences at intermediate scale, but nothing too drastic:
Transpose kernel times
Evaluated FP8 transposes on an H100 PCIe with square matrices with nice dims (power of two or halfway between powers of two).