[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM - #3069

Open
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm
Open

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM#3069
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm

Conversation

@alan-hpc

@alan-hpcalan-hpc commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR extends the CUTLASS Group GEMM support added in #2045 to cover the variable-K
(K-grouped / ragged-K) BF16 weight-gradient (wgrad)
path of fine-grained MoE models on H100 (SM90).

In expert-parallel MoE training the per-expert token counts — the contraction dimension of the
wgrad GEMM D_i = B_iᵀ @ A_i — are ragged and generally not 128-aligned, which the existing
uniform-K CUTLASS grouped-GEMM fast path from #2045 cannot serve. This PR adds a dedicated path
that handles ragged per-expert token counts directly (SM90 TMA/WGMMA), zero-initializes empty
(K=0) groups, and writes each per-expert D_i in place. Inputs are BF16; output is FP32 (default)
or BF16. The standard uniform-K and Multi-Stream cuBLAS paths are unchanged.

Performance on H100 80GB, BF16, wgrad (D_i = B_iᵀ @ A_i), CUTLASS vs. the Multi-Stream cuBLAS
baseline. Shape is (g, m, n, k[mink, avgk, maxk]): g groups, m = expert dim, n = hidden dim,
k = the per-group routed-token count — the ragged contraction this kernel is built for.

run benchmark with

NVTE_USE_CUTLASS_GROUPED_GEMM=1 python benchmarks/gemm/benchmark_grouped_gemm_fwd_bwd.py --use-cutlass --dtype bf16 --num-experts <E> --ep-size 8 --hidden-dim 2048 --expert-dim 512 [--jagged-splits ...]

Shape(g, m, n, k[mink, avgk, maxk])TE (cuBLAS, TFLOPs)Cutlass (TFLOPs)Speed-Up
(20, 512, 2048, k[3328, 3328, 3328])445.50567.651.27×
(20, 512, 2048, k[512, 3104, 6016])444.52520.921.17×
(32, 512, 2048, k[1024, 2048, 3072])361.13564.131.56×
(32, 512, 2048, k[512, 1024, 1536])173.50512.612.95×

The gain grows as the per-group K shrinks: small, ragged groups are where the Multi-Stream cuBLAS
per-group launch overhead dominates.

Correctness reuses the existing test harness from #2045 (unchanged in this PR): the parametrized
tests/pytorch/test_grouped_linear.py::test_grouped_gemm with layout=NT (the wgrad case),
use_cutlass=True, dtype=bfloat16 over ragged group splits exercises exactly this path and passes
on SM90.

This path reuses the NVTE_USE_CUTLASS_GROUPED_GEMM toggle introduced in #2045 (default 0):
export NVTE_USE_CUTLASS_GROUPED_GEMM=1 routes the BF16 NT wgrad through CUTLASS, 0 keeps the
Multi-Stream cuBLAS implementation. NVTE_CUTLASS_GROUPED_GEMM_WARN_FALLBACK still warns on fallback.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes

  • cutlass_grouped_gemm.cuh: add CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD> — an SM90
    grouped-GEMM template specialized for the NT wgrad layout — with explicit instantiations for
    FP32 and BF16 output.
  • cutlass_grouped_gemm.cu: add cutlass_grouped_gemm_varlen_k(...). It validates the BF16 NT wgrad
    contract, splits groups into the non-empty set (excluding K=0 groups whose null A/B pointers
    would crash TMA descriptor construction, zero-initializing their outputs when not accumulating),
    and dispatches on output dtype — mirroring the existing cutlass_grouped_gemm call path.
  • cublaslt_gemm.cu: wire the path into the nvte_multi_tensor_gemm dispatch
    (uniform-K fast path → K-grouped wgrad → cuBLAS fallback).

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actionsgithub-actionsBot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Jun 1, 2026
@greptile-apps

greptile-appsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the existing CUTLASS Grouped GEMM path (from #2045) to handle the variable-K (ragged-K) BF16 weight-gradient case that arises in fine-grained MoE training on Hopper (SM90) and now Blackwell (SM100/SM103). It also refactors the host staging buffer from a monolithic 4 MB allocation to a 1024-slot pinned ring buffer (64 KB/slot, 64 MB total) to eliminate the per-call synchronization overhead imposed by pageable host memory.

  • Adds CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD, kSm100, kBigN> with SM90 Cooperative (FP32 output) / Pingpong (BF16 output) and SM100 2-SM tile variants, dispatched via a new cutlass_grouped_gemm_varlen_k function that filters out K=0 empty groups before launch.
  • Wires the new path into nvte_multi_tensor_gemm behind shape-eligibility guards (is_bf16_wgrad_dtype, is_bf16_wgrad_shape) so mismatched or unsupported shapes still fall back to cuBLAS.
  • Also adds forward-path SM100 instantiations for CutlassGroupedGemm, extends the host ring buffer for the forward path, and increases kMaxGroups from 64 to 256 to handle larger expert counts in expert-parallel MoE.

Confidence Score: 5/5

The new varlen-K wgrad dispatch path is well-guarded: shape eligibility is validated before entering the CUTLASS path, K=0 empty groups are correctly excluded with output zero-initialization when not accumulating, and the ring-buffer design properly prevents host-buffer reuse races across concurrent stream launches.

The core correctness logic — group filtering, NT-layout dispatch, SM90/SM100 tile selection, and cuBLAS fallback preservation — is sound. All findings are latent guards that are wrong in principle but cannot trigger given the current kMaxGroups=256 bound (~15 KB per slot, well within the 64 KB ring slot).

cutlass_grouped_gemm.cuh: the ring-buffer slot-size guard, the strict less-than workspace checks, and the two uninstantiated device-path functions whose null problem_sizes_host pointer could crash CUTLASS's scheduler if they are ever wired up without a matching host estimate.

Important Files Changed

FilenameOverview
transformer_engine/common/gemm/cutlass_grouped_gemm.cuhCore template file adding CutlassGroupedGemmWgrad, SM100 schedule selectors, ring-buffer host workspace, and two new unreachable device-path functions; ring-buffer size guard checks total buffer size instead of per-slot size, and workspace size checks use strict less-than
transformer_engine/common/gemm/cutlass_grouped_gemm.cuAdds explicit template instantiations for SM100 forward + wgrad variants; adds collect_bf16_wgrad_nt_groups and cutlass_grouped_gemm_varlen_k; correct SM100/SM90 dispatch logic
transformer_engine/common/gemm/cublaslt_gemm.cuAdds Blackwell detection, is_bf16_wgrad_dtype/shape eligibility guards, and the new else-if branch dispatching to cutlass_grouped_gemm_varlen_k; logic is correct and unguarded shapes fall back to cuBLAS
transformer_engine/common/gemm/cublaslt_grouped_gemm.cuAdds out_m, out_n, contraction_k fields to GroupedGemmConfig and increases kMaxGroups to 256; fields computed correctly but currently unused (pre-wired for future device-path integration)
tests/pytorch/test_grouped_linear.pyExtends skipif condition to include Blackwell (SM100/SM103) alongside Hopper (SM90); logically correct
transformer_engine/common/CMakeLists.txtAdds CUDA::nvrtc and CUDA::cuda_driver as public link dependencies; consistent with SM100 CUTLASS requirements

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading

Reviews (5): Last reviewed commit: "Merge branch 'NVIDIA:main' into feat/var..." | Re-trigger Greptile

Comment threadtransformer_engine/common/gemm/cutlass_grouped_gemm.cuh Outdated
Comment threadtransformer_engine/common/gemm/cublaslt_gemm.cu
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from d0edc9f to bda3dc3CompareJune 1, 2026 12:27
@alan-hpcalan-hpc changed the title Add variable-K (K-grouped) BF16 wgrad grouped GEMM (CUTLASS, SM90)[Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgradJun 1, 2026
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from f7a2b73 to e7a4db9CompareJune 1, 2026 12:58
@ptrendx

Copy link
Copy Markdown
Member

How does this kernel compare performance-wise with the cuBLASLt grouped gemm? Ideally if cuBLAS is better we would like to move towards that solution instead.

@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 0db8b00 to 0d190d0CompareJune 16, 2026 03:01
…m support
Signed-off-by: Min Yang <min.yang@shopee.com>
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 81c6fd2 to 1453a88CompareJune 16, 2026 03:05
@alan-hpcalan-hpc changed the title [Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgrad[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMMJun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionPRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-hpc@ptrendx
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM - #3069

Open
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm
Open

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM#3069
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm

Conversation

@alan-hpc

@alan-hpcalan-hpc commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR extends the CUTLASS Group GEMM support added in #2045 to cover the variable-K
(K-grouped / ragged-K) BF16 weight-gradient (wgrad)
path of fine-grained MoE models on H100 (SM90).

In expert-parallel MoE training the per-expert token counts — the contraction dimension of the
wgrad GEMM D_i = B_iᵀ @ A_i — are ragged and generally not 128-aligned, which the existing
uniform-K CUTLASS grouped-GEMM fast path from #2045 cannot serve. This PR adds a dedicated path
that handles ragged per-expert token counts directly (SM90 TMA/WGMMA), zero-initializes empty
(K=0) groups, and writes each per-expert D_i in place. Inputs are BF16; output is FP32 (default)
or BF16. The standard uniform-K and Multi-Stream cuBLAS paths are unchanged.

Performance on H100 80GB, BF16, wgrad (D_i = B_iᵀ @ A_i), CUTLASS vs. the Multi-Stream cuBLAS
baseline. Shape is (g, m, n, k[mink, avgk, maxk]): g groups, m = expert dim, n = hidden dim,
k = the per-group routed-token count — the ragged contraction this kernel is built for.

run benchmark with

NVTE_USE_CUTLASS_GROUPED_GEMM=1 python benchmarks/gemm/benchmark_grouped_gemm_fwd_bwd.py --use-cutlass --dtype bf16 --num-experts <E> --ep-size 8 --hidden-dim 2048 --expert-dim 512 [--jagged-splits ...]

Shape(g, m, n, k[mink, avgk, maxk])TE (cuBLAS, TFLOPs)Cutlass (TFLOPs)Speed-Up
(20, 512, 2048, k[3328, 3328, 3328])445.50567.651.27×
(20, 512, 2048, k[512, 3104, 6016])444.52520.921.17×
(32, 512, 2048, k[1024, 2048, 3072])361.13564.131.56×
(32, 512, 2048, k[512, 1024, 1536])173.50512.612.95×

The gain grows as the per-group K shrinks: small, ragged groups are where the Multi-Stream cuBLAS
per-group launch overhead dominates.

Correctness reuses the existing test harness from #2045 (unchanged in this PR): the parametrized
tests/pytorch/test_grouped_linear.py::test_grouped_gemm with layout=NT (the wgrad case),
use_cutlass=True, dtype=bfloat16 over ragged group splits exercises exactly this path and passes
on SM90.

This path reuses the NVTE_USE_CUTLASS_GROUPED_GEMM toggle introduced in #2045 (default 0):
export NVTE_USE_CUTLASS_GROUPED_GEMM=1 routes the BF16 NT wgrad through CUTLASS, 0 keeps the
Multi-Stream cuBLAS implementation. NVTE_CUTLASS_GROUPED_GEMM_WARN_FALLBACK still warns on fallback.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes

  • cutlass_grouped_gemm.cuh: add CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD> — an SM90
    grouped-GEMM template specialized for the NT wgrad layout — with explicit instantiations for
    FP32 and BF16 output.
  • cutlass_grouped_gemm.cu: add cutlass_grouped_gemm_varlen_k(...). It validates the BF16 NT wgrad
    contract, splits groups into the non-empty set (excluding K=0 groups whose null A/B pointers
    would crash TMA descriptor construction, zero-initializing their outputs when not accumulating),
    and dispatches on output dtype — mirroring the existing cutlass_grouped_gemm call path.
  • cublaslt_gemm.cu: wire the path into the nvte_multi_tensor_gemm dispatch
    (uniform-K fast path → K-grouped wgrad → cuBLAS fallback).

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actionsgithub-actionsBot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Jun 1, 2026
@greptile-apps

greptile-appsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the existing CUTLASS Grouped GEMM path (from #2045) to handle the variable-K (ragged-K) BF16 weight-gradient case that arises in fine-grained MoE training on Hopper (SM90) and now Blackwell (SM100/SM103). It also refactors the host staging buffer from a monolithic 4 MB allocation to a 1024-slot pinned ring buffer (64 KB/slot, 64 MB total) to eliminate the per-call synchronization overhead imposed by pageable host memory.

  • Adds CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD, kSm100, kBigN> with SM90 Cooperative (FP32 output) / Pingpong (BF16 output) and SM100 2-SM tile variants, dispatched via a new cutlass_grouped_gemm_varlen_k function that filters out K=0 empty groups before launch.
  • Wires the new path into nvte_multi_tensor_gemm behind shape-eligibility guards (is_bf16_wgrad_dtype, is_bf16_wgrad_shape) so mismatched or unsupported shapes still fall back to cuBLAS.
  • Also adds forward-path SM100 instantiations for CutlassGroupedGemm, extends the host ring buffer for the forward path, and increases kMaxGroups from 64 to 256 to handle larger expert counts in expert-parallel MoE.

Confidence Score: 5/5

The new varlen-K wgrad dispatch path is well-guarded: shape eligibility is validated before entering the CUTLASS path, K=0 empty groups are correctly excluded with output zero-initialization when not accumulating, and the ring-buffer design properly prevents host-buffer reuse races across concurrent stream launches.

The core correctness logic — group filtering, NT-layout dispatch, SM90/SM100 tile selection, and cuBLAS fallback preservation — is sound. All findings are latent guards that are wrong in principle but cannot trigger given the current kMaxGroups=256 bound (~15 KB per slot, well within the 64 KB ring slot).

cutlass_grouped_gemm.cuh: the ring-buffer slot-size guard, the strict less-than workspace checks, and the two uninstantiated device-path functions whose null problem_sizes_host pointer could crash CUTLASS's scheduler if they are ever wired up without a matching host estimate.

Important Files Changed

FilenameOverview
transformer_engine/common/gemm/cutlass_grouped_gemm.cuhCore template file adding CutlassGroupedGemmWgrad, SM100 schedule selectors, ring-buffer host workspace, and two new unreachable device-path functions; ring-buffer size guard checks total buffer size instead of per-slot size, and workspace size checks use strict less-than
transformer_engine/common/gemm/cutlass_grouped_gemm.cuAdds explicit template instantiations for SM100 forward + wgrad variants; adds collect_bf16_wgrad_nt_groups and cutlass_grouped_gemm_varlen_k; correct SM100/SM90 dispatch logic
transformer_engine/common/gemm/cublaslt_gemm.cuAdds Blackwell detection, is_bf16_wgrad_dtype/shape eligibility guards, and the new else-if branch dispatching to cutlass_grouped_gemm_varlen_k; logic is correct and unguarded shapes fall back to cuBLAS
transformer_engine/common/gemm/cublaslt_grouped_gemm.cuAdds out_m, out_n, contraction_k fields to GroupedGemmConfig and increases kMaxGroups to 256; fields computed correctly but currently unused (pre-wired for future device-path integration)
tests/pytorch/test_grouped_linear.pyExtends skipif condition to include Blackwell (SM100/SM103) alongside Hopper (SM90); logically correct
transformer_engine/common/CMakeLists.txtAdds CUDA::nvrtc and CUDA::cuda_driver as public link dependencies; consistent with SM100 CUTLASS requirements

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading

Reviews (5): Last reviewed commit: "Merge branch 'NVIDIA:main' into feat/var..." | Re-trigger Greptile

Comment threadtransformer_engine/common/gemm/cutlass_grouped_gemm.cuh Outdated
Comment threadtransformer_engine/common/gemm/cublaslt_gemm.cu
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from d0edc9f to bda3dc3CompareJune 1, 2026 12:27
@alan-hpcalan-hpc changed the title Add variable-K (K-grouped) BF16 wgrad grouped GEMM (CUTLASS, SM90)[Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgradJun 1, 2026
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from f7a2b73 to e7a4db9CompareJune 1, 2026 12:58
@ptrendx

Copy link
Copy Markdown
Member

How does this kernel compare performance-wise with the cuBLASLt grouped gemm? Ideally if cuBLAS is better we would like to move towards that solution instead.

@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 0db8b00 to 0d190d0CompareJune 16, 2026 03:01
…m support
Signed-off-by: Min Yang <min.yang@shopee.com>
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 81c6fd2 to 1453a88CompareJune 16, 2026 03:05
@alan-hpcalan-hpc changed the title [Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgrad[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMMJun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionPRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-hpc@ptrendx
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM - #3069

Open
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm
Open

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM#3069
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm

Conversation

@alan-hpc

@alan-hpcalan-hpc commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR extends the CUTLASS Group GEMM support added in #2045 to cover the variable-K
(K-grouped / ragged-K) BF16 weight-gradient (wgrad)
path of fine-grained MoE models on H100 (SM90).

In expert-parallel MoE training the per-expert token counts — the contraction dimension of the
wgrad GEMM D_i = B_iᵀ @ A_i — are ragged and generally not 128-aligned, which the existing
uniform-K CUTLASS grouped-GEMM fast path from #2045 cannot serve. This PR adds a dedicated path
that handles ragged per-expert token counts directly (SM90 TMA/WGMMA), zero-initializes empty
(K=0) groups, and writes each per-expert D_i in place. Inputs are BF16; output is FP32 (default)
or BF16. The standard uniform-K and Multi-Stream cuBLAS paths are unchanged.

Performance on H100 80GB, BF16, wgrad (D_i = B_iᵀ @ A_i), CUTLASS vs. the Multi-Stream cuBLAS
baseline. Shape is (g, m, n, k[mink, avgk, maxk]): g groups, m = expert dim, n = hidden dim,
k = the per-group routed-token count — the ragged contraction this kernel is built for.

run benchmark with

NVTE_USE_CUTLASS_GROUPED_GEMM=1 python benchmarks/gemm/benchmark_grouped_gemm_fwd_bwd.py --use-cutlass --dtype bf16 --num-experts <E> --ep-size 8 --hidden-dim 2048 --expert-dim 512 [--jagged-splits ...]

Shape(g, m, n, k[mink, avgk, maxk])TE (cuBLAS, TFLOPs)Cutlass (TFLOPs)Speed-Up
(20, 512, 2048, k[3328, 3328, 3328])445.50567.651.27×
(20, 512, 2048, k[512, 3104, 6016])444.52520.921.17×
(32, 512, 2048, k[1024, 2048, 3072])361.13564.131.56×
(32, 512, 2048, k[512, 1024, 1536])173.50512.612.95×

The gain grows as the per-group K shrinks: small, ragged groups are where the Multi-Stream cuBLAS
per-group launch overhead dominates.

Correctness reuses the existing test harness from #2045 (unchanged in this PR): the parametrized
tests/pytorch/test_grouped_linear.py::test_grouped_gemm with layout=NT (the wgrad case),
use_cutlass=True, dtype=bfloat16 over ragged group splits exercises exactly this path and passes
on SM90.

This path reuses the NVTE_USE_CUTLASS_GROUPED_GEMM toggle introduced in #2045 (default 0):
export NVTE_USE_CUTLASS_GROUPED_GEMM=1 routes the BF16 NT wgrad through CUTLASS, 0 keeps the
Multi-Stream cuBLAS implementation. NVTE_CUTLASS_GROUPED_GEMM_WARN_FALLBACK still warns on fallback.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes

  • cutlass_grouped_gemm.cuh: add CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD> — an SM90
    grouped-GEMM template specialized for the NT wgrad layout — with explicit instantiations for
    FP32 and BF16 output.
  • cutlass_grouped_gemm.cu: add cutlass_grouped_gemm_varlen_k(...). It validates the BF16 NT wgrad
    contract, splits groups into the non-empty set (excluding K=0 groups whose null A/B pointers
    would crash TMA descriptor construction, zero-initializing their outputs when not accumulating),
    and dispatches on output dtype — mirroring the existing cutlass_grouped_gemm call path.
  • cublaslt_gemm.cu: wire the path into the nvte_multi_tensor_gemm dispatch
    (uniform-K fast path → K-grouped wgrad → cuBLAS fallback).

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actionsgithub-actionsBot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Jun 1, 2026
@greptile-apps

greptile-appsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the existing CUTLASS Grouped GEMM path (from #2045) to handle the variable-K (ragged-K) BF16 weight-gradient case that arises in fine-grained MoE training on Hopper (SM90) and now Blackwell (SM100/SM103). It also refactors the host staging buffer from a monolithic 4 MB allocation to a 1024-slot pinned ring buffer (64 KB/slot, 64 MB total) to eliminate the per-call synchronization overhead imposed by pageable host memory.

  • Adds CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD, kSm100, kBigN> with SM90 Cooperative (FP32 output) / Pingpong (BF16 output) and SM100 2-SM tile variants, dispatched via a new cutlass_grouped_gemm_varlen_k function that filters out K=0 empty groups before launch.
  • Wires the new path into nvte_multi_tensor_gemm behind shape-eligibility guards (is_bf16_wgrad_dtype, is_bf16_wgrad_shape) so mismatched or unsupported shapes still fall back to cuBLAS.
  • Also adds forward-path SM100 instantiations for CutlassGroupedGemm, extends the host ring buffer for the forward path, and increases kMaxGroups from 64 to 256 to handle larger expert counts in expert-parallel MoE.

Confidence Score: 5/5

The new varlen-K wgrad dispatch path is well-guarded: shape eligibility is validated before entering the CUTLASS path, K=0 empty groups are correctly excluded with output zero-initialization when not accumulating, and the ring-buffer design properly prevents host-buffer reuse races across concurrent stream launches.

The core correctness logic — group filtering, NT-layout dispatch, SM90/SM100 tile selection, and cuBLAS fallback preservation — is sound. All findings are latent guards that are wrong in principle but cannot trigger given the current kMaxGroups=256 bound (~15 KB per slot, well within the 64 KB ring slot).

cutlass_grouped_gemm.cuh: the ring-buffer slot-size guard, the strict less-than workspace checks, and the two uninstantiated device-path functions whose null problem_sizes_host pointer could crash CUTLASS's scheduler if they are ever wired up without a matching host estimate.

Important Files Changed

FilenameOverview
transformer_engine/common/gemm/cutlass_grouped_gemm.cuhCore template file adding CutlassGroupedGemmWgrad, SM100 schedule selectors, ring-buffer host workspace, and two new unreachable device-path functions; ring-buffer size guard checks total buffer size instead of per-slot size, and workspace size checks use strict less-than
transformer_engine/common/gemm/cutlass_grouped_gemm.cuAdds explicit template instantiations for SM100 forward + wgrad variants; adds collect_bf16_wgrad_nt_groups and cutlass_grouped_gemm_varlen_k; correct SM100/SM90 dispatch logic
transformer_engine/common/gemm/cublaslt_gemm.cuAdds Blackwell detection, is_bf16_wgrad_dtype/shape eligibility guards, and the new else-if branch dispatching to cutlass_grouped_gemm_varlen_k; logic is correct and unguarded shapes fall back to cuBLAS
transformer_engine/common/gemm/cublaslt_grouped_gemm.cuAdds out_m, out_n, contraction_k fields to GroupedGemmConfig and increases kMaxGroups to 256; fields computed correctly but currently unused (pre-wired for future device-path integration)
tests/pytorch/test_grouped_linear.pyExtends skipif condition to include Blackwell (SM100/SM103) alongside Hopper (SM90); logically correct
transformer_engine/common/CMakeLists.txtAdds CUDA::nvrtc and CUDA::cuda_driver as public link dependencies; consistent with SM100 CUTLASS requirements

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading

Reviews (5): Last reviewed commit: "Merge branch 'NVIDIA:main' into feat/var..." | Re-trigger Greptile

Comment threadtransformer_engine/common/gemm/cutlass_grouped_gemm.cuh Outdated
Comment threadtransformer_engine/common/gemm/cublaslt_gemm.cu
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from d0edc9f to bda3dc3CompareJune 1, 2026 12:27
@alan-hpcalan-hpc changed the title Add variable-K (K-grouped) BF16 wgrad grouped GEMM (CUTLASS, SM90)[Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgradJun 1, 2026
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from f7a2b73 to e7a4db9CompareJune 1, 2026 12:58
@ptrendx

Copy link
Copy Markdown
Member

How does this kernel compare performance-wise with the cuBLASLt grouped gemm? Ideally if cuBLAS is better we would like to move towards that solution instead.

@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 0db8b00 to 0d190d0CompareJune 16, 2026 03:01
…m support
Signed-off-by: Min Yang <min.yang@shopee.com>
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 81c6fd2 to 1453a88CompareJune 16, 2026 03:05
@alan-hpcalan-hpc changed the title [Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgrad[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMMJun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionPRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-hpc@ptrendx
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM - #3069

Open
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm
Open

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM#3069
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm

Conversation

@alan-hpc

@alan-hpcalan-hpc commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR extends the CUTLASS Group GEMM support added in #2045 to cover the variable-K
(K-grouped / ragged-K) BF16 weight-gradient (wgrad)
path of fine-grained MoE models on H100 (SM90).

In expert-parallel MoE training the per-expert token counts — the contraction dimension of the
wgrad GEMM D_i = B_iᵀ @ A_i — are ragged and generally not 128-aligned, which the existing
uniform-K CUTLASS grouped-GEMM fast path from #2045 cannot serve. This PR adds a dedicated path
that handles ragged per-expert token counts directly (SM90 TMA/WGMMA), zero-initializes empty
(K=0) groups, and writes each per-expert D_i in place. Inputs are BF16; output is FP32 (default)
or BF16. The standard uniform-K and Multi-Stream cuBLAS paths are unchanged.

Performance on H100 80GB, BF16, wgrad (D_i = B_iᵀ @ A_i), CUTLASS vs. the Multi-Stream cuBLAS
baseline. Shape is (g, m, n, k[mink, avgk, maxk]): g groups, m = expert dim, n = hidden dim,
k = the per-group routed-token count — the ragged contraction this kernel is built for.

run benchmark with

NVTE_USE_CUTLASS_GROUPED_GEMM=1 python benchmarks/gemm/benchmark_grouped_gemm_fwd_bwd.py --use-cutlass --dtype bf16 --num-experts <E> --ep-size 8 --hidden-dim 2048 --expert-dim 512 [--jagged-splits ...]

Shape(g, m, n, k[mink, avgk, maxk])TE (cuBLAS, TFLOPs)Cutlass (TFLOPs)Speed-Up
(20, 512, 2048, k[3328, 3328, 3328])445.50567.651.27×
(20, 512, 2048, k[512, 3104, 6016])444.52520.921.17×
(32, 512, 2048, k[1024, 2048, 3072])361.13564.131.56×
(32, 512, 2048, k[512, 1024, 1536])173.50512.612.95×

The gain grows as the per-group K shrinks: small, ragged groups are where the Multi-Stream cuBLAS
per-group launch overhead dominates.

Correctness reuses the existing test harness from #2045 (unchanged in this PR): the parametrized
tests/pytorch/test_grouped_linear.py::test_grouped_gemm with layout=NT (the wgrad case),
use_cutlass=True, dtype=bfloat16 over ragged group splits exercises exactly this path and passes
on SM90.

This path reuses the NVTE_USE_CUTLASS_GROUPED_GEMM toggle introduced in #2045 (default 0):
export NVTE_USE_CUTLASS_GROUPED_GEMM=1 routes the BF16 NT wgrad through CUTLASS, 0 keeps the
Multi-Stream cuBLAS implementation. NVTE_CUTLASS_GROUPED_GEMM_WARN_FALLBACK still warns on fallback.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes

  • cutlass_grouped_gemm.cuh: add CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD> — an SM90
    grouped-GEMM template specialized for the NT wgrad layout — with explicit instantiations for
    FP32 and BF16 output.
  • cutlass_grouped_gemm.cu: add cutlass_grouped_gemm_varlen_k(...). It validates the BF16 NT wgrad
    contract, splits groups into the non-empty set (excluding K=0 groups whose null A/B pointers
    would crash TMA descriptor construction, zero-initializing their outputs when not accumulating),
    and dispatches on output dtype — mirroring the existing cutlass_grouped_gemm call path.
  • cublaslt_gemm.cu: wire the path into the nvte_multi_tensor_gemm dispatch
    (uniform-K fast path → K-grouped wgrad → cuBLAS fallback).

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actionsgithub-actionsBot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Jun 1, 2026
@greptile-apps

greptile-appsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the existing CUTLASS Grouped GEMM path (from #2045) to handle the variable-K (ragged-K) BF16 weight-gradient case that arises in fine-grained MoE training on Hopper (SM90) and now Blackwell (SM100/SM103). It also refactors the host staging buffer from a monolithic 4 MB allocation to a 1024-slot pinned ring buffer (64 KB/slot, 64 MB total) to eliminate the per-call synchronization overhead imposed by pageable host memory.

  • Adds CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD, kSm100, kBigN> with SM90 Cooperative (FP32 output) / Pingpong (BF16 output) and SM100 2-SM tile variants, dispatched via a new cutlass_grouped_gemm_varlen_k function that filters out K=0 empty groups before launch.
  • Wires the new path into nvte_multi_tensor_gemm behind shape-eligibility guards (is_bf16_wgrad_dtype, is_bf16_wgrad_shape) so mismatched or unsupported shapes still fall back to cuBLAS.
  • Also adds forward-path SM100 instantiations for CutlassGroupedGemm, extends the host ring buffer for the forward path, and increases kMaxGroups from 64 to 256 to handle larger expert counts in expert-parallel MoE.

Confidence Score: 5/5

The new varlen-K wgrad dispatch path is well-guarded: shape eligibility is validated before entering the CUTLASS path, K=0 empty groups are correctly excluded with output zero-initialization when not accumulating, and the ring-buffer design properly prevents host-buffer reuse races across concurrent stream launches.

The core correctness logic — group filtering, NT-layout dispatch, SM90/SM100 tile selection, and cuBLAS fallback preservation — is sound. All findings are latent guards that are wrong in principle but cannot trigger given the current kMaxGroups=256 bound (~15 KB per slot, well within the 64 KB ring slot).

cutlass_grouped_gemm.cuh: the ring-buffer slot-size guard, the strict less-than workspace checks, and the two uninstantiated device-path functions whose null problem_sizes_host pointer could crash CUTLASS's scheduler if they are ever wired up without a matching host estimate.

Important Files Changed

FilenameOverview
transformer_engine/common/gemm/cutlass_grouped_gemm.cuhCore template file adding CutlassGroupedGemmWgrad, SM100 schedule selectors, ring-buffer host workspace, and two new unreachable device-path functions; ring-buffer size guard checks total buffer size instead of per-slot size, and workspace size checks use strict less-than
transformer_engine/common/gemm/cutlass_grouped_gemm.cuAdds explicit template instantiations for SM100 forward + wgrad variants; adds collect_bf16_wgrad_nt_groups and cutlass_grouped_gemm_varlen_k; correct SM100/SM90 dispatch logic
transformer_engine/common/gemm/cublaslt_gemm.cuAdds Blackwell detection, is_bf16_wgrad_dtype/shape eligibility guards, and the new else-if branch dispatching to cutlass_grouped_gemm_varlen_k; logic is correct and unguarded shapes fall back to cuBLAS
transformer_engine/common/gemm/cublaslt_grouped_gemm.cuAdds out_m, out_n, contraction_k fields to GroupedGemmConfig and increases kMaxGroups to 256; fields computed correctly but currently unused (pre-wired for future device-path integration)
tests/pytorch/test_grouped_linear.pyExtends skipif condition to include Blackwell (SM100/SM103) alongside Hopper (SM90); logically correct
transformer_engine/common/CMakeLists.txtAdds CUDA::nvrtc and CUDA::cuda_driver as public link dependencies; consistent with SM100 CUTLASS requirements

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading

Reviews (5): Last reviewed commit: "Merge branch 'NVIDIA:main' into feat/var..." | Re-trigger Greptile

Comment threadtransformer_engine/common/gemm/cutlass_grouped_gemm.cuh Outdated
Comment threadtransformer_engine/common/gemm/cublaslt_gemm.cu
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from d0edc9f to bda3dc3CompareJune 1, 2026 12:27
@alan-hpcalan-hpc changed the title Add variable-K (K-grouped) BF16 wgrad grouped GEMM (CUTLASS, SM90)[Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgradJun 1, 2026
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from f7a2b73 to e7a4db9CompareJune 1, 2026 12:58
@ptrendx

Copy link
Copy Markdown
Member

How does this kernel compare performance-wise with the cuBLASLt grouped gemm? Ideally if cuBLAS is better we would like to move towards that solution instead.

@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 0db8b00 to 0d190d0CompareJune 16, 2026 03:01
…m support
Signed-off-by: Min Yang <min.yang@shopee.com>
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 81c6fd2 to 1453a88CompareJune 16, 2026 03:05
@alan-hpcalan-hpc changed the title [Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgrad[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMMJun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionPRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-hpc@ptrendx
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM - #3069

Open
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm
Open

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM#3069
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm

Conversation

@alan-hpc

@alan-hpcalan-hpc commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR extends the CUTLASS Group GEMM support added in #2045 to cover the variable-K
(K-grouped / ragged-K) BF16 weight-gradient (wgrad)
path of fine-grained MoE models on H100 (SM90).

In expert-parallel MoE training the per-expert token counts — the contraction dimension of the
wgrad GEMM D_i = B_iᵀ @ A_i — are ragged and generally not 128-aligned, which the existing
uniform-K CUTLASS grouped-GEMM fast path from #2045 cannot serve. This PR adds a dedicated path
that handles ragged per-expert token counts directly (SM90 TMA/WGMMA), zero-initializes empty
(K=0) groups, and writes each per-expert D_i in place. Inputs are BF16; output is FP32 (default)
or BF16. The standard uniform-K and Multi-Stream cuBLAS paths are unchanged.

Performance on H100 80GB, BF16, wgrad (D_i = B_iᵀ @ A_i), CUTLASS vs. the Multi-Stream cuBLAS
baseline. Shape is (g, m, n, k[mink, avgk, maxk]): g groups, m = expert dim, n = hidden dim,
k = the per-group routed-token count — the ragged contraction this kernel is built for.

run benchmark with

NVTE_USE_CUTLASS_GROUPED_GEMM=1 python benchmarks/gemm/benchmark_grouped_gemm_fwd_bwd.py --use-cutlass --dtype bf16 --num-experts <E> --ep-size 8 --hidden-dim 2048 --expert-dim 512 [--jagged-splits ...]

Shape(g, m, n, k[mink, avgk, maxk])TE (cuBLAS, TFLOPs)Cutlass (TFLOPs)Speed-Up
(20, 512, 2048, k[3328, 3328, 3328])445.50567.651.27×
(20, 512, 2048, k[512, 3104, 6016])444.52520.921.17×
(32, 512, 2048, k[1024, 2048, 3072])361.13564.131.56×
(32, 512, 2048, k[512, 1024, 1536])173.50512.612.95×

The gain grows as the per-group K shrinks: small, ragged groups are where the Multi-Stream cuBLAS
per-group launch overhead dominates.

Correctness reuses the existing test harness from #2045 (unchanged in this PR): the parametrized
tests/pytorch/test_grouped_linear.py::test_grouped_gemm with layout=NT (the wgrad case),
use_cutlass=True, dtype=bfloat16 over ragged group splits exercises exactly this path and passes
on SM90.

This path reuses the NVTE_USE_CUTLASS_GROUPED_GEMM toggle introduced in #2045 (default 0):
export NVTE_USE_CUTLASS_GROUPED_GEMM=1 routes the BF16 NT wgrad through CUTLASS, 0 keeps the
Multi-Stream cuBLAS implementation. NVTE_CUTLASS_GROUPED_GEMM_WARN_FALLBACK still warns on fallback.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes

  • cutlass_grouped_gemm.cuh: add CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD> — an SM90
    grouped-GEMM template specialized for the NT wgrad layout — with explicit instantiations for
    FP32 and BF16 output.
  • cutlass_grouped_gemm.cu: add cutlass_grouped_gemm_varlen_k(...). It validates the BF16 NT wgrad
    contract, splits groups into the non-empty set (excluding K=0 groups whose null A/B pointers
    would crash TMA descriptor construction, zero-initializing their outputs when not accumulating),
    and dispatches on output dtype — mirroring the existing cutlass_grouped_gemm call path.
  • cublaslt_gemm.cu: wire the path into the nvte_multi_tensor_gemm dispatch
    (uniform-K fast path → K-grouped wgrad → cuBLAS fallback).

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actionsgithub-actionsBot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Jun 1, 2026
@greptile-apps

greptile-appsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the existing CUTLASS Grouped GEMM path (from #2045) to handle the variable-K (ragged-K) BF16 weight-gradient case that arises in fine-grained MoE training on Hopper (SM90) and now Blackwell (SM100/SM103). It also refactors the host staging buffer from a monolithic 4 MB allocation to a 1024-slot pinned ring buffer (64 KB/slot, 64 MB total) to eliminate the per-call synchronization overhead imposed by pageable host memory.

  • Adds CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD, kSm100, kBigN> with SM90 Cooperative (FP32 output) / Pingpong (BF16 output) and SM100 2-SM tile variants, dispatched via a new cutlass_grouped_gemm_varlen_k function that filters out K=0 empty groups before launch.
  • Wires the new path into nvte_multi_tensor_gemm behind shape-eligibility guards (is_bf16_wgrad_dtype, is_bf16_wgrad_shape) so mismatched or unsupported shapes still fall back to cuBLAS.
  • Also adds forward-path SM100 instantiations for CutlassGroupedGemm, extends the host ring buffer for the forward path, and increases kMaxGroups from 64 to 256 to handle larger expert counts in expert-parallel MoE.

Confidence Score: 5/5

The new varlen-K wgrad dispatch path is well-guarded: shape eligibility is validated before entering the CUTLASS path, K=0 empty groups are correctly excluded with output zero-initialization when not accumulating, and the ring-buffer design properly prevents host-buffer reuse races across concurrent stream launches.

The core correctness logic — group filtering, NT-layout dispatch, SM90/SM100 tile selection, and cuBLAS fallback preservation — is sound. All findings are latent guards that are wrong in principle but cannot trigger given the current kMaxGroups=256 bound (~15 KB per slot, well within the 64 KB ring slot).

cutlass_grouped_gemm.cuh: the ring-buffer slot-size guard, the strict less-than workspace checks, and the two uninstantiated device-path functions whose null problem_sizes_host pointer could crash CUTLASS's scheduler if they are ever wired up without a matching host estimate.

Important Files Changed

FilenameOverview
transformer_engine/common/gemm/cutlass_grouped_gemm.cuhCore template file adding CutlassGroupedGemmWgrad, SM100 schedule selectors, ring-buffer host workspace, and two new unreachable device-path functions; ring-buffer size guard checks total buffer size instead of per-slot size, and workspace size checks use strict less-than
transformer_engine/common/gemm/cutlass_grouped_gemm.cuAdds explicit template instantiations for SM100 forward + wgrad variants; adds collect_bf16_wgrad_nt_groups and cutlass_grouped_gemm_varlen_k; correct SM100/SM90 dispatch logic
transformer_engine/common/gemm/cublaslt_gemm.cuAdds Blackwell detection, is_bf16_wgrad_dtype/shape eligibility guards, and the new else-if branch dispatching to cutlass_grouped_gemm_varlen_k; logic is correct and unguarded shapes fall back to cuBLAS
transformer_engine/common/gemm/cublaslt_grouped_gemm.cuAdds out_m, out_n, contraction_k fields to GroupedGemmConfig and increases kMaxGroups to 256; fields computed correctly but currently unused (pre-wired for future device-path integration)
tests/pytorch/test_grouped_linear.pyExtends skipif condition to include Blackwell (SM100/SM103) alongside Hopper (SM90); logically correct
transformer_engine/common/CMakeLists.txtAdds CUDA::nvrtc and CUDA::cuda_driver as public link dependencies; consistent with SM100 CUTLASS requirements

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading

Reviews (5): Last reviewed commit: "Merge branch 'NVIDIA:main' into feat/var..." | Re-trigger Greptile

Comment threadtransformer_engine/common/gemm/cutlass_grouped_gemm.cuh Outdated
Comment threadtransformer_engine/common/gemm/cublaslt_gemm.cu
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from d0edc9f to bda3dc3CompareJune 1, 2026 12:27
@alan-hpcalan-hpc changed the title Add variable-K (K-grouped) BF16 wgrad grouped GEMM (CUTLASS, SM90)[Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgradJun 1, 2026
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from f7a2b73 to e7a4db9CompareJune 1, 2026 12:58
@ptrendx

Copy link
Copy Markdown
Member

How does this kernel compare performance-wise with the cuBLASLt grouped gemm? Ideally if cuBLAS is better we would like to move towards that solution instead.

@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 0db8b00 to 0d190d0CompareJune 16, 2026 03:01
…m support
Signed-off-by: Min Yang <min.yang@shopee.com>
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 81c6fd2 to 1453a88CompareJune 16, 2026 03:05
@alan-hpcalan-hpc changed the title [Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgrad[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMMJun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionPRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-hpc@ptrendx
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM - #3069

Open
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm
Open

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM#3069
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm

Conversation

@alan-hpc

@alan-hpcalan-hpc commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR extends the CUTLASS Group GEMM support added in #2045 to cover the variable-K
(K-grouped / ragged-K) BF16 weight-gradient (wgrad)
path of fine-grained MoE models on H100 (SM90).

In expert-parallel MoE training the per-expert token counts — the contraction dimension of the
wgrad GEMM D_i = B_iᵀ @ A_i — are ragged and generally not 128-aligned, which the existing
uniform-K CUTLASS grouped-GEMM fast path from #2045 cannot serve. This PR adds a dedicated path
that handles ragged per-expert token counts directly (SM90 TMA/WGMMA), zero-initializes empty
(K=0) groups, and writes each per-expert D_i in place. Inputs are BF16; output is FP32 (default)
or BF16. The standard uniform-K and Multi-Stream cuBLAS paths are unchanged.

Performance on H100 80GB, BF16, wgrad (D_i = B_iᵀ @ A_i), CUTLASS vs. the Multi-Stream cuBLAS
baseline. Shape is (g, m, n, k[mink, avgk, maxk]): g groups, m = expert dim, n = hidden dim,
k = the per-group routed-token count — the ragged contraction this kernel is built for.

run benchmark with

NVTE_USE_CUTLASS_GROUPED_GEMM=1 python benchmarks/gemm/benchmark_grouped_gemm_fwd_bwd.py --use-cutlass --dtype bf16 --num-experts <E> --ep-size 8 --hidden-dim 2048 --expert-dim 512 [--jagged-splits ...]

Shape(g, m, n, k[mink, avgk, maxk])TE (cuBLAS, TFLOPs)Cutlass (TFLOPs)Speed-Up
(20, 512, 2048, k[3328, 3328, 3328])445.50567.651.27×
(20, 512, 2048, k[512, 3104, 6016])444.52520.921.17×
(32, 512, 2048, k[1024, 2048, 3072])361.13564.131.56×
(32, 512, 2048, k[512, 1024, 1536])173.50512.612.95×

The gain grows as the per-group K shrinks: small, ragged groups are where the Multi-Stream cuBLAS
per-group launch overhead dominates.

Correctness reuses the existing test harness from #2045 (unchanged in this PR): the parametrized
tests/pytorch/test_grouped_linear.py::test_grouped_gemm with layout=NT (the wgrad case),
use_cutlass=True, dtype=bfloat16 over ragged group splits exercises exactly this path and passes
on SM90.

This path reuses the NVTE_USE_CUTLASS_GROUPED_GEMM toggle introduced in #2045 (default 0):
export NVTE_USE_CUTLASS_GROUPED_GEMM=1 routes the BF16 NT wgrad through CUTLASS, 0 keeps the
Multi-Stream cuBLAS implementation. NVTE_CUTLASS_GROUPED_GEMM_WARN_FALLBACK still warns on fallback.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes

  • cutlass_grouped_gemm.cuh: add CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD> — an SM90
    grouped-GEMM template specialized for the NT wgrad layout — with explicit instantiations for
    FP32 and BF16 output.
  • cutlass_grouped_gemm.cu: add cutlass_grouped_gemm_varlen_k(...). It validates the BF16 NT wgrad
    contract, splits groups into the non-empty set (excluding K=0 groups whose null A/B pointers
    would crash TMA descriptor construction, zero-initializing their outputs when not accumulating),
    and dispatches on output dtype — mirroring the existing cutlass_grouped_gemm call path.
  • cublaslt_gemm.cu: wire the path into the nvte_multi_tensor_gemm dispatch
    (uniform-K fast path → K-grouped wgrad → cuBLAS fallback).

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actionsgithub-actionsBot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Jun 1, 2026
@greptile-apps

greptile-appsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the existing CUTLASS Grouped GEMM path (from #2045) to handle the variable-K (ragged-K) BF16 weight-gradient case that arises in fine-grained MoE training on Hopper (SM90) and now Blackwell (SM100/SM103). It also refactors the host staging buffer from a monolithic 4 MB allocation to a 1024-slot pinned ring buffer (64 KB/slot, 64 MB total) to eliminate the per-call synchronization overhead imposed by pageable host memory.

  • Adds CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD, kSm100, kBigN> with SM90 Cooperative (FP32 output) / Pingpong (BF16 output) and SM100 2-SM tile variants, dispatched via a new cutlass_grouped_gemm_varlen_k function that filters out K=0 empty groups before launch.
  • Wires the new path into nvte_multi_tensor_gemm behind shape-eligibility guards (is_bf16_wgrad_dtype, is_bf16_wgrad_shape) so mismatched or unsupported shapes still fall back to cuBLAS.
  • Also adds forward-path SM100 instantiations for CutlassGroupedGemm, extends the host ring buffer for the forward path, and increases kMaxGroups from 64 to 256 to handle larger expert counts in expert-parallel MoE.

Confidence Score: 5/5

The new varlen-K wgrad dispatch path is well-guarded: shape eligibility is validated before entering the CUTLASS path, K=0 empty groups are correctly excluded with output zero-initialization when not accumulating, and the ring-buffer design properly prevents host-buffer reuse races across concurrent stream launches.

The core correctness logic — group filtering, NT-layout dispatch, SM90/SM100 tile selection, and cuBLAS fallback preservation — is sound. All findings are latent guards that are wrong in principle but cannot trigger given the current kMaxGroups=256 bound (~15 KB per slot, well within the 64 KB ring slot).

cutlass_grouped_gemm.cuh: the ring-buffer slot-size guard, the strict less-than workspace checks, and the two uninstantiated device-path functions whose null problem_sizes_host pointer could crash CUTLASS's scheduler if they are ever wired up without a matching host estimate.

Important Files Changed

FilenameOverview
transformer_engine/common/gemm/cutlass_grouped_gemm.cuhCore template file adding CutlassGroupedGemmWgrad, SM100 schedule selectors, ring-buffer host workspace, and two new unreachable device-path functions; ring-buffer size guard checks total buffer size instead of per-slot size, and workspace size checks use strict less-than
transformer_engine/common/gemm/cutlass_grouped_gemm.cuAdds explicit template instantiations for SM100 forward + wgrad variants; adds collect_bf16_wgrad_nt_groups and cutlass_grouped_gemm_varlen_k; correct SM100/SM90 dispatch logic
transformer_engine/common/gemm/cublaslt_gemm.cuAdds Blackwell detection, is_bf16_wgrad_dtype/shape eligibility guards, and the new else-if branch dispatching to cutlass_grouped_gemm_varlen_k; logic is correct and unguarded shapes fall back to cuBLAS
transformer_engine/common/gemm/cublaslt_grouped_gemm.cuAdds out_m, out_n, contraction_k fields to GroupedGemmConfig and increases kMaxGroups to 256; fields computed correctly but currently unused (pre-wired for future device-path integration)
tests/pytorch/test_grouped_linear.pyExtends skipif condition to include Blackwell (SM100/SM103) alongside Hopper (SM90); logically correct
transformer_engine/common/CMakeLists.txtAdds CUDA::nvrtc and CUDA::cuda_driver as public link dependencies; consistent with SM100 CUTLASS requirements

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading

Reviews (5): Last reviewed commit: "Merge branch 'NVIDIA:main' into feat/var..." | Re-trigger Greptile

Comment threadtransformer_engine/common/gemm/cutlass_grouped_gemm.cuh Outdated
Comment threadtransformer_engine/common/gemm/cublaslt_gemm.cu
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from d0edc9f to bda3dc3CompareJune 1, 2026 12:27
@alan-hpcalan-hpc changed the title Add variable-K (K-grouped) BF16 wgrad grouped GEMM (CUTLASS, SM90)[Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgradJun 1, 2026
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from f7a2b73 to e7a4db9CompareJune 1, 2026 12:58
@ptrendx

Copy link
Copy Markdown
Member

How does this kernel compare performance-wise with the cuBLASLt grouped gemm? Ideally if cuBLAS is better we would like to move towards that solution instead.

@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 0db8b00 to 0d190d0CompareJune 16, 2026 03:01
…m support
Signed-off-by: Min Yang <min.yang@shopee.com>
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 81c6fd2 to 1453a88CompareJune 16, 2026 03:05
@alan-hpcalan-hpc changed the title [Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgrad[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMMJun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionPRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-hpc@ptrendx
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM - #3069

Open
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm
Open

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM#3069
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm

Conversation

@alan-hpc

@alan-hpcalan-hpc commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR extends the CUTLASS Group GEMM support added in #2045 to cover the variable-K
(K-grouped / ragged-K) BF16 weight-gradient (wgrad)
path of fine-grained MoE models on H100 (SM90).

In expert-parallel MoE training the per-expert token counts — the contraction dimension of the
wgrad GEMM D_i = B_iᵀ @ A_i — are ragged and generally not 128-aligned, which the existing
uniform-K CUTLASS grouped-GEMM fast path from #2045 cannot serve. This PR adds a dedicated path
that handles ragged per-expert token counts directly (SM90 TMA/WGMMA), zero-initializes empty
(K=0) groups, and writes each per-expert D_i in place. Inputs are BF16; output is FP32 (default)
or BF16. The standard uniform-K and Multi-Stream cuBLAS paths are unchanged.

Performance on H100 80GB, BF16, wgrad (D_i = B_iᵀ @ A_i), CUTLASS vs. the Multi-Stream cuBLAS
baseline. Shape is (g, m, n, k[mink, avgk, maxk]): g groups, m = expert dim, n = hidden dim,
k = the per-group routed-token count — the ragged contraction this kernel is built for.

run benchmark with

NVTE_USE_CUTLASS_GROUPED_GEMM=1 python benchmarks/gemm/benchmark_grouped_gemm_fwd_bwd.py --use-cutlass --dtype bf16 --num-experts <E> --ep-size 8 --hidden-dim 2048 --expert-dim 512 [--jagged-splits ...]

Shape(g, m, n, k[mink, avgk, maxk])TE (cuBLAS, TFLOPs)Cutlass (TFLOPs)Speed-Up
(20, 512, 2048, k[3328, 3328, 3328])445.50567.651.27×
(20, 512, 2048, k[512, 3104, 6016])444.52520.921.17×
(32, 512, 2048, k[1024, 2048, 3072])361.13564.131.56×
(32, 512, 2048, k[512, 1024, 1536])173.50512.612.95×

The gain grows as the per-group K shrinks: small, ragged groups are where the Multi-Stream cuBLAS
per-group launch overhead dominates.

Correctness reuses the existing test harness from #2045 (unchanged in this PR): the parametrized
tests/pytorch/test_grouped_linear.py::test_grouped_gemm with layout=NT (the wgrad case),
use_cutlass=True, dtype=bfloat16 over ragged group splits exercises exactly this path and passes
on SM90.

This path reuses the NVTE_USE_CUTLASS_GROUPED_GEMM toggle introduced in #2045 (default 0):
export NVTE_USE_CUTLASS_GROUPED_GEMM=1 routes the BF16 NT wgrad through CUTLASS, 0 keeps the
Multi-Stream cuBLAS implementation. NVTE_CUTLASS_GROUPED_GEMM_WARN_FALLBACK still warns on fallback.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes

  • cutlass_grouped_gemm.cuh: add CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD> — an SM90
    grouped-GEMM template specialized for the NT wgrad layout — with explicit instantiations for
    FP32 and BF16 output.
  • cutlass_grouped_gemm.cu: add cutlass_grouped_gemm_varlen_k(...). It validates the BF16 NT wgrad
    contract, splits groups into the non-empty set (excluding K=0 groups whose null A/B pointers
    would crash TMA descriptor construction, zero-initializing their outputs when not accumulating),
    and dispatches on output dtype — mirroring the existing cutlass_grouped_gemm call path.
  • cublaslt_gemm.cu: wire the path into the nvte_multi_tensor_gemm dispatch
    (uniform-K fast path → K-grouped wgrad → cuBLAS fallback).

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actionsgithub-actionsBot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Jun 1, 2026
@greptile-apps

greptile-appsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the existing CUTLASS Grouped GEMM path (from #2045) to handle the variable-K (ragged-K) BF16 weight-gradient case that arises in fine-grained MoE training on Hopper (SM90) and now Blackwell (SM100/SM103). It also refactors the host staging buffer from a monolithic 4 MB allocation to a 1024-slot pinned ring buffer (64 KB/slot, 64 MB total) to eliminate the per-call synchronization overhead imposed by pageable host memory.

  • Adds CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD, kSm100, kBigN> with SM90 Cooperative (FP32 output) / Pingpong (BF16 output) and SM100 2-SM tile variants, dispatched via a new cutlass_grouped_gemm_varlen_k function that filters out K=0 empty groups before launch.
  • Wires the new path into nvte_multi_tensor_gemm behind shape-eligibility guards (is_bf16_wgrad_dtype, is_bf16_wgrad_shape) so mismatched or unsupported shapes still fall back to cuBLAS.
  • Also adds forward-path SM100 instantiations for CutlassGroupedGemm, extends the host ring buffer for the forward path, and increases kMaxGroups from 64 to 256 to handle larger expert counts in expert-parallel MoE.

Confidence Score: 5/5

The new varlen-K wgrad dispatch path is well-guarded: shape eligibility is validated before entering the CUTLASS path, K=0 empty groups are correctly excluded with output zero-initialization when not accumulating, and the ring-buffer design properly prevents host-buffer reuse races across concurrent stream launches.

The core correctness logic — group filtering, NT-layout dispatch, SM90/SM100 tile selection, and cuBLAS fallback preservation — is sound. All findings are latent guards that are wrong in principle but cannot trigger given the current kMaxGroups=256 bound (~15 KB per slot, well within the 64 KB ring slot).

cutlass_grouped_gemm.cuh: the ring-buffer slot-size guard, the strict less-than workspace checks, and the two uninstantiated device-path functions whose null problem_sizes_host pointer could crash CUTLASS's scheduler if they are ever wired up without a matching host estimate.

Important Files Changed

FilenameOverview
transformer_engine/common/gemm/cutlass_grouped_gemm.cuhCore template file adding CutlassGroupedGemmWgrad, SM100 schedule selectors, ring-buffer host workspace, and two new unreachable device-path functions; ring-buffer size guard checks total buffer size instead of per-slot size, and workspace size checks use strict less-than
transformer_engine/common/gemm/cutlass_grouped_gemm.cuAdds explicit template instantiations for SM100 forward + wgrad variants; adds collect_bf16_wgrad_nt_groups and cutlass_grouped_gemm_varlen_k; correct SM100/SM90 dispatch logic
transformer_engine/common/gemm/cublaslt_gemm.cuAdds Blackwell detection, is_bf16_wgrad_dtype/shape eligibility guards, and the new else-if branch dispatching to cutlass_grouped_gemm_varlen_k; logic is correct and unguarded shapes fall back to cuBLAS
transformer_engine/common/gemm/cublaslt_grouped_gemm.cuAdds out_m, out_n, contraction_k fields to GroupedGemmConfig and increases kMaxGroups to 256; fields computed correctly but currently unused (pre-wired for future device-path integration)
tests/pytorch/test_grouped_linear.pyExtends skipif condition to include Blackwell (SM100/SM103) alongside Hopper (SM90); logically correct
transformer_engine/common/CMakeLists.txtAdds CUDA::nvrtc and CUDA::cuda_driver as public link dependencies; consistent with SM100 CUTLASS requirements

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading

Reviews (5): Last reviewed commit: "Merge branch 'NVIDIA:main' into feat/var..." | Re-trigger Greptile

Comment threadtransformer_engine/common/gemm/cutlass_grouped_gemm.cuh Outdated
Comment threadtransformer_engine/common/gemm/cublaslt_gemm.cu
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from d0edc9f to bda3dc3CompareJune 1, 2026 12:27
@alan-hpcalan-hpc changed the title Add variable-K (K-grouped) BF16 wgrad grouped GEMM (CUTLASS, SM90)[Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgradJun 1, 2026
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from f7a2b73 to e7a4db9CompareJune 1, 2026 12:58
@ptrendx

Copy link
Copy Markdown
Member

How does this kernel compare performance-wise with the cuBLASLt grouped gemm? Ideally if cuBLAS is better we would like to move towards that solution instead.

@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 0db8b00 to 0d190d0CompareJune 16, 2026 03:01
…m support
Signed-off-by: Min Yang <min.yang@shopee.com>
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 81c6fd2 to 1453a88CompareJune 16, 2026 03:05
@alan-hpcalan-hpc changed the title [Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgrad[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMMJun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionPRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-hpc@ptrendx
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM - #3069

Open
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm
Open

[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMM#3069
alan-hpc wants to merge 3 commits into
NVIDIA:mainfrom
alan-hpc:feat/varlenk_groupgemm

Conversation

@alan-hpc

@alan-hpcalan-hpc commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR extends the CUTLASS Group GEMM support added in #2045 to cover the variable-K
(K-grouped / ragged-K) BF16 weight-gradient (wgrad)
path of fine-grained MoE models on H100 (SM90).

In expert-parallel MoE training the per-expert token counts — the contraction dimension of the
wgrad GEMM D_i = B_iᵀ @ A_i — are ragged and generally not 128-aligned, which the existing
uniform-K CUTLASS grouped-GEMM fast path from #2045 cannot serve. This PR adds a dedicated path
that handles ragged per-expert token counts directly (SM90 TMA/WGMMA), zero-initializes empty
(K=0) groups, and writes each per-expert D_i in place. Inputs are BF16; output is FP32 (default)
or BF16. The standard uniform-K and Multi-Stream cuBLAS paths are unchanged.

Performance on H100 80GB, BF16, wgrad (D_i = B_iᵀ @ A_i), CUTLASS vs. the Multi-Stream cuBLAS
baseline. Shape is (g, m, n, k[mink, avgk, maxk]): g groups, m = expert dim, n = hidden dim,
k = the per-group routed-token count — the ragged contraction this kernel is built for.

run benchmark with

NVTE_USE_CUTLASS_GROUPED_GEMM=1 python benchmarks/gemm/benchmark_grouped_gemm_fwd_bwd.py --use-cutlass --dtype bf16 --num-experts <E> --ep-size 8 --hidden-dim 2048 --expert-dim 512 [--jagged-splits ...]

Shape(g, m, n, k[mink, avgk, maxk])TE (cuBLAS, TFLOPs)Cutlass (TFLOPs)Speed-Up
(20, 512, 2048, k[3328, 3328, 3328])445.50567.651.27×
(20, 512, 2048, k[512, 3104, 6016])444.52520.921.17×
(32, 512, 2048, k[1024, 2048, 3072])361.13564.131.56×
(32, 512, 2048, k[512, 1024, 1536])173.50512.612.95×

The gain grows as the per-group K shrinks: small, ragged groups are where the Multi-Stream cuBLAS
per-group launch overhead dominates.

Correctness reuses the existing test harness from #2045 (unchanged in this PR): the parametrized
tests/pytorch/test_grouped_linear.py::test_grouped_gemm with layout=NT (the wgrad case),
use_cutlass=True, dtype=bfloat16 over ragged group splits exercises exactly this path and passes
on SM90.

This path reuses the NVTE_USE_CUTLASS_GROUPED_GEMM toggle introduced in #2045 (default 0):
export NVTE_USE_CUTLASS_GROUPED_GEMM=1 routes the BF16 NT wgrad through CUTLASS, 0 keeps the
Multi-Stream cuBLAS implementation. NVTE_CUTLASS_GROUPED_GEMM_WARN_FALLBACK still warns on fallback.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes

  • cutlass_grouped_gemm.cuh: add CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD> — an SM90
    grouped-GEMM template specialized for the NT wgrad layout — with explicit instantiations for
    FP32 and BF16 output.
  • cutlass_grouped_gemm.cu: add cutlass_grouped_gemm_varlen_k(...). It validates the BF16 NT wgrad
    contract, splits groups into the non-empty set (excluding K=0 groups whose null A/B pointers
    would crash TMA descriptor construction, zero-initializing their outputs when not accumulating),
    and dispatches on output dtype — mirroring the existing cutlass_grouped_gemm call path.
  • cublaslt_gemm.cu: wire the path into the nvte_multi_tensor_gemm dispatch
    (uniform-K fast path → K-grouped wgrad → cuBLAS fallback).

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actionsgithub-actionsBot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Jun 1, 2026
@greptile-apps

greptile-appsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the existing CUTLASS Grouped GEMM path (from #2045) to handle the variable-K (ragged-K) BF16 weight-gradient case that arises in fine-grained MoE training on Hopper (SM90) and now Blackwell (SM100/SM103). It also refactors the host staging buffer from a monolithic 4 MB allocation to a 1024-slot pinned ring buffer (64 KB/slot, 64 MB total) to eliminate the per-call synchronization overhead imposed by pageable host memory.

  • Adds CutlassGroupedGemmWgrad<trans_a, trans_b, ElementD, kSm100, kBigN> with SM90 Cooperative (FP32 output) / Pingpong (BF16 output) and SM100 2-SM tile variants, dispatched via a new cutlass_grouped_gemm_varlen_k function that filters out K=0 empty groups before launch.
  • Wires the new path into nvte_multi_tensor_gemm behind shape-eligibility guards (is_bf16_wgrad_dtype, is_bf16_wgrad_shape) so mismatched or unsupported shapes still fall back to cuBLAS.
  • Also adds forward-path SM100 instantiations for CutlassGroupedGemm, extends the host ring buffer for the forward path, and increases kMaxGroups from 64 to 256 to handle larger expert counts in expert-parallel MoE.

Confidence Score: 5/5

The new varlen-K wgrad dispatch path is well-guarded: shape eligibility is validated before entering the CUTLASS path, K=0 empty groups are correctly excluded with output zero-initialization when not accumulating, and the ring-buffer design properly prevents host-buffer reuse races across concurrent stream launches.

The core correctness logic — group filtering, NT-layout dispatch, SM90/SM100 tile selection, and cuBLAS fallback preservation — is sound. All findings are latent guards that are wrong in principle but cannot trigger given the current kMaxGroups=256 bound (~15 KB per slot, well within the 64 KB ring slot).

cutlass_grouped_gemm.cuh: the ring-buffer slot-size guard, the strict less-than workspace checks, and the two uninstantiated device-path functions whose null problem_sizes_host pointer could crash CUTLASS's scheduler if they are ever wired up without a matching host estimate.

Important Files Changed

FilenameOverview
transformer_engine/common/gemm/cutlass_grouped_gemm.cuhCore template file adding CutlassGroupedGemmWgrad, SM100 schedule selectors, ring-buffer host workspace, and two new unreachable device-path functions; ring-buffer size guard checks total buffer size instead of per-slot size, and workspace size checks use strict less-than
transformer_engine/common/gemm/cutlass_grouped_gemm.cuAdds explicit template instantiations for SM100 forward + wgrad variants; adds collect_bf16_wgrad_nt_groups and cutlass_grouped_gemm_varlen_k; correct SM100/SM90 dispatch logic
transformer_engine/common/gemm/cublaslt_gemm.cuAdds Blackwell detection, is_bf16_wgrad_dtype/shape eligibility guards, and the new else-if branch dispatching to cutlass_grouped_gemm_varlen_k; logic is correct and unguarded shapes fall back to cuBLAS
transformer_engine/common/gemm/cublaslt_grouped_gemm.cuAdds out_m, out_n, contraction_k fields to GroupedGemmConfig and increases kMaxGroups to 256; fields computed correctly but currently unused (pre-wired for future device-path integration)
tests/pytorch/test_grouped_linear.pyExtends skipif condition to include Blackwell (SM100/SM103) alongside Hopper (SM90); logically correct
transformer_engine/common/CMakeLists.txtAdds CUDA::nvrtc and CUDA::cuda_driver as public link dependencies; consistent with SM100 CUTLASS requirements

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["nvte_multi_tensor_gemm()"] --> B{is Hopper or Blackwell\nAND use_cutlass?}
B -- No --> C["cublas_path() fallback"]
B -- Yes --> D{all_groups_uniform_k128\nAND no epilogue\nAND BF16/FP16 dtype}
D -- Yes --> E["cutlass_grouped_gemm()\nuniform-K forward SM90+SM100"]
D -- No --> F{is_bf16_wgrad_dtype\nAND NT layout AND grad\nAND is_bf16_wgrad_shape}
F -- Yes --> G["cutlass_grouped_gemm_varlen_k()\nragged-K BF16 wgrad"]
F -- No --> H["warn_fallback then cublas_path()"]
G --> I["collect_bf16_wgrad_nt_groups()\nfilter K=0 groups\nzero-init empty outputs"]
I --> J{A_nz empty?}
J -- Yes --> K["return early all K=0"]
J -- No --> L{SM100?}
L -- No --> M["CutlassGroupedGemmWgrad\nSM90 Cooperative FP32\nor Pingpong BF16"]
L -- Yes --> N{avg_K >= 1536?}
N -- Yes --> O["CutlassGroupedGemmWgrad\nSM100 256x256 kBigN=true"]
N -- No --> P["CutlassGroupedGemmWgrad\nSM100 256x128 kBigN=false"]
M --> Q["getHostWorkspace ring slot\nfill ptrs+shapes cudaMemcpyAsync\nCUTLASS kernel launch"]
O --> Q
P --> Q
Loading

Reviews (5): Last reviewed commit: "Merge branch 'NVIDIA:main' into feat/var..." | Re-trigger Greptile

Comment threadtransformer_engine/common/gemm/cutlass_grouped_gemm.cuh Outdated
Comment threadtransformer_engine/common/gemm/cublaslt_gemm.cu
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from d0edc9f to bda3dc3CompareJune 1, 2026 12:27
@alan-hpcalan-hpc changed the title Add variable-K (K-grouped) BF16 wgrad grouped GEMM (CUTLASS, SM90)[Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgradJun 1, 2026
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from f7a2b73 to e7a4db9CompareJune 1, 2026 12:58
@ptrendx

Copy link
Copy Markdown
Member

How does this kernel compare performance-wise with the cuBLASLt grouped gemm? Ideally if cuBLAS is better we would like to move towards that solution instead.

@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 0db8b00 to 0d190d0CompareJune 16, 2026 03:01
…m support
Signed-off-by: Min Yang <min.yang@shopee.com>
@alan-hpc
alan-hpcforce-pushed the feat/varlenk_groupgemm branch from 81c6fd2 to 1453a88CompareJune 16, 2026 03:05
@alan-hpcalan-hpc changed the title [Pytorch] Add variable-K Cutlass GroupGEMM for fine-grained MoE wgrad[Pytorch] Add B200&B300 BF16 Cutlass GroupGEMM for fine-grained MoE and Varlen-K WGrad Grouped GEMMJun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionPRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-hpc@ptrendx