Uh oh!
There was an error while loading. Please reload this page.
[PyTorch] NCCL EP zero copy with symmem pool and user provided recv_topk_weight tensor - #3187
Conversation
Signed-off-by: YangFei1990 <feiw@nvidia.com>
…Buffer Signed-off-by: YangFei1990 <feiw@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Greptile SummaryThis PR replaces the static,
Confidence Score: 5/5Safe to merge. The refactor correctly moves symm-mem buffer ownership out of EpBuffer and into on-demand pool allocation, with no changes to the C++ dispatch/combine kernels. The allocation logic is consistent across forward and backward, No files require special attention. The two observations are minor: Important Files Changed
Reviews (5): Last reviewed commit: "Merge branch 'main' into nccl_ep_zero_cp" | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
phu0ngng
commented
Jul 21, 2026
/te-ci pytorch L1 |
- _get_symm_mem_pool: raise if a later call requests a different backend than the one the process-wide pool was created with (was silently ignored). - is_symm_backed: raise a clear error if called before bootstrap (_EP_GROUP is None) instead of letting the bare except swallow the AttributeError. Signed-off-by: YangFei1990 <feiw@nvidia.com>
phu0ngng
commented
Jul 21, 2026
/te-ci pytorch L1 |
Uh oh!
There was an error while loading. Please reload this page.
KshitijLakhani
commented
Jul 21, 2026
@phu0ngng and @YangFei1990 is this supposed to be cherry-picked for TE 2.18 cc: @fheinecke (Just FYI - no action needed) |
…opk_weight tensor (#3187) * expose user-provided weights * adding pool based symm allocation; remove the persistent buffer in EpBuffer * add zero copy tests Signed-off-by: YangFei1990 <feiw@nvidia.com> --------- Signed-off-by: YangFei1990 <feiw@nvidia.com> Co-authored-by: Phuong Nguyen <phuonguyen@nvidia.com>
Description
Addition support for NCCL EP zero copy feature, including
Checklist: