Uh oh!
There was an error while loading. Please reload this page.
[Common][PyTorch] EP dispatch with unfused MXFP8 quantization - #3270
Conversation
Greptile SummaryAdds unfused MXFP8 quantization support to NCCL expert-parallel dispatch and combine backward.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains, and the previously reported ignore-file deletion has been fully restored in the current tree. Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant PyEP as PyTorch EP
participant Quant as MXFP8 Quantizer
participant Backend as NCCL EP Backend
participant Expert
Caller->>PyEP: ep_dispatch(BF16 tokens)
PyEP->>Quant: quantize data and block scales
Quant-->>PyEP: E4M3 data + E8M0 scales
PyEP->>Backend: dispatch data and scales
Backend-->>Expert: per-expert GroupedTensor
Expert->>PyEP: ep_combine(expert output)
PyEP-->>Caller: high-precision combined result
Caller->>PyEP: result gradient
PyEP->>Quant: quantize gradient
PyEP->>Backend: reverse dispatch data and scales
Backend-->>Expert: grouped expert-output gradient
Reviews (10): Last reviewed commit: "Merge branch 'main' into ep_mxfp8" | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
phu0ngng
commented
Jul 30, 2026
/te-ci L1 pytorch |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
…der CUDA graph capture Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
…CUDA-graph capture Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
phu0ngng
commented
Aug 6, 2026
/te-ci L1 |
phu0ngng
commented
Aug 6, 2026
/te-ci L1 |
phu0ngng
commented
Aug 7, 2026
/te-ci L1 |
YangFei1990
left a comment
There was a problem hiding this comment.
Need to further align on API contracts before merging
phu0ngng
commented
Aug 10, 2026
/te-ci L1 |
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
phu0ngng
commented
Aug 11, 2026
/te-ci L1 |
Description
This PR adds MXFP8 support to the dispatch op of the NCCL EP path. The dispatch op is used in two places, and MXFP8 applies to both:
GroupedTensor.GroupedTensor.Type of change
Changes
PyTorch frontend (
transformer_engine/pytorch/ep.py,distributed.py,csrc/extensions/ep.cpp)**dispatch_quant_recipeis set (MXFP8BlockScalingonly for now); dispatch-forward recv is returned as a per-expertGroupedTensor. A pre-quantized input is rejected.GroupedTensor. Combine forward is unchanged (high-precision).Common backend (
common/ep/ep_backend.cpp,include/.../ep.h,comm_window.h)**NCCL EP submodule**
3rdparty/nccl-extensionsto the revision providing block-scaled dispatch.Tests (
tests/cpp_distributed/test_ep.cu,tests/pytorch/distributed/run_ep.py,run_test_ep.sh)**NVTE_EP_MXFP8_PASSrun since the grouped path pins the per-expert alignment process-wide.Checklist: