Skip to content

fix: remove unused import time - #3364

Merged
cyanguwa merged 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-attention-with-cp-remove-unused-import-time
Aug 13, 2026
Merged

fix: remove unused import time#3364
cyanguwa merged 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-attention-with-cp-remove-unused-import-time

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Contributor

This PR addresses the following issue in tests/pytorch/attention/test_attention_with_cp.py: remove unused import time.

Changes

  • tests/pytorch/attention/test_attention_with_cp.py: remove unused import time.

Details

--- a/tests/pytorch/attention/test_attention_with_cp.py+++ b/tests/pytorch/attention/test_attention_with_cp.py@@ -1,12 +1,11 @@-import json-import os-import select-import signal-import subprocess-import sys-import threading-import time-import pathlib-import logging-import copy-from collections import deque+import json+import os+import select+import signal+import subprocess+import sys+import threading+import pathlib+import logging+import copy+from collections import deque

Tests

Let me know if you want tests added for this fix or not.

@github-actionsgithub-actionsBot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Aug 13, 2026
@greptile-apps

greptile-appsBot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the unused time import from the context-parallel PyTorch attention test.

  • Leaves test behavior and runtime logic unchanged.
  • Reduces an unnecessary standard-library dependency in the test module.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

FilenameOverview
tests/pytorch/attention/test_attention_with_cp.pyRemoves an unused standard-library import without affecting test behavior.

Reviews (2): Last reviewed commit: "fix: remove unused `import time`" | Re-trigger Greptile

@cyanguwa

Copy link
Copy Markdown
Collaborator

Please fix the DCO for this PR as well. Thanks.

Squashed to single commit for review.
Original PR: #14
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw
andrewwhitecdwforce-pushed the codequality/test-attention-with-cp-remove-unused-import-time branch from 09b8930 to 2029a52CompareAugust 13, 2026 16:41
@cyanguwa
cyanguwa merged commit 900ac82 into NVIDIA:mainAug 13, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionPRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewwhitecdw@cyanguwa