Uh oh!
There was an error while loading. Please reload this page.
[JAX] Adapt to Flax 0.7.1 - #353
Merged
Merged
Conversation
mingxu1067
commented
Aug 2, 2023
CollaboratorAuthor
@zlsh80826, @jeng1220, @nouiz for viz. |
mingxu1067
commented
Aug 2, 2023
CollaboratorAuthor
/te-ci |
zlsh80826
commented
Aug 2, 2023
Collaborator
Hi Ming, |
mingxu1067force-pushed
the
mingh/adapt_to_flax_071
branch
from
August 2, 2023 09:15
1f8618f to
72475eaComparemingxu1067
commented
Aug 2, 2023
CollaboratorAuthor
Thanks Reese for pointing this out, apopt this changes. |
mingxu1067
commented
Aug 2, 2023
CollaboratorAuthor
/te-ci |
nouiz
commented
Aug 2, 2023
Collaborator
Need to update the min flax version somewhere. |
mingxu1067force-pushed
the
mingh/adapt_to_flax_071
branch
from
August 3, 2023 02:38
663991b to
94b91cdComparemingxu1067
commented
Aug 3, 2023
CollaboratorAuthor
Done, by adding it to |
mingxu1067
commented
Aug 3, 2023
CollaboratorAuthor
/te-ci |
Signed-off-by: Ming Huang <mingh@nvidia.com>
Signed-off-by: Ming Huang <mingh@nvidia.com>
Signed-off-by: Ming Huang <mingh@nvidia.com>
Refactor fp8 state Signed-off-by: Tian Zheng (Engrg-Hardware 1) <tizheng@nvidia.com> Signed-off-by: Ming Huang <mingh@nvidia.com>
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Ming Huang <mingh@nvidia.com>
Signed-off-by: Ming Huang <mingh@nvidia.com>
mingxu1067force-pushed
the
mingh/adapt_to_flax_071
branch
from
August 3, 2023 09:11
982e5bd to
485fb2bComparemingxu1067
commented
Aug 3, 2023
CollaboratorAuthor
/te-ci |
yhtang
commented
Aug 3, 2023
nouiz
commented
Aug 3, 2023
Collaborator
Any idea why it is fixed? Should we drop this PR? |
timmoon10
self-requested a review
August 3, 2023 16:23
timmoon10
commented
Aug 3, 2023
Member
It looks like JAX-Toolbox is fetching this branch, so we should merge soon. We should also update the Flax version in Line 298 in 85928d0 |
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cast Flax collections to FrozenDict as WAR to adapt Flax 0.7.1.The root cause is that
FrozenDictis removed from Flax 0.7.1, insteadmodule.init()returns python built-indictwhich has different behavior ofpopwithFrozenDict. FrozenDict's pop reuturns two outputs, remaining FrozenDict and popped value, but python built-in dict only returns popped value then in-place delete it in orginal object.Meanwhile, add fully remove
FrozenDictinto TODO and will schedule time to fix internally.Refer to #352